LEAHI-SW-SCRIPTS-LDT-2727-1 LEAHI-SW-SCRIPTS-LDT-2727_Service - SW - 01 - Service - R&I

open for 5 weeks

Author

Moderator

Reviewers

LEAHI-SW-SCRIPTS-LDT-2727_Service - SW - 01 - Service - R&I

Activity

Details
Objectives
General Comments 4
Unresolved
Resolved
Number of files included: 8

leahi-sw.scripts 0
- Folder scripts 0
  - File _errors_ 0 Remove
  - File bluetooth_paired_clear.sh 3 Remove
  - File date_time_set.sh 0 Remove
  - File decommission.sh 0 Remove
  - File factory_reset.sh 0 Remove
  - File rootsshaccess.sh 2 Remove
  - File wifi_disconnect_network.sh 3 Remove
  - File wifi_scan.sh 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Nicholas Ramirez	Author & Moderator	27m	5	added
Stephen Quong	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed
Behrouz NematiPour	Reviewer - 100% reviewed	55m	7	This does not entirely follow the standard. But it is fin...
Dara Navaei	Reviewer - 0% reviewed	0m
Sean Nash	Reviewer - 0% reviewed
Total		1h 24m	12

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Behrouz NematiPour

All the script files need to follow the same format as the wifi_scan.sh. /sa ...

All the script files need to follow the same format as the wifi_scan.sh.
/sa this link

12 Nov

Behrouz NematiPour

Resolved

10 Dec

Behrouz NematiPour

Also, regarding the above format, each script needs to check whether a comman...

Also, regarding the above format, each script needs to check whether a command fails and gracefully exit either way.

12 Nov

Nicholas Ramirez

added the checks and graceful exit

13 Nov

Nicholas Ramirez

Updated to follow format

13 Nov

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-SW-SCRIPTS-LDT-2727-1

LEAHI-SW-SCRIPTS-LDT-2727_Service - SW - 01 - Service - R&I

LEAHI-SW-SCRIPTS-LDT-2727-1 12

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

Behrouz NematiPour

Nicholas Ramirez

Nicholas Ramirez

Log time

LEAHI-SW-SCRIPTS-LDT-2727_Service - SW - 01 - Service - R&I

LEAHI-SW-SCRIPTS-LDT-2727-1 12

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

Behrouz NematiPour

Nicholas Ramirez

Nicholas Ramirez

Log time