RO-LDT-566-1 RO-LDT-566_Water Treatment And Degassing FP

closed on 02 Jul

Author

Moderator

Reviewers

RO-LDT-566_Water Treatment And Degassing FP

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 94

leahi-common 0
- File AlarmDefs.h 8 Remove
- File MsgDefs.h 7 Remove
- File RODefs.h 6 Remove
leahi-fwcommon 0
- File AlarmMgmt.c 0 Remove
- File AlarmMgmt.h 0 Remove
- File Comm.h 0 Remove
- File CommBuffers.c 0 Remove
- File CommBuffers.h 2 Remove
- File FPGA.c 0 Remove
- File FPGA.h 0 Remove
- File MessagePayloads.h 0 Remove
- File PIControllers.c 0 Remove
- File PIControllers.h 0 Remove
- File PersistentAlarm.c 0 Remove
- File PressureCommon.h 0 Remove
- File SystemComm.c 0 Remove
- File SystemComm.h 0 Remove
- File TestSupport.c 0 Remove
- File TestSupport.h 0 Remove
- File Utilities.h 0 Remove
- File WatchdogMgmt.h 0 Remove
ro-firmware 0
- Folder firmware 0
  - Folder .settings 0
    - File org.eclipse.core.resources.prefs 0 Remove
  - Folder App 0
    - Folder Controllers 0
      - File BoostPump.c 49 Remove
      - File BoostPump.h 4 Remove
      - File Heaters.c 4 Remove
      - File Heaters.h 0 Remove
      - File ROPump.c 33 Remove
      - File ROPump.h 4 Remove
      - File Valves.c 0 Remove
      - File Valves.h 0 Remove
    - Folder Drivers 0
      - File BoostPump.c 0 Remove
      - File BoostPump.h 0 Remove
      - File ConductivitySensor.c 2 Remove
      - File ConductivitySensor.h 0 Remove
      - File ConductivitySensors.c 0 Remove
      - File ConductivitySensors.h 0 Remove
      - File FlowSensor.c 2 Remove
      - File FlowSensor.h 0 Remove
      - File FluidPump.c 6 Remove
      - File FluidPump.h 12 Remove
      - File InternalADC.h 0 Remove
      - File PAL.h 0 Remove
      - File PressureSensor.c 6 Remove
      - File PressureSensor.h 0 Remove
      - File SafetyShutdown.h 2 Remove
      - File TemperatureSensor.c 4 Remove
      - File TemperatureSensor.h 4 Remove
      - File TemperatureSensors.c 0 Remove
      - File TemperatureSensors.h 0 Remove
    - Folder Modes 0
      - File FilterFlush.c 8 Remove
      - File FilterFlush.h 0 Remove
      - File MembraneFlush.c 0 Remove
      - File MembraneFlush.h 0 Remove
      - File ModeFault.h 2 Remove
      - File ModeInitPOST.h 0 Remove
      - File ModeStandby.c 1 Remove
      - File ModeStandby.h 0 Remove
      - File ModeWaterGen.c 2 Remove
      - File ModeWaterGen.h 0 Remove
      - File ModeWaterPreGen.c 4 Remove
      - File ModeWaterPreGen.h 0 Remove
      - File OperationModes.c 6 Remove
      - File OperationModes.h 2 Remove
    - Folder Monitors 0
      - File Conductivity.c 0 Remove
      - File Conductivity.h 0 Remove
      - File Flow.c 0 Remove
      - File Flow.h 0 Remove
      - File Level.c 0 Remove
      - File Level.h 0 Remove
      - File Pressure.c 2 Remove
      - File Pressure.h 0 Remove
      - File Temperature.c 2 Remove
      - File Temperature.h 0 Remove
    - Folder Services 0
      - File AlarmMgmtRO.c 2 Remove
      - File AlarmMgmtRO.h 0 Remove
      - File AlarmMgmtSWFaults.h 0 Remove
      - File DDInterface.c 2 Remove
      - File DDInterface.h 2 Remove
      - File FpgaRO.c 0 Remove
      - File FpgaRO.h 0 Remove
      - File Interrupts.c 0 Remove
      - File Interrupts.h 0 Remove
      - File Messaging.c 0 Remove
      - File Messaging.h 0 Remove
      - File MsgQueues.c 0 Remove
      - File MsgQueues.h 0 Remove
      - File SystemCommRO.c 0 Remove
      - File SystemCommRO.h 0 Remove
    - Folder Tasks 0
      - File TaskBG.c 0 Remove
      - File TaskGeneral.h 0 Remove
    - File FPCommon.h 0 Remove
    - File ROCommon.h 0 Remove
  - Folder source 0
    - File sys_main.c 2 Remove
  - File .cproject 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Michael Garthwaite	Author & Moderator	1h 58m	85	fixed. thanks!
Sean Nash	Reviewer - Complete	3h 1m	97	Why did we remove the code that deals with read/error cou...
Dara Navaei	Reviewer - 1% reviewed	8m
Behrouz NematiPour	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - Complete	19m	2	RESOLVED
Daniel Ho	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 52% reviewed	1h 4m	8	I mean, for Inputs, outputs, Alarms and Message, use \b i...
Total		6h 32m	192

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/firmware/.../Drivers/ConductivitySensors.c Deleted

Click to load diff

/firmware/.../Drivers/ConductivitySensors.h Deleted

Click to load diff

/firmware/App/Drivers/TemperatureSensors.c Deleted

Click to load diff

/firmware/App/Drivers/TemperatureSensors.h Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

RO-LDT-566-1

RO-LDT-566_Water Treatment And Degassing FP

RO-LDT-566-1 192

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

RO-LDT-566_Water Treatment And Degassing FP

RO-LDT-566-1 192

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time