SRVC-DEN-7335_DIAL-76 Data Logging

Activity

SRVC-DEN-7335-1 5

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    plucia  (deleted user)
    Author 14m 1 Agreed - I don't want them to have to guess the type. At ...
    Reviewer - Complete 3m    
    pmontazemi  (deleted user)
    Reviewer completed
    Reviewer - Complete 5m 4 RESOLVED.
    Reviewer - Complete 2m    
    Total   25m 5  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /fwcontroller/base/base_widget.py Changed
    Open in IDE #permalink
    Repository firmwarecontroller does not exist
    /fwcontroller/globals/__init__.py Changed
    Open in IDE #permalink
    Repository firmwarecontroller does not exist
    /fwcontroller/globals/data_logger.py Added
    Open in IDE #permalink
    Repository firmwarecontroller does not exist
    /fwcontroller/globals/utils.py Changed
    Open in IDE #permalink
    Repository firmwarecontroller does not exist
    /fwcontroller/main/dg.py Changed 2
    Open in IDE #permalink
    Repository firmwarecontroller does not exist
    /fwcontroller/main/hd.py Changed
    Open in IDE #permalink
    Repository firmwarecontroller does not exist
    /fwcontroller/main/main_window.py Changed
    Open in IDE #permalink
    Repository firmwarecontroller does not exist
    /fwcontroller/submodule/submodule_control.py Changed 3
    Open in IDE #permalink
    Repository firmwarecontroller does not exist
    /fwcontroller/submodule/submodule_monitor.py Changed
    Open in IDE #permalink
    Repository firmwarecontroller does not exist
    /.gitignore Changed
    Open in IDE #permalink
    Repository firmwarecontroller does not exist
    /main.py Changed
    Open in IDE #permalink
    Repository firmwarecontroller does not exist
    /requirements.txt Changed
    Open in IDE #permalink
    Repository firmwarecontroller does not exist

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time