UI-DEN-13962-1 UI-DEN-13962_UI BN S82

closed on 08 Nov 22

Author

Moderator

Reviewers

UI-DEN-13962_UI BN S82

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 32

application 0
- Folder sources 0
  - Folder canbus 0
    - File MessageDispatcher.cpp 0 Remove
  - Folder gui/qml 0
    - Folder components 0
      - File ConfirmTreatmentTable.qml 0 Remove
      - File RangeSlider.qml 0 Remove
      - File Slider.qml 0 Remove
      - File SliderCreateTreatment.qml 0 Remove
    - Folder globals 0
      - File Variables.qml 0 Remove
    - Folder pages 0
      - Folder endtreatment/rinseback 0
        
        File EndTreatmentRinseback.qml 0 Remove
      - Folder pretreatment/create 0
        
        File PreTreatmentCreate.qml 0 Remove
      - Folder settings 0
        
        File SettingsExportLogs.qml 0 Remove
      - Folder treatment 0
        
        Folder adjustments 0
        
        File TreatmentAdjustmentPressuresLimits.qml 0 Remove
        
        Folder sections 0
        
        File TreatmentPressures.qml 0 Remove
        
        File TreatmentBloodPrime.qml 0 Remove
        
        File TreatmentHome.qml 4 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File TreatmentUltrafiltrationItem.qml 0 Remove
  - Folder model/hd 0
    - Folder adjustment 0
      - Folder pretreatment 0
        
        File MPreTreatmentAdjustRequests.h 0 Remove
      - Folder treatment 0
        
        File MTreatmentAdjustRequests.h 0 Remove
    - Folder alarm 0
      - File MAlarmMapping.cpp 0 Remove
  - Folder storage 0
    - File Settings.cpp 0 Remove
  - Folder view 0
    - Folder hd 0
      - Folder adjustment/treatment 0
        
        File VTreatmentAdjustmentPressuresLimits.cpp 0 Remove
        
        File VTreatmentAdjustmentPressuresLimits.h 0 Remove
      - Folder data 0
        
        File VTreatmentRanges.cpp 0 Remove
        
        File VTreatmentRanges.h 0 Remove
    - Folder settings 0
      - File VSettings.cpp 0 Remove
    - File VTreatmentCreate.cpp 0 Remove
    - File VTreatmentCreate.h 0 Remove
  - File main.h 0 Remove
- File cppcheck.err 0 Remove
- File denali.pro.user 0 Remove
- File en_US.udic 0 Remove
- File imake.sh 0 Remove
ui.config 0
- Folder Configurations 0
  - File DataList.conf 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	1h 3m	2	removed spaces.
Sean Nash	Reviewer - Complete	7m	2	RESOLVED in CODE WALKTHROUGH.
Michael Garthwaite	Reviewer - 96% reviewed	6m
jishii (deleted user)	Reviewer - Complete	47m
Tiffany Mejia	Reviewer - Complete	27m
Total		2h 31m	4

Linked issues
- DEN-13962

#permalink

Objectives

commit : ffc5c436 - DEN-13962: UI: Update pressure limits to match treatment params and UI screen

Fixed the issue with the sliders not updating the ranges and the pressure adjustment was not able to be adjusted.

commit : e8df7fe7 - DEN-13962: UI: Update pressure limits to match treatment params and UI screen

removed the QML duplicate definitions of arterial/venous
added monitoring values and used them in monitoring components of arterial/venous.

commit : 5e03d3f2 - DEN-13962: UI: Update pressure limits to match treatment params and UI screen

Completely restructure the vTreatmentCreate class and removed all the constant ranges properties from that to the VTreatmentRanges.
Now reading all the constant ranges values from the DataList.conf from the ui.config repository.
Used the RANGESET property type for the ranges in the VTreatmentRanges class to have by default properties for min,max, res(olution),def(ault) properties.
Added an ability to slider to hide the handler when needed (Pre-Treatment)
Hide the Slider handler when slider switch is off
Added various PROPERTYs, like IDBASED, RAGESET, VALUESET
Modified the MPreTreatmentAdjustRequest, duration parameter to treatmentDuration for clarifying.
Modified the Settings class to able to parse a comment on the Group line.
Updated the ConfirmTreatmentTable to hold the required labels and added translate function for them. removed the call for get names for performance, since those never change.
Made the SettingsData connection, standard in the VSettings class.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-13962-1

UI-DEN-13962_UI BN S82

UI-DEN-13962-1 4

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-13962_UI BN S82

UI-DEN-13962-1 4

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time