1. VV-DEN-1434

VV-DEN-1434-1

Tools
closed on 25 Jun 20
Author
Moderator
Reviewers

VV-DEN-1434_UI Treatment

Activity

VV-DEN-1434-1 23

Keyboard shortcuts  
    • Summarize the review outcomes (optional)
    Preview wiki syntax help
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Sarina Cheung
    		Author & Moderator 20m 7 Fixed. Removed *.pyc from repo.
    Sean Nash
    Reviewer completed
    		Reviewer - Complete 3m    
    pmontazemi  (deleted user)
    Reviewer completed
    		Reviewer - Complete 28m 6 RESOLVED.
    Behrouz NematiPour
    		Reviewer - 0% reviewed 1m    
    plucia  (deleted user)
    Reviewer completed
    		Reviewer - Complete 12m 10 RESOLVED
    Total   1h 6m 23  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    plucia  (deleted user)

    Looks good overall! I've added a few comments. Also to conform to PEP8, all f...

    Looks good overall! I've added a few comments. Also to conform to PEP8, all folders should be lowercase_with_underscores. The Dialin_API folder should be renamed to dialin_scripts since the Dialin API is a located in a separate repository

      plucia  (deleted user) marked as Resolved 12 Jun 20

    plucia  (deleted user)

    RESOLVED

    RESOLVED

    Sarina Cheung

    Fixed, rename directories to lowercase.

    Fixed, rename directories to lowercase.

    plucia  (deleted user)

    Thanks Sarina! RESOLVED

    Thanks Sarina! RESOLVED

    /Dialin_Scripts/__pycache__/can_xmit_test.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/__pycache__/dg_uf_test.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/__pycache__/dg_valves_test.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/__pycache__/hd_buttons_test.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/__pycache__/test_demo.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/__pycache__/test_imports.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/__pycache__/uf_test.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/assets/style.css Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/can_xmit_test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/dg_uf_test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/dg_uf_test.py_bkup Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/dg_uf_test.py_bkup1 Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/dg_valves_test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/dg_valves_test1.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/fix_virtualenv.sh Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/hd_buttons_test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/hd_test_script.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/report.html Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/report_1lb_1kg.html Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/report_baseline.html Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/report_baseline_1.html Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/report_load_cell_A_add_1kg.html Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/report_load_cell_A_add_1kg_1.html Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/report_load_cell_B_add_1kg.html Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/report_load_cell_B_add_1kg_1.html Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/requirements.txt Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/setup_canbus.sh Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/setup_environment.sh Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/test_demo.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/test_imports.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/uf_test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /Dialin_Scripts/update_dialin.sh Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../scripts/bdd_hooks.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../scripts/names.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../scripts/names.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../steps/steps.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_adjust_Treatment_Duration/test.feature Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_adjust_Treatment_Duration/test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_case1/test.feature Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_case1/test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_case2/test.feature Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_case2/test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/suite_treatment_screen_features_py/suite.conf Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../scripts/bdd_hooks.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../scripts/names.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../scripts/names.pyc Deleted 6
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../searchImages/image.png Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../steps/steps.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Flows_display/test.feature Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Flows_display/test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Heparin_display/test.feature Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Heparin_display/test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Navigate_to_Treatment/test.feature Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Navigate_to_Treatment/test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Pressure_display/test.feature Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Pressure_display/test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Saline_Bolus_display/test.feature Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Saline_Bolus_display/test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Time_Remaining_display/test.feature Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Time_Remaining_display/test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Ultrafiltration_Volume_display/test.feature Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Ultrafiltration_Volume_display/test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Vitals_display/test.feature Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../tst_Vitals_display/test.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/suite_treatment_screen_py/suite.conf Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/.../scripts/names.py Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/suite_trending_screen_py/suite.conf Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/report.bat Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/squishreport.sh Deleted 1
    Open in IDE #permalink
    Repository vvtesting does not exist
    /SquishQt_UI_Testing/start_squishserver.bat Deleted 3
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/__pycache__/can_xmit_test.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/__pycache__/dg_uf_test.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/__pycache__/dg_valves_test.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/__pycache__/hd_buttons_test.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/__pycache__/test_demo.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/__pycache__/test_imports.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/__pycache__/uf_test.cpython-36-pytest-5.4.3.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/assets/style.css Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/can_xmit_test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/dg_uf_test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/dg_uf_test.py_bkup Added 3
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/dg_uf_test.py_bkup1 Added 3
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/dg_valves_test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/dg_valves_test1.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/fix_virtualenv.sh Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/hd_buttons_test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/hd_test_script.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/report.html Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/report_1lb_1kg.html Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/report_baseline.html Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/report_baseline_1.html Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/report_load_cell_A_add_1kg.html Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/report_load_cell_A_add_1kg_1.html Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/report_load_cell_B_add_1kg.html Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/report_load_cell_B_add_1kg_1.html Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/requirements.txt Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/setup_canbus.sh Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/setup_environment.sh Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/test_demo.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/test_imports.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/uf_test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /dialin_scripts/update_dialin.sh Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../scripts/bdd_hooks.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../scripts/names.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../scripts/names.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../steps/steps.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_adjust_Treatment_Duration/test.feature Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_adjust_Treatment_Duration/test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_case1/test.feature Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_case1/test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_case2/test.feature Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_case2/test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/suite_treatment_screen_features_py/suite.conf Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../scripts/bdd_hooks.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../scripts/names.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../scripts/names.pyc Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../searchImages/image.png Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../steps/steps.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Flows_display/test.feature Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Flows_display/test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Heparin_display/test.feature Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Heparin_display/test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Navigate_to_Treatment/test.feature Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Navigate_to_Treatment/test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Pressure_display/test.feature Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Pressure_display/test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Saline_Bolus_display/test.feature Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Saline_Bolus_display/test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Time_Remaining_display/test.feature Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Time_Remaining_display/test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Ultrafiltration_Volume_display/test.feature Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Ultrafiltration_Volume_display/test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Vitals_display/test.feature Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../tst_Vitals_display/test.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/suite_treatment_screen_py/suite.conf Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/.../scripts/names.py Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/suite_trending_screen_py/suite.conf Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/report.bat Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/report.sh Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/squishreport.sh Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/start_squishserver.bat Deleted
    Open in IDE #permalink
    Repository vvtesting does not exist
    /squishqt_scripts/start_squishserver.sh Added
    Open in IDE #permalink
    Repository vvtesting does not exist
    /.gitignore Changed 3
    Open in IDE #permalink
    Repository vvtesting does not exist

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time