DD-LEAH-220

DD-LEAH-220

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 18 Sep 2024
4:45 pm

Vinayakam Mani

4:05 pm

Dara Navaei and Sean Nash

Tuesday 17 Sep 2024
3:32 pm

Vinayakam Mani

Done.

Done.

3:32 pm

Vinayakam Mani

Done.

Done.

3:32 pm

Vinayakam Mani

Done.

Done.

3:31 pm

Vinayakam Mani

Done.

Done.

3:31 pm

Vinayakam Mani

Done.

Done.

3:31 pm

Vinayakam Mani

Done.

Done.

3:31 pm

Vinayakam Mani

Done.

Done.

3:31 pm

Vinayakam Mani

Done.

Done.

3:31 pm

Vinayakam Mani

Done.

Done.

3:30 pm

Vinayakam Mani

Done.

Done.

3:30 pm

Vinayakam Mani

Done.

Done.

3:30 pm

Vinayakam Mani

Done.

Done.

3:30 pm

Vinayakam Mani

Done.

Done.

3:30 pm

Vinayakam Mani

Done.

Done.

3:29 pm

Vinayakam Mani

Done.

Done.

3:25 pm

Vinayakam Mani

As discussed, will be evaluated once we get more details on the sensor configuration/controls.

As discussed, will be evaluated once we get more details on the sensor configuration/controls.

3:24 pm

Vinayakam Mani

Done.

Done.

Monday 16 Sep 2024
5:33 pm

Vinayakam Mani

Yes, Currently HDD listing this pressure sensor. Once HDD cleanup is done, we may remove/comment the source as required.

Yes, Currently HDD listing this pressure sensor. Once HDD cleanup is done, we may remove/comment the source as required.

5:31 pm

Vinayakam Mani

This is just added for the sake of code review creation, the actual changes were already merged in to staging.

This is just added for the sake of code review creation, the actual changes were already merged in to staging.

5:14 pm

Sean Nash

Who will be calling this function? Is there any chance this function can be called more than once in a single task iteration? Is it possible to request a write at one address and then immediately r...

Who will be calling this function? Is there any chance this function can be called more than once in a single task iteration? Is it possible to request a write at one address and then immediately request another write at another address? If so, I think the second write request will overwrite the first - you would need to add a write request queue that the write state machine could handle one job at a time.

5:10 pm

Sean Nash

Should each conductivity sensor have its own state? It doesn't look like the state can be shared by all sensors.

Should each conductivity sensor have its own state? It doesn't look like the state can be shared by all sensors.

5:02 pm

Sean Nash

Dara's build script should be updating these for us.

Dara's build script should be updating these for us.

5:01 pm

Sean Nash

Where are the messages for conductivity and pressure overrides? Are you looking for Michael to add those?

Where are the messages for conductivity and pressure overrides? Are you looking for Michael to add those?

4:58 pm

Sean Nash

Isn't bicarb bag de-scoped?

Isn't bicarb bag de-scoped?

4:54 pm

Sean Nash

Replace TD with DD.

Replace TD with DD.

4:53 pm

Sean Nash

Remove "ed" from "filtered".

Remove "ed" from "filtered".

4:51 pm

Sean Nash

Is there only 1 pressure sensor? Initialization looks wrong. Should the whole structure get initialized - maybe in init function?

Is there only 1 pressure sensor? Initialization looks wrong. Should the whole structure get initialized - maybe in init function?

4:45 pm

Sean Nash

Add a blank line between declarations and code.

Add a blank line between declarations and code.