DG-DEN-16093

DG-DEN-16093

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 8
Total Commits: 3,340
Last Commit: 23 Mar
Commits this week: 8

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Friday 01 Sep 2023
4:58 pm

Vinayakam Mani

Tuesday 29 Aug 2023
9:03 am

jtaylor  (deleted user)

Monday 28 Aug 2023
2:25 pm

wbracken  (deleted user) and Sean Nash

10:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 25 Aug 2023
3:03 pm

Vinayakam Mani

Done.

Done.

3:03 pm

Vinayakam Mani

Done.

Done.

2:27 pm

Sean Nash

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is redu...

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is reduced, this level should also be reduced accordingly."

2:24 pm

Sean Nash

100% now.

100% now.

Tuesday 22 Aug 2023
11:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:07 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

Add a blank line between declarations and code.

Add a blank line between declarations and code.

9:57 am

Sean Nash

#includes are sorted. Put OperationModes.h in its proper place.

#includes are sorted. Put OperationModes.h in its proper place.

Monday 21 Aug 2023
6:05 pm

Vinayakam Mani

required changes are done.

required changes are done.

1:55 pm

Sean Nash

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting...

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting). Function would also create and send the cmd response message and return TRUE/FALSE which would set local result here for the ack response message below.
We should reject cmd if pumps are busy/on and/or if current DG mode is fill or fault mode.

Thursday 17 Aug 2023
2:04 pm

Dara Navaei

DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
DG-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment