DG-DEN-4169

DG-DEN-4169

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 4,108
Last Commit: 19 Nov 25
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 03 Aug 2020
1:48 pm

Dara Navaei

1:48 pm

Dara Navaei , pmontazemi  (deleted user) and Sean Nash

9:06 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:05 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:05 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:04 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 31 Jul 2020
1:34 pm

qnguyen  (deleted user)

Done

Done

1:33 pm

qnguyen  (deleted user)

Done

Done

1:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:10 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH

RESOLVED in CODE WALKTRHOUGH

1:10 pm

Dara Navaei

RESOLVED in CODE WALKTRHOUGH

RESOLVED in CODE WALKTRHOUGH

1:06 pm

pmontazemi  (deleted user)

Align with "a" character

Align with "a" character

1:02 pm

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:20 am

qnguyen  (deleted user)

The structure allows grouping of temperature sensor properties in one place rather than spanning across multiple 2D arrays.

The structure allows grouping of temperature sensor properties in one place rather than spanning across multiple 2D arrays.

11:20 am

qnguyen  (deleted user)

The structure allows grouping of temperature sensor properties in one place rather than spanning across multiple 2D arrays.

The structure allows grouping of temperature sensor properties in one place rather than spanning across multiple 2D arrays.

11:01 am

qnguyen  (deleted user)

The windowed count should be used for FPGA error. For this one, the time is 40 ms (4 read and 10 ms per read) of unchanged read count.

The windowed count should be used for FPGA error. For this one, the time is 40 ms (4 read and 10 ms per read) of unchanged read count.

10:58 am

qnguyen  (deleted user)

Done.

Done.

10:57 am

qnguyen  (deleted user)

Done. Without the sense of time, it is easier to make mistakes. The intention here is 5 seconds rather than 50 seconds.

Done. Without the sense of time, it is easier to make mistakes. The intention here is 5 seconds rather than 50 seconds.

10:57 am

qnguyen  (deleted user)

Fixed, the intention is 5 seconds for both rather than 50 seconds. The SYS team will define the threshold later on.

Fixed, the intention is 5 seconds for both rather than 50 seconds. The SYS team will define the threshold later on.

10:46 am

qnguyen  (deleted user)

This is not squaring through, it is power of 2.

This is not squaring through, it is power of 2.

10:40 am

Sean Nash

Update function header description to remove this functionality.

Update function header description to remove this functionality.

10:35 am

Sean Nash

Do we want to have some kind of persistence for this?

Do we want to have some kind of persistence for this?

10:34 am

Sean Nash

Recommend using time windowed count here to narrow the time. Currently, it is enforcing a maximum # of instances over entire time system is on.

Recommend using time windowed count here to narrow the time. Currently, it is enforcing a maximum # of instances over entire time system is on.

10:23 am

Sean Nash

I generally prefer not using pow() for squaring. Simpler and more efficient to just multiply by itself instead.

I generally prefer not using pow() for squaring. Simpler and more efficient to just multiply by itself instead.

10:22 am

Sean Nash

Clearing should probably be a longer persistence than triggering threshold. Currently both are 50 sec. I think that's too long for triggering. Maybe ok for clearing.

Clearing should probably be a longer persistence than triggering threshold. Currently both are 50 sec. I think that's too long for triggering. Maybe ok for clearing.

10:20 am

Sean Nash

Try to give a sense of time for this. I think Modes are calling the check function so that's on the General Task so that's every 50ms x 1000 = 50 seconds. I usually define these types of things as ...

Try to give a sense of time for this. I think Modes are calling the check function so that's on the General Task so that's every 50ms x 1000 = 50 seconds. I usually define these types of things as a # of ms divided by the appropriate task interval (in ms).