DG-DEN-4322

DG-DEN-4322

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 4,108
Last Commit: 19 Nov 25
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Friday 28 Aug 2020
5:19 pm

qnguyen  (deleted user)

4:43 pm

Sean Nash and pmontazemi  (deleted user)

4:33 pm

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:32 pm

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Wednesday 26 Aug 2020
11:45 am

qnguyen  (deleted user)

Done.

Done.

11:44 am

qnguyen  (deleted user)

Done.

Done.

10:45 am

pmontazemi  (deleted user)

Insert extra line before return.

Insert extra line before return.

10:40 am

pmontazemi  (deleted user)

{ at next line based on C Coding Standard

{ at next line based on C Coding Standard

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Dara Navaei

This has been fixed in Sprint26.

This has been fixed in Sprint26.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:31 am

qnguyen  (deleted user)

Fixed.

Fixed.

12:28 am

qnguyen  (deleted user)

Fixed. Module Pressure should use these definitions rather than defining its own.

Fixed. Module Pressure should use these definitions rather than defining its own.

12:23 am

qnguyen  (deleted user)

Done.

Done.

12:21 am

qnguyen  (deleted user)

Done.

Done.

12:15 am

qnguyen  (deleted user)

Yes, it should be one blank line at the end. I do see in code composer there is one blank line at the end of these files.

Yes, it should be one blank line at the end. I do see in code composer there is one blank line at the end of these files.

12:11 am

qnguyen  (deleted user)

Dara Navaei Can you please respond to this change?

Dara Navaei Can you please respond to this change?

Tuesday 25 Aug 2020
11:43 pm

Sean Nash

The code in this header file should be added to the SystemCommMessages group for now. This header file will be going away at some point and its definitions distributed to other header files.

The code in this header file should be added to the SystemCommMessages group for now. This header file will be going away at some point and its definitions distributed to other header files.

11:34 pm

Sean Nash

I think we decided that all .c and .h files would end with one blank line. Looks like all DG source files now have no blank lines at end.

I think we decided that all .c and .h files would end with one blank line. Looks like all DG source files now have no blank lines at end.

11:32 pm

Sean Nash

Were these not used anywhere? Even if not, seems like it may be in future (or should already be, but other drivers are defining their own). I recommend keeping these.

Were these not used anywhere? Even if not, seems like it may be in future (or should already be, but other drivers are defining their own). I recommend keeping these.

11:18 pm

Sean Nash

I've been putting 2 blank lines above and below this comment to emphasize we're moving to Dialin support functions.

I've been putting 2 blank lines above and below this comment to emphasize we're moving to Dialin support functions.

11:12 pm

Sean Nash

There are more public functions below this line. I generally prefer public functions on top and private function below, but this is not required and would conflict with other considerations like ke...

There are more public functions below this line. I generally prefer public functions on top and private function below, but this is not required and would conflict with other considerations like keeping Dialin functions (which are public) at very bottom of module. Recommend removing this comment.

11:04 pm

Sean Nash

These belong in the 0x8... section above (for Dialin/HD messages.

These belong in the 0x8... section above (for Dialin/HD messages.

Friday 21 Aug 2020
10:34 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.