HD-DEN-15994

HD-DEN-15994

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 17 Aug 2023
10:59 am

jtaylor  (deleted user)

10:24 am

wbracken  (deleted user) and Sean Nash

8:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:22 am

jtaylor  (deleted user)

As you pointed out earlier, rinsebackTimerCtr is set to zero in states where BP is running, so the if condition would only be TRUE (rinsebackTimerCtr > 0) if BP is not running.

As you pointed out earlier, rinsebackTimerCtr is set to zero in states where BP is running, so the if condition would only be TRUE (rinsebackTimerCtr > 0) if BP is not running.

Wednesday 16 Aug 2023
4:42 pm

Sean Nash

You removed the if (great), but I don't see that you replaced it with BP stopped check. I don't think we want a countdown if BP is running (blood not sitting).

You removed the if (great), but I don't see that you replaced it with BP stopped check. I don't think we want a countdown if BP is running (blood not sitting).

3:34 pm

Darren Cox

3:28 pm

jtaylor  (deleted user)

Done.

Done.

3:14 pm

Sean Nash

This if will prevent countdown timer from being displayed unless we are paused or stopped after rinseback. I think countdown timer is definitely needed for rinseback init state (pump is stopped and...

This if will prevent countdown timer from being displayed unless we are paused or stopped after rinseback. I think countdown timer is definitely needed for rinseback init state (pump is stopped and rinseback hasn't even started). May be needed for new reconnect patient state as well.
I think it might be simpler/clearer to replace this if with a check for whether BP is running or not. If BP is stopped, we proceed to next if. If BP is running, keep timeouts at zero.

3:03 pm

Sean Nash

Friday 04 Aug 2023
3:49 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:04 pm

jtaylor  (deleted user)

Done.

Done.

12:46 pm

Sean Nash

This if condition appears to be redundant. rinsebackTimerCtr is set to zero in states where BP is running, so previous if condition would only be TRUE (rinsebackTimerCtr > 0) if BP not running.

This if condition appears to be redundant. rinsebackTimerCtr is set to zero in states where BP is running, so previous if condition would only be TRUE (rinsebackTimerCtr > 0) if BP not running.

10:20 am

jtaylor  (deleted user)

HD-DEN-15994_Rinseback 5 Minute Timer Does Not Count Down
HD-DEN-15994_Rinseback 5 Minute Timer Does Not Count Down
Wednesday 02 Aug 2023
6:04 pm

Dara Navaei

HD-DEN-15994_Rinseback 5 Minute Timer Does Not Count Down
HD-DEN-15994_Rinseback 5 Minute Timer Does Not Count Down