HD-DEN-16563

HD-DEN-16563

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Tuesday 27 Feb 2024
12:14 pm

Vinayakam Mani

11:39 am

Vinayakam Mani

10:35 am

Michael Garthwaite

Monday 26 Feb 2024
10:39 am

Michael Garthwaite

Thursday 08 Feb 2024
9:45 am

Sean Nash

Tuesday 06 Feb 2024
3:55 pm

Vinayakam Mani

3:55 pm

Vinayakam Mani

3:36 pm

Dara Navaei

HD-DEN-16563_2 Venous Pressure Readings Were Below 20Mmhg For 1.5 Minutes Before Low Venous
HD-DEN-16563_2 Venous Pressure Readings Were Below 20Mmhg For 1.5 Minutes Before Low Venous
9:31 am

Sean Nash

9:23 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:23 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:23 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:22 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:12 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 05 Feb 2024
3:55 pm

Vinayakam Mani

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, fl...

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, flag is set back to TRUE and Exempt counter being incremented.

3:54 pm

Vinayakam Mani

Done. Removed the parameter in function.

Done. Removed the parameter in function.

3:53 pm

Vinayakam Mani

Done.

Done.

3:23 pm

Vinayakam Mani

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, fl...

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, flag is set back to TRUE and Exempt counter being incremented.

3:22 pm

Vinayakam Mani

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, fl...

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, flag is set back to TRUE and Exempt counter being incremented.

1:25 pm

Sean Nash

I think this function should set the old reset flag to FALSE here. Function doesn't need a parameter because it is only called when valve closes which should always set reset flag to FALSE.

I think this function should set the old reset flag to FALSE here. Function doesn't need a parameter because it is only called when valve closes which should always set reset flag to FALSE.

1:24 pm

Sean Nash

I think reset flag should not be set here. Should be set by new function when valve is closed I think.

I think reset flag should not be set here. Should be set by new function when valve is closed I think.

1:23 pm

Sean Nash

Should also set new flag to FALSE here I think.

Should also set new flag to FALSE here I think.

1:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:20 pm

Sean Nash

Shouldn't this be set to TRUE?

Shouldn't this be set to TRUE?

1:19 pm

Sean Nash

Add space between if and (. Add to comment that low venous pressure must be exempt to increment counter.

Add space between if and (. Add to comment that low venous pressure must be exempt to increment counter.

Friday 02 Feb 2024
4:52 pm

Vinayakam Mani

Done

Done

10:09 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:07 am

Sean Nash

This effectively changes exemption start to time of valve open instead of close. We don't want to do that.

This effectively changes exemption start to time of valve open instead of close. We don't want to do that.

Thursday 25 Jan 2024
10:17 am

Sean Nash

MIN_TIME_BETWEEN_AIR_TRAP_FILL_LOW_PRESSURE_ALARM_EXEMPTIONS_MS (as a suggestion). Also be more descriptive in comments.

MIN_TIME_BETWEEN_AIR_TRAP_FILL_LOW_PRESSURE_ALARM_EXEMPTIONS_MS (as a suggestion).
Also be more descriptive in comments.

Tuesday 16 Jan 2024
2:00 pm

Dara Navaei

HD-DEN-16563_Venous Pressure Readings Were Below 20Mmhg For 1.5 Minutes Before Low Venous
HD-DEN-16563_Venous Pressure Readings Were Below 20Mmhg For 1.5 Minutes Before Low Venous