LEAHI-DD-FIRMWARE-LDT-4539

LEAHI-DD-FIRMWARE-LDT-4539

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 1
Total Commits: 3,393
Last Commit: 18 Jun
Commits this week: 1

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 18 Jun
1:53 pm

Vinayakam Mani

Looks On event handled later. One event should be fine for On condtion.

Looks On event handled later. One event should be fine for On condtion.

1:51 pm

Vinayakam Mani

Space after 0

Space after 0

1:48 pm

Vinayakam Mani

prevDryBicartState

prevDryBicartState

1:46 pm

Vinayakam Mani

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

1:31 pm

Vinayakam Mani

prevBalChamberState?

prevBalChamberState?

10:21 am

Vendor - TEL - Arpita Srivastava

Should we also send an event when we start the heater?

Should we also send an event when we start the heater?

10:11 am

Vendor - TEL - Arpita Srivastava

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition c...

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

Monday 15 Jun
10:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4539_Provide event on Service state change
LEAHI-DD-FIRMWARE-LDT-4539_Provide event on Service state change
Monday 08 Jun
6:19 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4539_Provide event on Service state change
LEAHI-DD-FIRMWARE-LDT-4539_Provide event on Service state change