LEAHI-TD-FIRMWARE-LDT-4027

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
align the comment part

align the comment part

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now. For now, comment out this line with a TODO to restore when patient connectio...

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now.
For now, comment out this line with a TODO to restore when patient connection state is implemented and add a temporary line of code to request treatment mode here.

Bamboo Commit: Updated MAlarmMapping.cpp

    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Merged release/p1b/staging and resolved the conflicts

    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated MAlarmMapping.cpp

    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Merged release/DENBUG-335-air-trap-fill-design-improvement-P1B-Staging

You only addressed the first part of my comment above.

You only addressed the first part of my comment above.

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

DENBUG-335: Air Trap Fill Design Improvements: Updated the institutional record to receive and display the end treatment blood flow rate in mL/min

    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested Remove from output: recircMediumAlarmGiven and recircResumeRequested

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested
Remove from output: recircMediumAlarmGiven and recircResumeRequested

Output should be none.

Output should be none.

Just curious, at what condition we leave this state? It looks like, once we enter this state, we stay.

Just curious, at what condition we leave this state?
It looks like, once we enter this state, we stay.

Bamboo Commit: Updated MAlarmMapping.cpp

    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Please add Alarm ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

Please add Alarm
ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

Please add currentPreTreatmentState to inputs.

Please add currentPreTreatmentState to inputs.

currentPreTxRecircState looks like an input.

currentPreTxRecircState looks like an input.

Bamboo Commit: Updated MAlarmMapping.cpp

    • -15
    • +21
    /sources/model/hd/alarm/MAlarmMapping.cpp
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Merged DENBUG-335

Put recirc state after Rx state (both here in switch statement and also in enumeration).

Put recirc state after Rx state (both here in switch statement and also in enumeration).

Put in alphabetical order (before Timers.h).

Put in alphabetical order (before Timers.h).

Dialysate rate should be set to the Qd user setting (from Tx params).

Dialysate rate should be set to the Qd user setting (from Tx params).

Add /// doxygen comment for this enumeration and ///< doxygen comments to right of each enum in the list.

Add /// doxygen comment for this enumeration and ///< doxygen comments to right of each enum in the list.