LEAHI-TD-FIRMWARE-LDT-4040 LEAHI-TD-FIRMWARE-LDT-4040

Accordion

Stats

Commits this week: 0

Total Commits:	3,393
Last Commit:	18 Jun
Commits this week:	0

Commit Activity

Today

3 hrs ago

Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-4040-1
resumed reviewing

Thursday 23 Jul

11:48 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

11:48 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

recircPublishTimerCtr is an output

recircPublishTimerCtr is an output

11:46 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

11:44 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

11:40 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Initialization missing for the following variables in the init function. startRecircRequested reconnectRequested backToTreatmentRequested resumeRecircRequested

Initialization missing for the following variables in the init function.

startRecircRequested
reconnectRequested
backToTreatmentRequested
resumeRecircRequested

11:32 am

Vendor - TEL - Praneeth Bunne

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
replied to Vendor - TEL - Arpita Srivastava

All signal flags are initialized in resetSignalFlags() which we are calling below

All signal flags are initialized in resetSignalFlags() which we are calling below

11:23 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

please update the alarm id reservation sheet.

please update the alarm id reservation sheet.

11:20 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out? Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out?
Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

11:15 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line : one variable per line will be easy to read.

break this line : one variable per line will be easy to read.

11:13 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

StateTxRecirc should be above StateTxRinseback

StateTxRecirc should be above StateTxRinseback

11:07 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

11:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

11:05 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

11:04 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add rinsebackPublishTimerCtr to outputs

Add rinsebackPublishTimerCtr to outputs

10:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

add rinsebackPublishTimerCtr to outputs

add rinsebackPublishTimerCtr to outputs

10:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

10:55 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

add rinsebackPublishTimerCtr to outputs

add rinsebackPublishTimerCtr to outputs

10:54 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this line

break this line

10:52 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break this into two or more lines

break this into two or more lines

10:52 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break the comment in two lines

break the comment in two lines

10:50 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Do we need the alarm?

Do we need the alarm?

10:49 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add fluidType to inputs

Add fluidType to inputs

10:49 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Update spelling of cummulativeRinsebackVolume_mL

Update spelling of cummulativeRinsebackVolume_mL

10:48 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break into two lines

break into two lines

10:46 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break into two lines

break into two lines

10:46 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

break into two lines

break into two lines

10:46 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Add isRecircAllowed to inputs

Add isRecircAllowed to inputs

10:44 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Remove Alarm

Remove Alarm

10:44 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-4040-1
commented on review

Remove bloodSittingTimerCtr

Remove bloodSittingTimerCtr

Atlassian Fisheye analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-07-31 14:40 -0700