LEAHI-TD-FIRMWARE-LDT-4329

LEAHI-TD-FIRMWARE-LDT-4329

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,393
Last Commit: 18 Jun
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 18 Jun
5:04 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Wednesday 17 Jun
12:04 pm

Vendor - TEL - Vijay Pamula

Friday 12 Jun
2:01 pm

Vendor - TEL - Arpita Srivastava and Sean Nash

Thursday 11 Jun
11:11 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
10:59 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
10:33 am

Dara Navaei

Merged release/p1b/staging and resolved the conflicts

Options
    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
9:28 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
9:15 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +1
    /sources/gui/qml/pages/settings/SettingsInstitutionalRecord.qml
    • -1
    • +1
    /sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.cpp
    • -1
    • +1
    /sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.h
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -1
    • +1
    /sources/view/settings/VAdjustmentInstitutionalRecord.cpp
    • -1
    • +1
    /sources/view/settings/VAdjustmentInstitutionalRecord.h
9:08 am

Dara Navaei

Merged release/DENBUG-335-air-trap-fill-design-improvement-P1B-Staging

Options
Tuesday 09 Jun
11:09 am

Dara Navaei

DENBUG-335: Air Trap Fill Design Improvements: Updated the institutional record to receive and display the end treatment blood flow rate in mL/min

Options
    • -12
    • +12
    /AlarmMapping.csv
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +1
    /sources/gui/qml/pages/settings/SettingsInstitutionalRecord.qml
    • -0
    • +4
    /sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.cpp
    • -0
    • +3
    /sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.h
    • -2
    • +2
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -0
    • +2
    /sources/view/settings/VAdjustmentInstitutionalRecord.cpp
    • -0
    • +3
    /sources/view/settings/VAdjustmentInstitutionalRecord.h
10:19 am

Vendor - TEL - Arpita Srivastava

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input. Then you will not need all thes...

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input.
Then you will not need all these repetitive functions:
isSystolicBpLowAlarmLimitValid
isSystolicBpHighAlarmLimitValid
isHeartRateLowAlarmLimitValid
isHeartRateHighAlarmLimitValid

Similarly, you can create another function with input as TREATMENT_PARAM_T minValue and TREATMENT_PARAM_T maxValue for isVitalsMeasurementIntervalValid()

10:05 am

Vendor - TEL - Arpita Srivastava

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

Monday 08 Jun
3:32 pm

Sean Nash

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

3:27 pm

Sean Nash

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

3:08 pm

Sean Nash

These should be moved down to an "else" in the if statement below (payload length check).

These should be moved down to an "else" in the if statement below (payload length check).

3:04 pm

Sean Nash

It doesn't look like these memsets are necessary. Consider removing them.

It doesn't look like these memsets are necessary. Consider removing them.

3:03 pm

Sean Nash

Remove blank line.

Remove blank line.

3:02 pm

Sean Nash

Can you move this down with the other vitals functions?

Can you move this down with the other vitals functions?

11:20 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
Friday 05 Jun
3:36 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
3:24 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Thursday 04 Jun
6:13 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -15
    • +21
    /sources/model/hd/alarm/MAlarmMapping.cpp
6:07 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -1
    • +1
    /sources/canbus/MessageInterpreter.cpp
    • -1
    • +1
    /sources/gui/qml/pages/settings/SettingsInstitutionalRecord.qml
    • -1
    • +1
    /sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.cpp
    • -1
    • +1
    /sources/model/hd/adjustment/settings/MAdjustHDInstitutionalRecordResponse.h
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
    • -1
    • +1
    /sources/view/settings/VAdjustmentInstitutionalRecord.cpp
    • -1
    • +1
    /sources/view/settings/VAdjustmentInstitutionalRecord.h
5:51 pm

Dara Navaei

Merged DENBUG-335

Options
Monday 01 Jun
10:43 am

Dara Navaei

Merge branch 'staging' into DENBUG-335-air-trap-fill-design-improvement

Options
Friday 29 May
9:27 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
8:51 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
8:39 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp
Thursday 28 May
5:50 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -14
    • +20
    /sources/model/hd/alarm/MAlarmMapping.cpp
5:38 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp