RO-LEAH-250

RO-LEAH-250

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 20 Nov 2024
4:59 pm

Sean Nash

4:26 pm

Michael Garthwaite and Vinayakam Mani

1:32 pm

Sean Nash

Fixed.

Fixed.

1:29 pm

Sean Nash

Fixed.

Fixed.

10:50 am

Vinayakam Mani

In RODefs.h -> please change RO_POST_STATES enum members to RO_POST_STATE_START.. etc., ( instead of POST_STATE_START). seeing conflict with TDDefs.h post states.

In RODefs.h -> please change RO_POST_STATES enum members to RO_POST_STATE_START.. etc., ( instead of POST_STATE_START). seeing conflict with TDDefs.h post states.

10:41 am

Vinayakam Mani

Looks param still mentioning valves.

Looks param still mentioning valves.

10:39 am

Vinayakam Mani

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Tuesday 19 Nov 2024
5:15 pm

Sean Nash

Added.

Added.

5:15 pm

Sean Nash

Removed check. Caller checks prior to calling this function.

Removed check. Caller checks prior to calling this function.

5:12 pm

Sean Nash

Fixed.

Fixed.

5:01 pm

Sean Nash

Fixed.

Fixed.

4:56 pm

Sean Nash

I haven't done this unit yet - just brought it over from DD. I'll comment out for now.

I haven't done this unit yet - just brought it over from DD. I'll comment out for now.

4:55 pm

Sean Nash

Fixed.

Fixed.

4:54 pm

Sean Nash

Fixed.

Fixed.

4:53 pm

Sean Nash

I am calling both pumps a "boost" pump as a type of pump that both are. And then we have the RO pump is one boost pump and the optional booster pump is another boost pump. A little confusing I real...

I am calling both pumps a "boost" pump as a type of pump that both are. And then we have the RO pump is one boost pump and the optional booster pump is another boost pump. A little confusing I realize.

4:51 pm

Sean Nash

True. For now I am assuming both pumps will have the same max and so I have a common #define.

True. For now I am assuming both pumps will have the same max and so I have a common #define.

4:50 pm

Sean Nash

Fixed.

Fixed.

4:42 pm

Sean Nash

It is more general than that. We will be reading all feedback registers that FPGA provides. In this case, a read-back of the PWM and the measured speed for both the RO and the optional booster pump.

It is more general than that. We will be reading all feedback registers that FPGA provides. In this case, a read-back of the PWM and the measured speed for both the RO and the optional booster pump.

4:40 pm

Sean Nash

Fixed.

Fixed.

4:39 pm

Sean Nash

Fixed.

Fixed.

3:47 pm

Vinayakam Mani

priorRawLevel ( small p)

priorRawLevel ( small p)

3:41 pm

Vinayakam Mani

I guess, these needs to be defined for RO.

I guess, these needs to be defined for RO.

3:39 pm

Vinayakam Mani

RO cal records ( just change DD ->RO name for now, can be defined later)

RO cal records ( just change DD ->RO name for now, can be defined later)

3:36 pm

Vinayakam Mani

Can be deleted for now, or update RO alarms and comment it for later use. the commented code appears to be DD alarms.

Can be deleted for now, or update RO alarms and comment it for later use. the commented code appears to be DD alarms.

3:23 pm

Vinayakam Mani

RO valves

RO valves

3:03 pm

Vinayakam Mani

None?

None?

2:59 pm

Vinayakam Mani

This duty cycle is for actual RO pump. correct (MAX_RO_PUMP_PWM_DUTY_CYCLE)? if the Boost pump has same or different duty cycle, that can be called with another macro - MAX_BOOST_PUMP_PWM_DUTY_CYCLE.

This duty cycle is for actual RO pump. correct (MAX_RO_PUMP_PWM_DUTY_CYCLE)? if the Boost pump has same or different duty cycle, that can be called with another macro - MAX_BOOST_PUMP_PWM_DUTY_CYCLE.

2:54 pm

Vinayakam Mani

Do we want to say NUM_OF_RO_PUMPS instead of Boost pumps (since there is only one optional boost pump)?

Do we want to say NUM_OF_RO_PUMPS instead of Boost pumps (since there is only one optional boost pump)?

2:50 pm

Vinayakam Mani

Update outputs and params

Update outputs and params

2:42 pm

Vinayakam Mani

can we elaborate the function name as readBoostPumpSpeed or MeasuredSpeed ?

can we elaborate the function name as readBoostPumpSpeed or MeasuredSpeed ?