RO-LEAH-250

Fixed.

Fixed.

Fixed.

Fixed.

In RODefs.h -> please change RO_POST_STATES enum members to RO_POST_STATE_START.. etc., ( instead of POST_STATE_START). seeing conflict with TDDefs.h post states.

In RODefs.h -> please change RO_POST_STATES enum members to RO_POST_STATE_START.. etc., ( instead of POST_STATE_START). seeing conflict with TDDefs.h post states.

Looks param still mentioning valves.

Looks param still mentioning valves.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Added.

Added.

Removed check. Caller checks prior to calling this function.

Removed check. Caller checks prior to calling this function.

Fixed.

Fixed.

Fixed.

Fixed.

I haven't done this unit yet - just brought it over from DD. I'll comment out for now.

I haven't done this unit yet - just brought it over from DD. I'll comment out for now.

Fixed.

Fixed.

Fixed.

Fixed.

I am calling both pumps a "boost" pump as a type of pump that both are. And then we have the RO pump is one boost pump and the optional booster pump is another boost pump. A little confusing I real...

I am calling both pumps a "boost" pump as a type of pump that both are. And then we have the RO pump is one boost pump and the optional booster pump is another boost pump. A little confusing I realize.

True. For now I am assuming both pumps will have the same max and so I have a common #define.

True. For now I am assuming both pumps will have the same max and so I have a common #define.

Fixed.

Fixed.

It is more general than that. We will be reading all feedback registers that FPGA provides. In this case, a read-back of the PWM and the measured speed for both the RO and the optional booster pump.

It is more general than that. We will be reading all feedback registers that FPGA provides. In this case, a read-back of the PWM and the measured speed for both the RO and the optional booster pump.

Fixed.

Fixed.

Fixed.

Fixed.

priorRawLevel ( small p)

priorRawLevel ( small p)

I guess, these needs to be defined for RO.

I guess, these needs to be defined for RO.

RO cal records ( just change DD ->RO name for now, can be defined later)

RO cal records ( just change DD ->RO name for now, can be defined later)

Can be deleted for now, or update RO alarms and comment it for later use. the commented code appears to be DD alarms.

Can be deleted for now, or update RO alarms and comment it for later use. the commented code appears to be DD alarms.

RO valves

RO valves

None?

None?

This duty cycle is for actual RO pump. correct (MAX_RO_PUMP_PWM_DUTY_CYCLE)? if the Boost pump has same or different duty cycle, that can be called with another macro - MAX_BOOST_PUMP_PWM_DUTY_CYCLE.

This duty cycle is for actual RO pump. correct (MAX_RO_PUMP_PWM_DUTY_CYCLE)? if the Boost pump has same or different duty cycle, that can be called with another macro - MAX_BOOST_PUMP_PWM_DUTY_CYCLE.

Do we want to say NUM_OF_RO_PUMPS instead of Boost pumps (since there is only one optional boost pump)?

Do we want to say NUM_OF_RO_PUMPS instead of Boost pumps (since there is only one optional boost pump)?

Update outputs and params

Update outputs and params

can we elaborate the function name as readBoostPumpSpeed or MeasuredSpeed ?

can we elaborate the function name as readBoostPumpSpeed or MeasuredSpeed ?