RO-LEAH-273

RO-LEAH-273

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Tuesday 25 Mar
9:59 am

Michael Garthwaite

9:45 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:41 am

Sean Nash

If monitoring not yet implemented, that's ok - but at least add a TODO comment.

If monitoring not yet implemented, that's ok - but at least add a TODO comment.

9:28 am

Sean Nash

9:28 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:28 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:28 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:28 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

Monday 17 Mar
10:25 am

Vinayakam Mani

function header says return type as void.

function header says return type as void.

10:21 am

Vinayakam Mani

Please add parentheses for each condition for better readability.

Please add parentheses for each condition for better readability.

10:10 am

Vinayakam Mani

Looks this timer is being not used in low state timeout.

Looks this timer is being not used in low state timeout.

10:06 am

Vinayakam Mani

Are we using this flowrate here? it seems only level is being used for state transition.

Are we using this flowrate here? it seems only level is being used for state transition.

Thursday 13 Mar
2:34 pm

Michael Garthwaite

Will be implemented with RO closed loop control.

Will be implemented with RO closed loop control.

2:34 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:33 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:33 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:33 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

Tuesday 11 Mar
9:43 am

Sean Nash

Remove blank line.

Remove blank line.

9:42 am

Sean Nash

Low state should be checked first since it has a safety implication and the above condition could prevent it for timeout period. If low, we want to go to low state immediately (don't wait for timeo...

Low state should be checked first since it has a safety implication and the above condition could prevent it for timeout period.
If low, we want to go to low state immediately (don't wait for timeout).

9:39 am

Michael Garthwaite

Removed.

Removed.

9:38 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:38 am

Sean Nash

Swap level and medium to get logic right. We want level >= LEVEL_STATE_MEDIUM.

Swap level and medium to get logic right. We want level >= LEVEL_STATE_MEDIUM.

9:38 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:38 am

Michael Garthwaite

changed the variable to no longer be overridable. Removed override function.

changed the variable to no longer be overridable. Removed override function.

9:28 am

Sean Nash

Add blank line between break and default.

Add blank line between break and default.

9:24 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:23 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:23 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:22 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:20 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!