All Activity
Tuesday 03 Feb
5:32 pm

Sean Nash

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task...

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task, we could have situation where data is retrieved, then priority task updates fpga, and then counter is retrieved with wrong (incremented) counter.
If these two functions are being called from a driver that is executed in priority task, then we don't need to worry about this situation, but still ought to add a constraint/warning comment in function headers noting that these functions should only be called from priority task.

5:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:17 pm

Sean Nash

It is your comment, so please resolve it.

It is your comment, so please resolve it.

5:16 pm

Sean Nash

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

5:15 pm

Sean Nash

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function...

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function (assuming shared enum to index)?

5:14 pm

Sean Nash

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler wher...

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler where they are all in one place and could be indexed by enum with single command.

5:09 pm

Sean Nash

Do we need to say Value?

Do we need to say Value?

5:08 pm

Sean Nash

Add a blank line after public defs banner. Add a dox comment to the right. I believe they reserve space for 12 bytes, not 10. Not really for calibration - it's for s/n and versions.

Add a blank line after public defs banner.
Add a dox comment to the right.
I believe they reserve space for 12 bytes, not 10.
Not really for calibration - it's for s/n and versions.

5:06 pm

Sean Nash

Are these really going to be different types? I assumed they would all be floats.

Are these really going to be different types? I assumed they would all be floats.

5:05 pm

Sean Nash

Structures need a top level dox comment.

Structures need a top level dox comment.

5:05 pm

Sean Nash

enums need a top level dox comment.

enums need a top level dox comment.

5:02 pm

Vendor - TEL - Sameer Poyil

This function also not using u32ArrayOverride()

This function also not using u32ArrayOverride()

5:01 pm

Vendor - TEL - Sameer Poyil

is it possible to use the function u32ArrayOverride() here ?

is it possible to use the function u32ArrayOverride() here ?

4:58 pm

Nicholas Ramirez

mvoe to TD file and remove file

mvoe to TD file and remove file

4:56 pm

Sean Nash

I believe conductivity and temperature data will be F32s.

I believe conductivity and temperature data will be F32s.

4:52 pm

Sean Nash

Do we not need this anymore? I still see it in code all over the place and I don't think we're done w/ Teensy until Beta 1.9 units are obsolete.

Do we not need this anymore? I still see it in code all over the place and I don't think we're done w/ Teensy until Beta 1.9 units are obsolete.

4:48 pm

Sean Nash

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint. The description of their issue suggests that the 8 BC...

Are we sure about the reversing of states here? If we had this backward, I would think the Systems team would have had a much bigger complaint.
The description of their issue suggests that the 8 BC valves were correctly commanded to requested state except for the one they separately commanded earlier.
If we had this backward, I would think they would have said that all 8 valves did the wrong thing.

4:47 pm

Stephen Quong

Updated.

Updated.

4:43 pm

Zoltan Miskolci

- Matching alarm publish name with variable name

Options
    • -1
    • +1
    /leahi_dialin/dd/modules/alarms.py
4:41 pm

Sean Nash

I don't think mask or pos require initialization either.

I don't think mask or pos require initialization either.

4:40 pm

Nicholas Ramirez

ask caryn if we can remove text value

ask caryn if we can remove text value

4:38 pm

Nicholas Ramirez

remove componenet and create where its called

remove componenet and create where its called

4:38 pm

Sean Nash

I don't think valve needs to be initialized here. The for loop initializes it.

I don't think valve needs to be initialized here. The for loop initializes it.

4:38 pm

Stephen Quong

LDT-3328: Misc SW Enhancements - SW - 01 - BloodPrime-Rinseback - R&I - 05: DEV - Feature Implementation

- Updated EndTreatmentRinseback.qml to add comment.

Options
    • -1
    • +1
    /sources/gui/qml/pages/endtreatment/rinseback/EndTreatmentRinseback.qml
4:36 pm

Sean Nash

4:36 pm

Nicholas Ramirez

move model to outside when instantiated

move model to outside when instantiated

4:35 pm

Zoltan Miskolci

- Updated test config names - Removed invalid publish from gen_dialysate

Options
    • -2
    • +2
    /leahi_dialin/common/test_config_defs.py
    • -4
    • +0
    /leahi_dialin/dd/modules/gen_dialysate.py
4:33 pm

Nicholas Ramirez

add comment why updating the double click to adding the threashold

add comment why updating the double click to adding the threashold

4:24 pm

Nicholas Ramirez

LDT-3312 Misc SW Enhancements - SW - 01 - General Aesthetics - R&I - 05: DEV - Feature Implementation

adjust fonts of diagnosis popuip

Options
    • -8
    • +4
    /sources/gui/qml/components/DebugDataColumn.qml
    • -1
    • +1
    /sources/gui/qml/globals/Fonts.qml
4:19 pm

Dara Navaei

LEAHI-TESTSUITES-LDT-3014_End of Treatment - SW - 02 - Q&R
LEAHI-TESTSUITES-LDT-3014_End of Treatment - SW - 02 - Q&R