application

Clone Tools

Stats

Commits this week: 6
Total Committers: 14
Last Commit: 20 Mar
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 29 Jan 2021
4:19 pm

Peter Lucia <plucia@diality.com>

DEN-6359: Addressed code review comments.

Options
    • -1
    • +1
    /.gitignore
12:19 pm

Behrouz NematiPour

Merge branch 'DEN-5777_UI_DEV_ConvertLogging_From_hrs_to_%' into UI_DEV

Options
12:18 pm

Behrouz NematiPour

DEN-6619: Implementation

- Added a signal named didSDCardSpaceTooLow in the DriveWatcher which will be triggered when the free storage space available on the SD-CARD is less than 10%. (No action on UI happens currently)

- Added a flag in DriveWatcher to stop emitting the Logger while it is cleaning the Logs [[ IMPORTANT : is is handled by signal/slots for thread synchronization and safety ]].

- Added a function to find the total size of the file in a path.

- Added find function to find files with a list of filter in a path.

- Added an overloaded version of find to help find the files in a path which are exceeding the storage limit from the oldest files.

- Added error check in the read overloaded which works with Json.

- Re-implemented the FileHandler::removeLogs to clean up the logs by % instead of date.

- Removed unused global log paths from StorageGlobal.

-

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +15
    /sources/ApplicationController.cpp
    • -0
    • +2
    /sources/ApplicationController.h
    • -0
    • +16
    /sources/gui/GuiController.cpp
    • -0
    • +2
    /sources/gui/GuiController.h
    • -9
    • +24
    /sources/gui/GuiView.cpp
    • -6
    • +9
    /sources/gui/GuiView.h
    • -5
    • +24
    /sources/storage/DriveWatcher.cpp
    • -1
    • +13
    /sources/storage/DriveWatcher.h
    • -5
    • +130
    /sources/storage/FileHandler.cpp
    • -1
    • +8
    /sources/storage/FileHandler.h
    • -17
    • +41
    /sources/storage/Logger.cpp
    • -13
    • +31
    /sources/storage/Logger.h
    • -5
    • +0
    /sources/storage/StorageGlobals.cpp
    • -1
    • +1
    /sources/view/VTreatmentCreate.cpp
    • -2
    • +2
    /unittests/tst_views.cpp
12:04 pm

Behrouz NematiPour

Merge branch 'DEN-5751_Pre-TreatmentUltrafiltration' into UI_DEV

Options
11:08 am

plucia  (deleted user)

Can delete

Can delete

11:05 am

plucia  (deleted user)

Do these properties still exist?

Do these properties still exist?

11:03 am

plucia  (deleted user)

If FW responds back saying either arterial or venous pressure limit ranges are invalid, the user corrects them, and then we proceed, without doing anything upon validation success the pressure limi...

If FW responds back saying either arterial or venous pressure limit ranges are invalid, the user corrects them, and then we proceed, without doing anything upon validation success the pressure limits would still show up as invalid the next time the user enters the create treatment screen.

11:00 am

plucia  (deleted user)

How will this notification bar look if an alarm is raised but minimized? Would there be two notification bars visible?

How will this notification bar look if an alarm is raised but minimized? Would there be two notification bars visible?

10:57 am

plucia  (deleted user)

It seems like some variables are being defined in QML while others are in cpp. I've seen this happen with TreatmentCreate. What's the plan for where PRS default variables should be defined?

It seems like some variables are being defined in QML while others are in cpp.
I've seen this happen with TreatmentCreate. What's the plan for where PRS default variables should be defined?

10:56 am

plucia  (deleted user)

Can delete

Can delete

10:55 am

plucia  (deleted user)

Should point to HDSimulator since denaliMessages has been deprecated

Should point to HDSimulator since denaliMessages has been deprecated

10:55 am

plucia  (deleted user)

Should point to HDSimulator, as denaliMessages has been deprecated

Should point to HDSimulator, as denaliMessages has been deprecated

10:54 am

plucia  (deleted user)

Should point to the HDSimulator

Should point to the HDSimulator

10:54 am

plucia  (deleted user)

This should point to the HDSimulator to avoid future conflicts with dialin

This should point to the HDSimulator to avoid future conflicts with dialin

10:53 am

plucia  (deleted user)

Should point to the HDSimulator

Should point to the HDSimulator

10:40 am

plucia  (deleted user)

here as well (see above)

here as well (see above)

10:40 am

plucia  (deleted user)

These limits should reside next to the other treatment parameter defaults in TreatmentCreate.h. Putting them in QML causes changes to the treatment parameters configuration file (specifically arter...

These limits should reside next to the other treatment parameter defaults in TreatmentCreate.h.
Putting them in QML causes changes to the treatment parameters configuration file (specifically arterial and venous pressure limits) to have no effect.

10:18 am

plucia  (deleted user)

This has been removed from dialin

This has been removed from dialin

10:08 am

plucia  (deleted user)

denaliMessages has been deprecated. Please don't add it back to dialin. This should be self.hd_simulator.alarms.cmd_set_alarm_triggered

denaliMessages has been deprecated. Please don't add it back to dialin. This should be

self.hd_simulator.alarms.cmd_set_alarm_triggered
10:08 am

plucia  (deleted user)

denaliMessages has been deprecated. Please don't add it back to dialin. This should be self.hd_simulator.alarms.cmd_set_alarm_cleared

denaliMessages has been deprecated. Please don't add it back to dialin. This should be

self.hd_simulator.alarms.cmd_set_alarm_cleared
10:03 am

plucia  (deleted user)

Should be self.hd_simulator.alarms.cmd_activate_alarm_id

Should be 

self.hd_simulator.alarms.cmd_activate_alarm_id
9:59 am

plucia  (deleted user)

Should be self.hd_simulator.set_treatment_heparin_data(volume)

Should be 

self.hd_simulator.set_treatment_heparin_data(volume)
Wednesday 27 Jan 2021
5:16 pm

Behrouz NematiPour

DEN-5758: Code Analysis

Options
    • -96
    • +106
    /cppcheck.log
11:03 am

plucia  (deleted user)

10:54 am

Behrouz NematiPour

Merge branch 'master' into DEN-5736_UI_Heparin_Bolus

Options
10:49 am

Behrouz NematiPour

will be done later. RESOLVED

will be done later.
RESOLVED

10:48 am

Behrouz NematiPour

needs to investigate more or done later. RESOLVED

needs to investigate more or done later.
RESOLVED

10:47 am

Behrouz NematiPour

will be done later. RESOLVED

will be done later.
RESOLVED

10:47 am

Behrouz NematiPour

will be done later. RESOLVED

will be done later.
RESOLVED

10:47 am

plucia  (deleted user)

Resolved as per our code review 1.27.2021

Resolved as per our code review 1.27.2021