application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 16 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Mar 2022
5:41 pm

Michael Garthwaite

DEN-12121: Updates per code review

Options
    • -3
    • +2
    /sources/canbus/MessageGlobals.h
    • -0
    • +1
    /sources/gui/GuiGlobals.h
    • -0
    • +1
    /sources/gui/qml/AlarmItem.qml
    • -1
    • +1
    /sources/gui/qml/dialogs/DiagnosticsDialog.qml
    • -2
    • +1
    /sources/gui/qml/main.qml
    • -3
    • +3
    /sources/model/dg/data/MDGConductivityData.h
    • -3
    • +3
    /sources/model/hd/data/MHDAirBubbleData.h
    • -3
    • +3
    /sources/model/hd/data/MHDAirTrapData.h
    • -3
    • +3
    /sources/model/hd/data/MHDBloodLeakData.h
5:32 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

4:48 pm

Behrouz NematiPour

This needs to be updated to 10 * 4 if the change to the "TreatmentStates" is approved by Sean Nash. Also please remove the duplicate.

This needs to be updated to 10 * 4 if the change to the "TreatmentStates" is approved by Sean Nash.
Also please remove the duplicate.

4:42 pm

Behrouz NematiPour

Sean Nash, How the change to the TreatmentState message will affect the Application? This newly added parameter seems redundant to me. The change is the "Dialysis State" addition. 10 - (U32) Dial...

Sean Nash,
How the change to the TreatmentState message will affect the Application?
This newly added parameter seems redundant to me.

The change is the "Dialysis State" addition.

10 - (U32) Dialysis state
Unknown macro: { 0=start, 1=UF, 2=saline bolus }

0x0F00 15 0x040 4 Hz N HD All Treatment State sub-mode (U32-enum) (U32) UF state (U32) saline bolus state (U32) Hep state (U32) Rinseback state (U32) Recirc state 7 - (U32) Bld Prime state 8 - (U32) Tx End state 9 - (U32) Stop state 10 - (U32) Dialysis state
4:40 pm

Behrouz NematiPour

Please remove the box column, we decided not to use it in the Application documentation. Please do this for all the new models added.

Please remove the box column, we decided not to use it in the Application documentation.
Please do this for all the new models added.

4:27 pm

Behrouz NematiPour

It has been defined in the AlarmItem. Expose the VAlarmStatus property from AlarmItem.qml by adding this line: readonly property alias alarm_AlarmID : vAlarmStatus.alarm_AlarmID then use the ...

It has been defined in the AlarmItem.
Expose the VAlarmStatus property from AlarmItem.qml by adding this line:

    readonly property alias alarm_AlarmID : vAlarmStatus.alarm_AlarmID


then use the AlarmItem object, (which has been defined in the main.qml) to get the alarm id like the line below:

_alarmItem.alarm_AlarmID


Thanks,

3:55 pm

Michael Garthwaite

Users can not see the alarm screen when the diagnostics screen is visible. This was a request by systems in DEN-12118. Is there another approach to this?

Users can not see the alarm screen when the diagnostics screen is visible. This was a request by systems in DEN-12118. Is there another approach to this?

3:47 pm

Behrouz NematiPour

it has already been defined, this would be a duplicate handler. why do we need to have the top on diagnostics while it has to always be on alarm dialog/bar on screen?

it has already been defined, this would be a duplicate handler.
why do we need to have the top on diagnostics while it has to always be on alarm dialog/bar on screen?

3:45 pm

Michael Garthwaite

Required to display the Alarm Top on the diagnostic screen

Required to display the Alarm Top on the diagnostic screen

3:43 pm

Behrouz NematiPour

keep one line empty on top of the // HD Data Messages

keep one line empty on top of the // HD Data Messages

3:41 pm

Behrouz NematiPour

Why VAlarmStatus is added?

Why VAlarmStatus is added?

3:35 pm

Behrouz NematiPour

This message has been defined with 5xF32 parameters. 0x3100 49 0x080 1 Hz N DG All DG Conductivity Data (F32) RO rejection ratio (F32) CPi conductivity (F32) CPo conductivity (F32) CD1 conductivit...

This message has been defined with 5xF32 parameters.

0x3100 49 0x080 1 Hz N DG All DG Conductivity Data (F32) RO rejection ratio (F32) CPi conductivity (F32) CPo conductivity (F32) CD1 conductivity (F32) CD2 conductivity
3:23 pm

Behrouz NematiPour

Not really but since I'm not done with new ones, I would still keep them for a while.

Not really but since I'm not done with new ones, I would still keep them for a while.

1:04 pm

Michael Garthwaite

Do we need to keep these legacy files at all?

Do we need to keep these legacy files at all?

Tuesday 01 Mar 2022
8:12 pm

Dara Navaei

UI-DEN-12121_SW Dev Sprint 65
UI-DEN-12121_SW Dev Sprint 65
4:08 pm

Behrouz NematiPour

Merge branch 'DEN-12182-ui_dev-sprint-65' into develop

Options
4:08 pm

Behrouz NematiPour

DEN-10153: Treatment Log Comments Investigations

- Added the missing prescribed UF Volume, Rate to the log and review.

Options
    • -0
    • +4
    /sources/storage/TreatmentLog.cpp
    • -0
    • +6
    /sources/storage/TreatmentLog.h
    • -0
    • +2
    /sources/view/hd/adjustment/posttreatment/VPostTreatmentAdjustTreatmentLog.cpp
    • -0
    • +2
    /sources/view/hd/adjustment/posttreatment/VPostTreatmentAdjustTreatmentLog.h
2:23 pm

Behrouz NematiPour

Merge branch 'DEN-12182-ui_dev-sprint-65' into develop

Options
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
2:22 pm

Behrouz NematiPour

DEN-12204 Code Analysis

- Broke the build and fixed.

Options
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
10:02 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
10:01 am

Behrouz NematiPour

Merge branch 'DEN-12182-ui_dev-sprint-65' into develop

Options
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
10:01 am

Behrouz NematiPour

DEN-12204 Code Analysis

- cppcheck is confusing Message struct in different scopes and giving an error in CloudSync file about the struct in MessageGlobals, but the error has been fixed to avoid build fail.

Options
    • -1
    • +97
    /cppcheck.err
    • -0
    • +998
    /cppcheck.log
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
Monday 28 Feb 2022
5:28 pm

Dara Navaei

UI-DEN-12182_UI Dev Sprint 65
UI-DEN-12182_UI Dev Sprint 65
5:25 pm

Behrouz NematiPour

Merge branch 'DEN-12182-ui_dev-sprint-65' into develop

Options
5:21 pm

Behrouz NematiPour

Merge branch 'DEN-12121-sw_dev-sprint-65' into develop

Options
4:59 pm

Behrouz NematiPour

DEN-12180: Internal general support

- investigate on the Begin Prime back to Cartridge installation

- Added objectName for easier debug.

- added the stack change for the Cartridge Installation in case FW wants to navigate back from Begin Prime to the beginning of Cartridge Installation.

Options
    • -1
    • +1
    /denali.pro.user
    • -0
    • +4
    /sources/gui/qml/pages/posttreatment/PostTreatmentStack.qml
    • -0
    • +5
    /sources/gui/qml/pages/pretreatment/PreTreatmentDisposablesStack.qml
    • -0
    • +2
    /sources/gui/qml/pages/pretreatment/PreTreatmentPrimeStack.qml
    • -8
    • +8
    /sources/gui/qml/pages/pretreatment/PreTreatmentStack.qml
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
4:43 pm

Michael Garthwaite

DEN-12121: Updated Models and views to latest messaging protocol. Fixed BLD to show detect counter. Updated get version to display compatibility revision.

Options
    • -4
    • +6
    /sources/gui/qml/dialogs/DiagnosticsDialog.qml
    • -24
    • +28
    /sources/model/dg/adjustment/settings/MAdjustDGVersionsResponse.cpp
    • -24
    • +27
    /sources/model/dg/adjustment/settings/MAdjustDGVersionsResponse.h
    • -24
    • +28
    /sources/model/hd/adjustment/settings/MAdjustHDVersionsResponse.cpp
    • -24
    • +27
    /sources/model/hd/adjustment/settings/MAdjustHDVersionsResponse.h
    • -0
    • +4
    /sources/model/hd/data/treatment/MTreatmentStatesData.cpp
    • -0
    • +2
    /sources/model/hd/data/treatment/MTreatmentStatesData.h
    • -24
    • +28
    /sources/view/settings/VAdjustmentVersions.cpp
    • -18
    • +20
    /sources/view/settings/VAdjustmentVersions.h
11:20 am

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    /sources/model/hd/alarm/MAlarmMapping.cpp
11:19 am

Behrouz NematiPour

Merge branch 'DEN-12182-ui_dev-sprint-65' into develop

Options
11:19 am

Behrouz NematiPour

DEN-12180: INT: Alarm dialog body space [RC: 15*80]

- reduced the bottom margin of the Alarm Dialog bottoms.

- removed the space from the legacy files which caused issue with DevOps scripts.

Options
    • -1
    • +1
    /denali.pro.user
    • -1
    • +1
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -577
    • +0
    /sources/view/VTreatmentCreate (legacy).cpp
    • -258
    • +0
    /sources/view/VTreatmentCreate (legacy).h
    • -0
    • +577
    /sources/view/VTreatmentCreate(legacy).cpp
    • -0
    • +258
    /sources/view/VTreatmentCreate(legacy).h