application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 20 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 14 Aug 2020
4:48 pm

Peter Lucia <plucia@diality.com>

Updated unit tests, fixed arterial and venous conversions to signed int.

Options
    • -3
    • +3
    /denali.pro.user
    • -4
    • +4
    /sources/model/mtreatmentparameters.cpp
    • -0
    • +1
    /sources/view/VCreateTreatment.cpp
    • -0
    • +6
    /unittests/tst_messaging.cpp
    • -61
    • +189
    /unittests/tst_models.cpp
    • -0
    • +1
    /unittests/tst_models.h
    • -1
    • +155
    /unittests/tst_views.cpp
    • -0
    • +1
    /unittests/tst_views.h
1:24 pm

Peter Lucia <plucia@diality.com>

Added unit test for treatment parameters response data's fromVariantList

Options
    • -0
    • +55
    /unittests/tst_models.cpp
    • -0
    • +1
    /unittests/tst_models.h
11:07 am

Peter Lucia <plucia@diality.com>

Fixed treatment parameter data lengths and error indices

Options
    • -17
    • +38
    /unittests/tst_models.cpp
11:01 am

Peter Lucia <plucia@diality.com>

Updated unit tests. Fixed treatment parameter length check and made arterial and venous ints signed instead of unsigned.

Options
    • -2
    • +3
    /sources/model/mtreatmentparameters.cpp
    • -4
    • +4
    /sources/view/VCreateTreatment.h
    • -2
    • +80
    /unittests/tst_models.cpp
    • -0
    • +4
    /unittests/tst_models.h
    • -0
    • +23
    /unittests/tst_views.cpp
    • -1
    • +0
    /unittests/tst_views.h
Thursday 13 Aug 2020
11:53 pm

Behrouz NematiPour

DEN-4443: Integration Testing

Options
    • -1
    • +1
    /denali.pro.user
    • -2
    • +5
    /sources/gui/qml/pages/treatment/sections/TreatmentUltrafiltration.qml
8:18 pm

Behrouz NematiPour

DEN-4502: Static Code Analysis

Options
    • -5
    • +54
    /cppcheck.err
    • -56
    • +252
    /cppcheck.log
7:38 pm

Behrouz NematiPour

DEN-4441: Implementation

- Implemented the SRSUI 256: Restrictions - Max Delivered

Options
    • -1
    • +1
    /denali.pro.user
    • -2
    • +3
    /sources/gui/guiglobals.h
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +4
    /sources/gui/qml/pages/treatment/sections/TreatmentFluid.qml
    • -7
    • +19
    /sources/gui/qml/pages/treatment/sections/TreatmentSaline.qml
    • -1
    • +2
    /sources/view/hd/adjustment/VTreatmentAdjustmentSaline.cpp
    • -0
    • +1
    /sources/view/hd/adjustment/VTreatmentAdjustmentSaline.h
4:51 pm

Peter Lucia <plucia@diality.com>

Moved == operator to uni ttests & updated views unit test. Added CreateTreatmentReq case to interpretMessage

Options
    • -0
    • +11
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +50
    /sources/model/mtreatmentparameters.cpp
    • -22
    • +5
    /sources/model/mtreatmentparameters.h
    • -1
    • +17
    /unittests/tst_views.cpp
1:59 pm

Peter Lucia <plucia@diality.com>

Updated unit tests: CSV, message interpreter. Added ability to save treatment parameter ranges to CSV

Options
    • -6
    • +8
    /sources/storage/storageglobals.cpp
    • -3
    • +4
    /sources/storage/storageglobals.h
    • -0
    • +57
    /sources/view/VCreateTreatment.cpp
    • -0
    • +2
    /sources/view/VCreateTreatment.h
    • -1
    • +17
    /unittests/tst_messaging.cpp
    • -1
    • +2
    /unittests/tst_messaging.h
    • -0
    • +17
    /unittests/tst_views.cpp
    • -1
    • +3
    /unittests/tst_views.h
12:02 pm

Peter Lucia <plucia@diality.com>

Updated unit tests, improved code testability

Options
    • -0
    • +22
    /sources/model/mtreatmentparameters.h
    • -9
    • +7
    /sources/view/VCreateTreatment.cpp
    • -2
    • +2
    /sources/view/VCreateTreatment.h
    • -32
    • +215
    /unittests/tst_views.cpp
    • -0
    • +3
    /unittests/tst_views.h
1:56 am

Behrouz NematiPour

DEN-4441: Implementation/Ultrafiltration

- Also did the :

- DEN-4442: Unit Testing

- DEN-4443: Integration Testing

- DEN-4444: Code Coverage

Options
    • -42
    • +50
    /denali.pro
    • -3
    • +3
    /denali.pro.user
    • -2
    • +6
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +1
    /sources/gui/guiglobals.cpp
    • -3
    • +15
    /sources/gui/guiglobals.h
    • -1
    • +18
    /sources/gui/qml/components/NotificationBarSmall.qml
    • -2
    • +8
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -13
    • +11
    /sources/gui/qml/pages/treatment/sections/TreatmentFluid.qml
    • -4
    • +4
    /sources/gui/qml/pages/treatment/sections/TreatmentSaline.qml
    • -5
    • +29
    /sources/gui/qml/pages/treatment/sections/TreatmentTime.qml
    • -5
    • +6
    /sources/gui/qml/pages/treatment/sections/TreatmentUltrafiltration.qml
    • -1
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationStateResponse.h
    • -44
    • +0
    /sources/view/VHDOperationModeData.cpp
    • -45
    • +0
    /sources/view/VHDOperationModeData.h
    • -52
    • +0
    /sources/view/VTreatmentAdjustmentSaline.cpp
  16. … 16 more files in changeset.
Wednesday 12 Aug 2020
6:30 pm

Peter Lucia <plucia@diality.com>

Added Create Treatment unit tests

Options
    • -59
    • +925
    /denali.pro.user
    • -1
    • +3
    /sources/gui/qml/pages/treatment/TreatmentConfirm.qml
    • -32
    • +37
    /sources/view/VCreateTreatment.cpp
    • -1
    • +7
    /sources/view/VCreateTreatment.h
    • -0
    • +250
    /unittests/tst_views.cpp
    • -0
    • +9
    /unittests/tst_views.h
Tuesday 11 Aug 2020
11:09 am

Peter Lucia <plucia@diality.com>

Added object names for squishqt testing, updated to the latest VM projects path, fixed spellings

Options
    • -0
    • +644
    /denali.pro.user
    • -2
    • +2
    /scripts/copy.sh
    • -2
    • +2
    /sources/canbus/messageinterpreter.cpp
    • -6
    • +8
    /sources/gui/qml/components/RectSelectCreateTreatment.qml
    • -0
    • +2
    /sources/gui/qml/components/SliderCreateTreatment.qml
    • -0
    • +4
    /sources/gui/qml/components/SliderDoubleCreateTreatment.qml
    • -0
    • +42
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -1
    • +1
    /sources/view/VCreateTreatment.cpp
Monday 10 Aug 2020
10:36 pm

Behrouz NematiPour

DEN-4441: Implementation

- removed extra E in log as a work around the issue with the adjustment models which have not yet inherited from MAbstract.

- in the section notification if the image is empty then assign the image place to the text to be align at the left most of the section.

- added a reason text by default in the response base class.

Options
    • -5
    • +5
    /sources/gui/qml/components/NotificationBarSmall.qml
    • -1
    • +5
    /sources/model/MAbstract.cpp
    • -3
    • +5
    /sources/view/vtreatmentadjustmentresponsebase.h
9:59 pm

Behrouz NematiPour

DEN-4441: Implementation

- added functionalities.

- Qml

- Views

- ...

Options
    • -4
    • +8
    /denali.pro
    • -0
    • +1
    /denali.qrc
    • -0
    • +13
    /sources/canbus/messagedispatcher.cpp
    • -2
    • +7
    /sources/canbus/messageglobals.h
    • -1
    • +9
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +2
    /sources/gui/guiglobals.cpp
    • -2
    • +7
    /sources/gui/guiglobals.h
    • -0
    • +4
    /sources/gui/qml/globals/Variables.qml
    • -0
    • +1
    /sources/gui/qml/main.qml
    • -6
    • +11
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -5
    • +1
    /sources/gui/qml/pages/treatment/TreatmentStart.qml
    • -15
    • +23
    /sources/gui/qml/pages/treatment/sections/TreatmentFluid.qml
    • -0
    • +48
    /sources/gui/qml/pages/treatment/sections/TreatmentSaline.qml
    • -1
    • +2
    /sources/gui/qml/pages/treatment/sections/TreatmentUltrafiltration.qml
    • -17
    • +32
    /sources/model/MModel.h
  16. … 10 more files in changeset.
12:17 pm

Behrouz NematiPour

DEN-3884: Code Review 0

- fixed some typo and white spaces.

Options
    • -4
    • +4
    /sources/canbus/messageacknowmodel.h
    • -4
    • +3
    /sources/canbus/messagebuilder.cpp
    • -4
    • +4
    /sources/canbus/messageglobals.h
    • -0
    • +5
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +0
    /sources/gui/qml/main.qml
    • -2
    • +2
    /sources/view/valarmstatus.cpp
12:16 pm

Behrouz NematiPour

DEN-4441: Implementation

- Added required Models for 3 messages: req, res, data.

Options
    • -0
    • +4
    /denali.pro
    • -3
    • +22
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -0
    • +44
    /sources/model/hd/adjustment/MTreatmentAdjustSalineResponse.cpp
    • -0
    • +61
    /sources/model/hd/adjustment/MTreatmentAdjustSalineResponse.h
    • -0
    • +43
    /sources/model/hd/data/MTreatmentSalineData.cpp
    • -0
    • +63
    /sources/model/hd/data/MTreatmentSalineData.h
Thursday 06 Aug 2020
9:46 pm

Behrouz NematiPour

DEN-4436: Denali Investigate and Fix the new VM issues

- Fixed a unit test

Options
    • -104
    • +255
    /denali.pro.user
    • -2
    • +2
    /unittests/tst_models.cpp
5:40 pm

Behrouz NematiPour

DEN-4436: Denali Investigate and Fix the new VM issues

- Removed extra debug code.

Options
    • -1
    • +0
    /sources/gui/guiglobals.cpp
4:44 pm

Peter Lucia <plucia@diality.com>

Merge with Logging2of3

Options
    • -71
    • +150
    /denali.pro
    • -1489
    • +0
    /denali.pro.user
    • -13
    • +13
    /sources/applicationcontroller.cpp
    • -4
    • +4
    /sources/applicationcontroller.h
    • -31
    • +51
    /sources/canbus/messageglobals.h
    • -646
    • +282
    /sources/canbus/messageinterpreter.cpp
    • -60
    • +26
    /sources/canbus/messageinterpreter.h
    • -2
    • +2
    /sources/gui/guicontroller.cpp
    • -4
    • +4
    /sources/gui/guicontroller.h
    • -8
    • +24
    /sources/gui/guiglobals.cpp
    • -39
    • +59
    /sources/gui/guiglobals.h
    • -18
    • +17
    /sources/gui/qml/components/NotificationBar.qml
    • -6
    • +9
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -10
    • +21
    /sources/gui/qml/globals/Variables.qml
    • -12
    • +29
    /sources/gui/qml/main.qml
  16. … 10 more files in changeset.
1:07 pm

Peter Lucia <plucia@diality.com>

Added function descriptions

Options
    • -7
    • +12
    /sources/view/VCreateTreatment.cpp
3:03 am

Behrouz NematiPour

DEN-3883: Coverage

- DGCheckIn message

Options
    • -5
    • +8
    /sources/canbus/frameinterface.cpp
    • -0
    • +2
    /sources/canbus/messageinterpreter.cpp
2:16 am

Behrouz NematiPour

DEN-3883: Coverage

Options
    • -244
    • +57
    /denali.pro.user
    • -3
    • +7
    /sources/canbus/messagedispatcher.cpp
    • -20
    • +14
    /sources/canbus/messageinterpreter.cpp
    • -18
    • +17
    /sources/gui/qml/components/NotificationBar.qml
    • -6
    • +9
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -0
    • +1
    /sources/gui/qml/pages/SettingsHome.qml
    • -65
    • +67
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -2
    • +9
    /sources/model/hd/alarm/MAlarmStatusData.h
    • -7
    • +5
    /sources/storage/filehandler.cpp
    • -0
    • +2
    /sources/storage/logger.cpp
    • -7
    • +1
    /sources/view/valarmstatus.cpp
    • -27
    • +56
    /unittests/tst_messaging.cpp
    • -5
    • +7
    /unittests/tst_messaging.h
    • -11
    • +138
    /unittests/tst_models.cpp
    • -5
    • +16
    /unittests/tst_models.h
Wednesday 05 Aug 2020
2:54 pm

Peter Lucia <plucia@diality.com>

Added handling of treatment parameter FW response

Options
    • -7
    • +0
    /denali.pro
    • -1
    • +1
    /denali.pro.user
    • -8
    • +19
    /sources/gui/qml/components/RectSelectCreateTreatment.qml
    • -4
    • +18
    /sources/gui/qml/components/SliderCreateTreatment.qml
    • -4
    • +26
    /sources/gui/qml/components/SliderDoubleCreateTreatment.qml
    • -0
    • +1
    /sources/gui/qml/globals/Colors.qml
    • -6
    • +97
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +1
    /sources/main.h
    • -1
    • +1
    /sources/storage/storageglobals.cpp
    • -32
    • +12
    /sources/view/VCreateTreatment.cpp
    • -0
    • +1
    /sources/view/VCreateTreatment.h
Monday 03 Aug 2020
6:33 pm

Behrouz NematiPour

DEN-3883: Coverage

Options
    • -1
    • +1
    /sources/storage/DriveWatcher.cpp
    • -1
    • +1
    /sources/storage/logger.cpp
12:46 pm

Behrouz NematiPour

DEN-4246: Merge Newly added Squish API Messages into Dial-In

- made some logs more readable.

Options
    • -2
    • +2
    /main.cpp
    • -1
    • +1
    /sources/canbus/messageinterpreter.cpp
    • -4
    • +4
    /sources/gui/guiglobals.cpp
8:59 am

Peter Lucia <plucia@diality.com>

Squashed commit of the following:

commit 5331f4838ac4d591fd26120f471f89c226863734

Author: Peter Lucia <plucia@diality.com>

Date: Thu Jul 30 12:52:48 2020 -0700

Began adding qml slots for when validation fails

commit 63c55a131a04f17a9306ff25988e686b1edbbc2a

Author: Peter Lucia <plucia@diality.com>

Date: Thu Jul 30 12:22:58 2020 -0700

Parsing FW validation response

commit b17f0bfe38526a16e02e7e5bcf295939e24fd659

Author: Peter Lucia <plucia@diality.com>

Date: Thu Jul 30 10:05:05 2020 -0700

Handling create treatment response message

commit a57d0fe761842df3e29136d78194b1d5b3ba18af

Author: Peter Lucia <plucia@diality.com>

Date: Wed Jul 29 13:22:44 2020 -0700

Fixed resetting of treatment parameters.

commit aab29013cf0691a7f61e4f531400f4943c6d3bf8

Author: Peter Lucia <plucia@diality.com>

Date: Wed Jul 29 11:24:10 2020 -0700

Improved UI side parameter selection validation.

commit edb0f66f1bc9c954ff1f51f375b0bdfd8b125859

Author: Peter Lucia <plucia@diality.com>

Date: Tue Jul 28 15:44:11 2020 -0700

Improved default parameter inactive / active colors

commit f2677a919a885333c8e34f8340593fbabc56f823

Author: Peter Lucia <plucia@diality.com>

Date: Tue Jul 28 15:11:38 2020 -0700

Ensuring treatment parameters indicate when they are adjusted or unset.

commit 5e83584957eab076c2ebe7d546362a461bbfbaa8

Author: Peter Lucia <plucia@diality.com>

Date: Tue Jul 28 09:55:23 2020 -0700

Added arterial and venous pressure limits

commit a1b67a61af501334847c8514360cf82348e2c65c

Author: Peter Lucia <plucia@diality.com>

Date: Mon Jul 27 17:56:55 2020 -0700

Using VCreateTreatment cpp / h class to determine new treatment ranges

commit 738cb12bc9b4400ab815b17c43228ad5e532db33

Author: Peter Lucia <plucia@diality.com>

Date: Mon Jul 27 15:43:56 2020 -0700

Loading create treatment ranges from the file system

Added macro to convert variable name to string

Added debug | release #define

commit fbc9f08ea3163b617bda7f393bf3285b8b4e8d41

Author: Peter Lucia <plucia@diality.com>

Date: Wed Jul 22 16:54:55 2020 -0700

Cleanup old comments

commit edf1640d8e797ac1820d09d1de2ef78ed4713746

Author: Peter Lucia <plucia@diality.com>

Date: Wed Jul 22 16:35:32 2020 -0700

Moved save new treatment out of application controller

commit 191a70deefd31a614508a22a586dbd244ab67eed

Author: Peter Lucia <plucia@diality.com>

Date: Fri Jul 17 17:53:09 2020 -0700

In progress update for create treatment

commit f03e0bc116bafb36ac119d4c2d07bd57e20a5c33

Author: Peter Lucia <plucia@diality.com>

Date: Fri Jul 17 16:19:45 2020 -0700

In progress update for create treatment

commit 387a0099948bff42f2e49557f8136610c3443938

Author: Peter Lucia <plucia@diality.com>

Date: Fri Jul 17 14:53:08 2020 -0700

Saving newly created treatment to the log file

commit 28920a32fc6f8fe437c69364d3c8f059f16f7cc7

Author: Peter Lucia <plucia@diality.com>

Date: Fri Jul 17 14:49:15 2020 -0700

In progress update - application controller will save a newly created treatment to disk

commit 137d8d36144a143c7205b9c4620a88cc340670f4

Author: Peter Lucia <plucia@diality.com>

Date: Fri Jul 17 14:05:07 2020 -0700

In progress update of create treatment

commit f9131f48b9bd8580a93ca959540ce4ac97f228c3

Author: Peter Lucia <plucia@diality.com>

Date: Fri Jul 17 11:59:13 2020 -0700

In progress update for create treatment

commit 4b498f8f90ff7b2c8a057a3ef509bd86e1ea681c

Author: Peter Lucia <plucia@diality.com>

Date: Thu Jul 16 17:17:08 2020 -0700

Added cpp backend logic, top bar refinements.

Options
    • -0
    • +17
    /denali.pro
    • -3
    • +3
    /denali.pro.user
    • -3
    • +10
    /denali.qrc
    • binary
    /resources/images/alarm.png
    • binary
    /resources/images/bell-off.png
    • binary
    /resources/images/bell.png
    • -0
    • +5
    /sources/applicationcontroller.cpp
    • -0
    • +3
    /sources/applicationcontroller.h
    • -0
    • +4
    /sources/canbus/messageglobals.h
    • -0
    • +27
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +4
    /sources/canbus/messageinterpreter.h
    • -1
    • +0
    /sources/gui/guicontroller.cpp
    • -1
    • +0
    /sources/gui/guicontroller.h
    • -0
    • +1
    /sources/gui/guiglobals.cpp
    • -1
    • +6
    /sources/gui/guiglobals.h
  16. … 31 more files in changeset.
6:38 am

Behrouz NematiPour

DEN-4246: Merge Newly added Squish API Messages into Dial-In

Options
    • -1
    • +6
    /sources/storage/DriveWatcher.cpp
    • -0
    • +6
    /sources/storage/DriveWatcher.h
3:47 am

Behrouz NematiPour

DEN-4246: Merge Newly added Squish API Messages into Dial-In

Options
    • -3
    • +6
    /main.cpp
    • -63
    • +60
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +4
    /sources/canbus/messageinterpreter.h
    • -3
    • +8
    /sources/gui/guiglobals.cpp
    • -4
    • +4
    /sources/gui/qml/main.qml
    • -3
    • +3
    /sources/maintimer.cpp
    • -4
    • +5
    /sources/model/MDGDebugText.h
    • -5
    • +5
    /sources/model/MHDDebugText.h
    • -3
    • +3
    /sources/storage/logger.cpp
    • -9
    • +9
    /unittests/tst_models.cpp
Thursday 30 Jul 2020
3:03 am

Behrouz NematiPour

Merge master into Logging (#1 successful build and run)

Options
    • -4
    • +4
    /sources/applicationcontroller.cpp
    • -3
    • +4
    /sources/applicationcontroller.h
    • -5
    • +4
    /sources/canbus/messageinterpreter.cpp
    • -3
    • +3
    /sources/canbus/messageinterpreter.h
    • -3
    • +4
    /sources/gui/guicontroller.h
    • -3
    • +56
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +16
    /sources/model/hd/adjustment/MTreatmentAdjustRequests.h
    • -0
    • +76
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -2
    • +4
    /sources/model/hd/alarm/MAlarmStatusData.h
    • -4
    • +4
    /sources/view/valarmstatus.cpp