application / sources

canbus

Clone Tools

Stats

Commits this week: 2
Total Committers: 10
Last Commit: 09 Jun
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Mar 2022
5:41 pm

Michael Garthwaite

DEN-12121: Updates per code review

Options
    • -3
    • +2
    ./MessageGlobals.h
  2. … 8 more files in changeset.
4:48 pm

Behrouz NematiPour

This needs to be updated to 10 * 4 if the change to the "TreatmentStates" is approved by Sean Nash. Also please remove the duplicate.

This needs to be updated to 10 * 4 if the change to the "TreatmentStates" is approved by Sean Nash.
Also please remove the duplicate.

4:42 pm

Behrouz NematiPour

Sean Nash, How the change to the TreatmentState message will affect the Application? This newly added parameter seems redundant to me. The change is the "Dialysis State" addition. 10 - (U32) Dial...

Sean Nash,
How the change to the TreatmentState message will affect the Application?
This newly added parameter seems redundant to me.

The change is the "Dialysis State" addition.

10 - (U32) Dialysis state
Unknown macro: { 0=start, 1=UF, 2=saline bolus }

0x0F00 15 0x040 4 Hz N HD All Treatment State sub-mode (U32-enum) (U32) UF state (U32) saline bolus state (U32) Hep state (U32) Rinseback state (U32) Recirc state 7 - (U32) Bld Prime state 8 - (U32) Tx End state 9 - (U32) Stop state 10 - (U32) Dialysis state
4:40 pm

Behrouz NematiPour

Please remove the box column, we decided not to use it in the Application documentation. Please do this for all the new models added.

Please remove the box column, we decided not to use it in the Application documentation.
Please do this for all the new models added.

4:27 pm

Behrouz NematiPour

It has been defined in the AlarmItem. Expose the VAlarmStatus property from AlarmItem.qml by adding this line: readonly property alias alarm_AlarmID : vAlarmStatus.alarm_AlarmID then use the ...

It has been defined in the AlarmItem.
Expose the VAlarmStatus property from AlarmItem.qml by adding this line:

    readonly property alias alarm_AlarmID : vAlarmStatus.alarm_AlarmID


then use the AlarmItem object, (which has been defined in the main.qml) to get the alarm id like the line below:

_alarmItem.alarm_AlarmID


Thanks,

3:55 pm

Michael Garthwaite

Users can not see the alarm screen when the diagnostics screen is visible. This was a request by systems in DEN-12118. Is there another approach to this?

Users can not see the alarm screen when the diagnostics screen is visible. This was a request by systems in DEN-12118. Is there another approach to this?

3:47 pm

Behrouz NematiPour

it has already been defined, this would be a duplicate handler. why do we need to have the top on diagnostics while it has to always be on alarm dialog/bar on screen?

it has already been defined, this would be a duplicate handler.
why do we need to have the top on diagnostics while it has to always be on alarm dialog/bar on screen?

3:45 pm

Michael Garthwaite

Required to display the Alarm Top on the diagnostic screen

Required to display the Alarm Top on the diagnostic screen

3:43 pm

Behrouz NematiPour

keep one line empty on top of the // HD Data Messages

keep one line empty on top of the // HD Data Messages

3:41 pm

Behrouz NematiPour

Why VAlarmStatus is added?

Why VAlarmStatus is added?

3:35 pm

Behrouz NematiPour

This message has been defined with 5xF32 parameters. 0x3100 49 0x080 1 Hz N DG All DG Conductivity Data (F32) RO rejection ratio (F32) CPi conductivity (F32) CPo conductivity (F32) CD1 conductivit...

This message has been defined with 5xF32 parameters.

0x3100 49 0x080 1 Hz N DG All DG Conductivity Data (F32) RO rejection ratio (F32) CPi conductivity (F32) CPo conductivity (F32) CD1 conductivity (F32) CD2 conductivity
Tuesday 01 Mar 2022
8:12 pm

Dara Navaei

UI-DEN-12121_SW Dev Sprint 65
UI-DEN-12121_SW Dev Sprint 65
2:23 pm

Behrouz NematiPour

Merge branch 'DEN-12182-ui_dev-sprint-65' into develop

Options
    • -1
    • +1
    ./MessageGlobals.h
2:22 pm

Behrouz NematiPour

DEN-12204 Code Analysis

- Broke the build and fixed.

Options
    • -1
    • +1
    ./MessageGlobals.h
10:01 am

Behrouz NematiPour

Merge branch 'DEN-12182-ui_dev-sprint-65' into develop

Options
    • -1
    • +1
    ./MessageGlobals.h
10:01 am

Behrouz NematiPour

DEN-12204 Code Analysis

- cppcheck is confusing Message struct in different scopes and giving an error in CloudSync file about the struct in MessageGlobals, but the error has been fixed to avoid build fail.

Options
    • -1
    • +1
    ./MessageGlobals.h
  2. … 2 more files in changeset.
Thursday 24 Feb 2022
6:24 pm

Michael Garthwaite

Merge branch 'DEN-12121-sw_dev-sprint-65' into develop

Options
    • -1
    • +4
    ./MessageGlobals.h
    • -0
    • +4
    ./MessageInterpreter.cpp
  3. … 5 more files in changeset.
6:22 pm

Michael Garthwaite

DEN-12121: Further linkage for updating values on screen relating to DEN-12118

Options
    • -1
    • +4
    ./MessageGlobals.h
  2. … 2 more files in changeset.
Wednesday 23 Feb 2022
6:25 pm

Michael Garthwaite

Merge branch 'staging' into DEN-12121-sw_dev-sprint-65

Options
    • -8
    • +8
    ./MessageInterpreter.cpp
  2. … 9 more files in changeset.
6:24 pm

Michael Garthwaite

DEN-12121: Implemented Model and Views for BloodLeak, AirBubble, AirTrap and DG Conductvity for DEN-12118. Removed ODi and ODo in diagnostic dialog. Added isCompleted field in Rinseback Model for DEN-9932.

Options
    • -0
    • +4
    ./MessageInterpreter.cpp
  2. … 26 more files in changeset.
6:20 pm

Behrouz NematiPour

DEN-10974: Syringe pump installation screen allows user to proceed before syringe installed

- Added the response message 0xAD00(173), for the request message of 0x6200(98):Pre-treatmetn disposables confirm.

Options
    • -0
    • +1
    ./MessageGlobals.h
    • -0
    • +1
    ./MessageInterpreter.cpp
  3. … 10 more files in changeset.
Thursday 17 Feb 2022
6:57 pm

Behrouz NematiPour

Added Dialin to unhandled

- Added Dialin messages to be defined/logged by unhandled messages definitions.

- It needs the call with the option -d to enable the Dialin handling.

Options
    • -7
    • +17
    ./FrameInterface.cpp
    • -3
    • +5
    ./MessageInterpreter.cpp
  3. … 3 more files in changeset.
Wednesday 16 Feb 2022
10:10 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -6
    • +6
    ./CanInterface.cpp
    • -6
    • +6
    ./CanInterface.h
    • -6
    • +6
    ./FrameInterface.cpp
    • -6
    • +6
    ./FrameInterface.h
    • -6
    • +6
    ./MessageAcknowModel.cpp
    • -6
    • +6
    ./MessageAcknowModel.h
    • -6
    • +6
    ./MessageBuilder.cpp
    • -6
    • +6
    ./MessageBuilder.h
    • -6
    • +6
    ./MessageDispatcher.cpp
    • -6
    • +6
    ./MessageDispatcher.h
    • -7
    • +7
    ./MessageGlobals.h
    • -8
    • +8
    ./MessageInterpreter.cpp
    • -6
    • +6
    ./MessageInterpreter.h
  14. … 572 more files in changeset.
Tuesday 15 Feb 2022
12:49 pm

Behrouz NematiPour

11:38 am

Dara Navaei , Michael Garthwaite and Sean Nash

10:35 am

Dara Navaei

RESOLVED.

RESOLVED.

10:35 am

Behrouz NematiPour

Actually, this is correct. And it should not have parenthesis like you said, otherwise it becomes incorrect. if I write it like : ( ( x * ( maximum - minimum ) ) / width ) + minimum then too man...

Actually, this is correct.
And it should not have parenthesis like you said, otherwise it becomes incorrect.
if I write it like :

 ( ( x * ( maximum - minimum ) ) / width ) + minimum

then too many /redundant parentheses make it confusing.

10:24 am

Dara Navaei

To make sure the addition is done first, should you put ( width + minimum ) ?

To make sure the addition is done first, should you put ( width + minimum ) ?

10:16 am

Sean Nash

RESOLVED.

RESOLVED.

10:15 am

Sean Nash

RESOLVED.

RESOLVED.