Activity application/sources/gui/qml/components

9:51 am

Behrouz NematiPour

More
1f2e7db
changed 44 files
master, @Environement_Swith and 176 more UI-UCOMMITS-3

Merge branch 'DEN-14733-UI-BN-S90-2' into staging

- -3
- +3
./DebugDataColumn.qml
- History
- Source
- Diff
./DebugDataColumn.qml
- -10
- +12
./Slider.qml
- History
- Source
- Diff
./Slider.qml
… 42 more files in changeset.

9:23 am

Sean Nash and vduong (deleted user)

More
UI-DEN-14733-2
finished reviewing

9:18 am

vduong (deleted user)

Yes, assignments break bindings. RESOLVED

Yes, assignments break bindings.

RESOLVED

8:23 am

Behrouz NematiPour

More
Re: UI-DEN-14733-2
replied to vduong (deleted user)

Good point, But you can't. The readonly properties are only working with bindings, not assignments. I am using that as a public variable.

Good point,
But you can't.
The readonly properties are only working with bindings, not assignments.
I am using that as a public variable.

8:14 am

vduong (deleted user)

More
Re: UI-DEN-14733-2
commented on review

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

6:41 am

Behrouz NematiPour

DEN-14736 : IMP: DEN-14768 : InTx UF Adj

DEN-14768

Ultrafiltration Adjustment Screen Slider Does Not Update Maximum UF Vol after Duration Settings Adjustment

- -10
- +12
./Slider.qml
- History
- Source
- Diff
./Slider.qml

10:40 pm

Behrouz NematiPour

DEN-14736 : IMP: Updated MsgID 0x2D00

/*!

* \brief The MDGTemperatures class

* \details The DG temperatures data model

*

* | MSG | CAN ID | Box | Type | Ack | Src | Dst | Description |

* |:----:|:------:|:---:|:------:|:---:|:---:|:---:|:-----------: |

* |0x2D00| 0x080 | 8 | 2 Hz | N | DG | All | DG Temperatures Data |

*

* | Payload ||

* | ||

* | #01:(F32) | \ref Data::mInletPrimaryHeater |

* | #02:(F32) | \ref Data::mHeatDisinfect |

* | #03:(F32) | \ref Data::mOutletPrimaryHeater |

* | #04:(F32) | \ref Data::mConductivitySensor1 |

* | #05:(F32) | \ref Data::mConductivitySensor2 |

* | #06:(F32) | \ref Data::mOutletRedundancy |

* | #07:(F32) | \ref Data::mInletDialysate |

* | #08:(F32) | \ref Data::mPrimaryHeaterThermoCouple |

* | #09:(F32) | \ref Data::mTrimmerHeaterThermoCouple |

* | #10:(F32) | \ref Data::mPrimaryHeaterColdJunction |

* | #11:(F32) | \ref Data::mTrimmerHeaterColdJunction |

* | #12:(F32) | \ref Data::mPrimaryHeaterInternal |

* | #13:(F32) | \ref Data::mTrimmerHeaterInternal |

* | #14:(F32) | \ref Data::mFpgaBoard |

* | #15:(F32) | \ref Data::mLoadCellA1B1 |

* | #16:(F32) | \ref Data::mLoadCellA2B2 |

* | #17:(F32) | \ref Data::mInternalTHDORTD |

* | #18:(F32) | \ref Data::mInternalTDIRTD |

* | #19:(F32) | \ref Data::mInteralTHDRTD |

* | #20:(F32) | \ref Data::mInternalCondSnsrTemp |

* | #21:(F32) | \ref Data::mBaroTempSensor |

*

* \sa Data

*

* <h2 class="groupheader">Logging info</h2>

* | ||

* | typeText | Datum |

* | unitText | DG |

* | infoText | Temperatures |

*

*/

- -3
- +3
./DebugDataColumn.qml
- History
- Source
- Diff
./DebugDataColumn.qml
… 6 more files in changeset.

4:39 pm

jishii (deleted user)

More
UI-DEN-14733-2
resumed reviewing

11:08 am

Sean Nash

So we will likely remove this TODO and comment later? RESOLVED.

So we will likely remove this TODO and comment later?
RESOLVED.

11:06 am

Behrouz NematiPour

More
Re: UI-DEN-14733-2
replied to Sean Nash

It was removed. UI sends an alarmTriggered to HD for that, and should not display a dialog by itself. Since on the device, if there is no other alarm HD will eventually display it, and if there is ...

It was removed.
UI sends an alarmTriggered to HD for that, and should not display a dialog by itself.
Since on the device, if there is no other alarm HD will eventually display it, and if there is HD will override it.
It was just a bug in development then, which was always displaying a useless dialog on VM that doesn't even have a physical SD Card.

10:04 am

Behrouz NematiPour

More
Re: UI-DEN-14733-2
replied to Sean Nash

I laughed loud for a while https://devapps.diality.us/static/s73b8n/2static/images/wiki/icons/emoticons/biggrin.gif This is the spell checker dictionary. Since my spell checker was complaining and ...

I laughed loud for a while
This is the spell checker dictionary.
Since my spell checker was complaining and it was bugging me, and I always look at it like there is a bug in that area, I add her name so spell checker won't highlight it anymore.
It is a comment I have about the decision we made to remind me why I have that line of code commented.