components

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
please remove an extra empty line which is not necessary.

please remove an extra empty line which is not necessary.

Didn't we find an issue with changing this to bool instead of alias while were testing?

Didn't we find an issue with changing this to bool instead of alias while were testing?

in general, if the comment is for the entire if block put it in front of the if block. also for the else at line 66.

in general, if the comment is for the entire if block put it in front of the if block.
also for the else at line 66.

please move after the text property and remove the extra empty line.

please move after the text property and remove the extra empty line.

please move after the text property.

please move after the text property.

Please let the following calculation of the overlap do the separation. Otherwise will completely overlap and eventually displays one value which would be confusing. And also creates a position jump.

Please let the following calculation of the overlap do the separation.
Otherwise will completely overlap and eventually displays one value which would be confusing.
And also creates a position jump.

typo: ajust => adjust

typo: ajust => adjust

Please change the minimum gap to 4. I think when tested, 4 was sufficient.

Please change the minimum gap to 4.
I think when tested, 4 was sufficient.

UI-DEN-14796_UI BN S91_2
UI-DEN-14796_UI BN S91_2
UI-DEN-14838_UI VD S91 [ Sliders ]
UI-DEN-14838_UI VD S91 [ Sliders ]
Yes, assignments break bindings. RESOLVED

Yes, assignments break bindings.

RESOLVED

Good point, But you can't. The readonly properties are only working with bindings, not assignments. I am using that as a public variable.

Good point,
But you can't.
The readonly properties are only working with bindings, not assignments.
I am using that as a public variable.

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

If _root.isOpen is not modified outside of this powerItem.qml, You can make it a readonly property and bind it to the powerDialog's property.

So we will likely remove this TODO and comment later? RESOLVED.

So we will likely remove this TODO and comment later?
RESOLVED.

RESOLVED.

RESOLVED.

It was removed. UI sends an alarmTriggered to HD for that, and should not display a dialog by itself. Since on the device, if there is no other alarm HD will eventually display it, and if there is ...

It was removed.
UI sends an alarmTriggered to HD for that, and should not display a dialog by itself.
Since on the device, if there is no other alarm HD will eventually display it, and if there is HD will override it.
It was just a bug in development then, which was always displaying a useless dialog on VM that doesn't even have a physical SD Card.

I laughed loud for a while https://devapps.diality.us/static/s73b8n/2static/images/wiki/icons/emoticons/biggrin.gif This is the spell checker dictionary. Since my spell checker was complaining and ...

I laughed loud for a while
This is the spell checker dictionary.
Since my spell checker was complaining and it was bugging me, and I always look at it like there is a bug in that area, I add her name so spell checker won't highlight it anymore.
It is a comment I have about the decision we made to remind me why I have that line of code commented.

RESOLVED.

RESOLVED.

is this alignment correct? I see you align by . above (line 35-38) but I don't see examples of aligning by ( for function calls.

is this alignment correct? I see you align by . above (line 35-38) but I don't see examples of aligning by ( for function calls.

Why is her name in string table?

Why is her name in string table?

Any reason this alarm is commented out?

Any reason this alarm is commented out?

UI-DEN-14733_UI BN S90
UI-DEN-14733_UI BN S90