pages

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Code Review [ UI-DEN-14294-1 ]

Addressing the code review comments

- UI-DEN-14294-1

- UI-DEN-14294-UI BN S84

- UI-DEN-14294-UI-BN-S84

- UI-DEN-14294-UI_BN_S84

  1. … 1 more file in changeset.
DEN-14391: Qt 5.15.10

- Fixed the issue with the individual export file selection.

  1. … 1 more file in changeset.
DEN-14391 , DEN-14393 : Qt 5.15.10 [QML run-time issues]

- Fixed all the QML warning and errors

- Enabled the Clang-Tidy, Clazy and cppcheck and fixed some.

- Removed unused images

- made the Denali POST logo transparent.

    • -5
    • +5
    ./endtreatment/EndTreatmentEndStack.qml
    • -8
    • +8
    ./endtreatment/EndTreatmentRecirculateStack.qml
    • -22
    • +26
    ./endtreatment/EndTreatmentRinsebackStack.qml
    • -22
    • +22
    ./posttreatment/PostTreatmentStack.qml
    • -6
    • +6
    ./pretreatment/PreTreatmentConsumablesStack.qml
    • -4
    • +4
    ./pretreatment/PreTreatmentDisposablesStack.qml
    • -31
    • +31
    ./pretreatment/PreTreatmentPrimeStack.qml
    • -5
    • +5
    ./pretreatment/PreTreatmentWaterSampleStack.qml
    • -12
    • +12
    ./pretreatment/connection/PreTreatmentConnectionStack.qml
    • -11
    • +11
    ./pretreatment/create/PreTreatmentCreateStack.qml
  1. … 42 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    ./treatment/TreatmentUltrafiltrationItem.qml
    • -1
    • +1
    ./treatment/adjustments/TreatmentAdjustmentPressuresLimits.qml
  1. … 26 more files in changeset.
Merge branch 'DEN-14147-UI-BN-S82' into staging

  1. … 4 more files in changeset.
Merge branch 'DEN-13962-UI-BN-S82' into staging

  1. … 8 more files in changeset.
DEN-14239: Pressure monitor screen not displayed

- During the system tests, it has been observed the main treatment in-line blood pressure is not correctly setting the lower/higher bounds of the monitoring component.

  1. … 1 more file in changeset.
Merge branch 'DEN-14147-UI-BN-S82' into develop

DEN-14147: Add Required Heparin Volume for Treatment to Syringe Installation Screen

- Fixed isDevice in the export log.

Merge branch 'DEN-13962-UI-BN-S82' into develop

  1. … 7 more files in changeset.
DEN-13962: UI: Update pressure limits to match treatment params and UI screen

- Fixed the issue with the sliders not updating the ranges and the pressure adjustment was not able to be adjusted.

    • -2
    • +2
    ./treatment/adjustments/TreatmentAdjustmentPressuresLimits.qml
  1. … 1 more file in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    ./pretreatment/PreTreatmentPrimeStack.qml
  1. … 3 more files in changeset.
DEN-14209 - UI: Dry self test modifications

- Updated the View and the qml code regarding the changes to the enum made in common HDDefs.h

    • -25
    • +28
    ./pretreatment/PreTreatmentPrimeStack.qml
  1. … 5 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 46 more files in changeset.
DEN-13962: UI: Update pressure limits to match treatment params and UI screen

- removed the QML duplicate definitions of arterial/venous

- added monitoring values and used them in monitoring components of arterial/venous.

    • -12
    • +9
    ./pretreatment/create/PreTreatmentCreate.qml
    • -0
    • +7
    ./treatment/TreatmentUltrafiltrationItem.qml
    • -16
    • +16
    ./treatment/adjustments/TreatmentAdjustmentPressuresLimits.qml
  1. … 9 more files in changeset.
DEN-13962: UI: Update pressure limits to match treatment params and UI screen

- Completely restructure the vTreatmentCreate class and removed all the constant ranges properties from that to the VTreatmentRanges.

- Now reading all the constant ranges values from the DataList.conf from the ui.config repository.

- Used the RANGESET property type for the ranges in the VTreatmentRanges class to have by default properties for min,max, res(olution),def(ault) properties.

- Added an ability to slider to hide the handler when needed (Pre-Treatment)

- Hide the Slider handler when slider switch is off

- Added various PROPERTYs, like IDBASED, RAGESET, VALUESET

- Modified the MPreTreatmentAdjustRequest, duration parameter to treatmentDuration for clarifying.

- Modified the Settings class to able to parse a comment on the Group line.

- Updated the ConfirmTreatmentTable to hold the required labels and added translate function for them. removed the call for get names for performance, since those never change.

- Made the SettingsData connection, standard in the VSettings class.

    • -201
    • +75
    ./pretreatment/create/PreTreatmentCreate.qml
  1. … 17 more files in changeset.
DEN-13966 Improvement: Export individual log files

- Added the export progress for each exporting file.

    • -18
    • +10
    ./settings/SettingsExportLogs.qml
  1. … 4 more files in changeset.
DEN-13966 Improvement: Export individual log files

- Used the stashed file copy by by chunk algorithm which I wrote before for exporting the log files.

- It will help later to have more control over copying files.

- Added all the signal/slots for Logger, ApplicationController, GuiController, GuiView and the QML side.

- Implemented the Export Selection Map on the C++ side to be used for individual log file selection (insert, delete, select, remove/Clear).

- Added percent update for the current exporting file. (not implemented on UI, due to some issues)

    • -10
    • +25
    ./settings/SettingsExportLogs.qml
  1. … 18 more files in changeset.
DEN-13966: Improvement: Export individual log files

DEN-14044: IMP:

- Adding the type GuiStringIndexMap=QMap<quint32, QString> to the signal/slot system.

  1. … 10 more files in changeset.
DEN-13966: Improvement: Export individual log files

DEN-14044 - implemented the UI part and the C++ backend list property.

    • -27
    • +64
    ./settings/SettingsExportLogs.qml
  1. … 4 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    ./endtreatment/EndTreatmentEndStack.qml
  1. … 21 more files in changeset.
Merge branch 'DEN-13965-UI-BN-S80' into staging

  1. … 12 more files in changeset.
DEN-13939: IMP: Fixed the merge issue

- Not sure why git didn't get the changes on the ModalDialog's Norification changes to NotificationSmall, and caused the issue on the property IconVisible.

  1. … 3 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    ./posttreatment/PostTreatmentReview.qml
    • -1
    • +1
    ./pretreatment/create/PreTreatmentCreateStack.qml
    • -1
    • +1
    ./settings/SettingsVolumeBrightness.qml
  1. … 83 more files in changeset.
Merge branch 'DEN-13198-UI_BN_75' into staging

    • -1
    • +2
    ./posttreatment/PostTreatmentReview.qml
    • -5
    • +177
    ./pretreatment/create/PreTreatmentCreate.qml
    • -0
    • +1
    ./pretreatment/create/PreTreatmentCreateStack.qml
    • -23
    • +154
    ./settings/SettingsExportLogs.qml
  1. … 37 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -2
    • +2
    ./endtreatment/rinseback/EndTreatmentRinsebackComplete.qml
    • -1
    • +1
    ./posttreatment/PostTreatmentReview.qml
    • -1
    • +1
    ./posttreatment/PostTreatmentStack.qml
    • -1
    • +1
    ./pretreatment/PreTreatmentPrimeStack.qml
    • -1
    • +1
    ./pretreatment/create/PreTreatmentCreateStack.qml
  1. … 86 more files in changeset.
Merge branch 'Build_Issue_Merging__DEN-12716-UI_BN_S70__to__staging' into develop

  1. … 1 more file in changeset.
DEN-12640: UI: Pressure readings on blood prime / rinseback

- Added bottom line separators.

  1. … 1 more file in changeset.
DEN-12640: UI: Pressure readings on blood prime / rinseback

- The In-Line Blood Pressure monitor (ILBPM) has been added to the Rinseback and blood prime screen.

- It has been requested to place the ILBPM, at same place on all three screens (Main Treatment is the third one), but on the rinseback screen we don't have space for that. So it has been moved to top/left (it was buttom/left) and swapped with the FLOWS section.

- It needs to be negotiated with the team to make sure everyone agrees.

    • -0
    • +18
    ./treatment/TreatmentBloodPrime.qml
  1. … 1 more file in changeset.