pages

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Code Review [ UI-DEN-14294-1 ]

Addressing the code review comments

- UI-DEN-14294-1

- UI-DEN-14294-UI BN S84

- UI-DEN-14294-UI-BN-S84

- UI-DEN-14294-UI_BN_S84

  1. … 1 more file in changeset.
RESOLVED.

RESOLVED.

Seems like as part of modern C++ the equal operator is no longer needed. I need to investigate more to completely remove it.

Seems like as part of modern C++ the equal operator is no longer needed.
I need to investigate more to completely remove it.

This function is a slot to debug the behavior of the power dialog for now The entire qml file may later be removed. We had some conversations to combine the power message into confirmation and remo...

This function is a slot to debug the behavior of the power dialog for now
The entire qml file may later be removed.
We had some conversations to combine the power message into confirmation and remove the power qml, models, and so on.

The body of this function looks all commented out. Is this function necessary?

The body of this function looks all commented out. Is this function necessary?

Why commented out?

Why commented out?

Align function bodies.

Align function bodies.

Align "=".

Align "=".

UI-DEN-14294_UI BN S84
UI-DEN-14294_UI BN S84
DEN-14391: Qt 5.15.10

- Fixed the issue with the individual export file selection.

  1. … 1 more file in changeset.
DEN-14391 , DEN-14393 : Qt 5.15.10 [QML run-time issues]

- Fixed all the QML warning and errors

- Enabled the Clang-Tidy, Clazy and cppcheck and fixed some.

- Removed unused images

- made the Denali POST logo transparent.

    • -5
    • +5
    ./endtreatment/EndTreatmentEndStack.qml
    • -8
    • +8
    ./endtreatment/EndTreatmentRecirculateStack.qml
    • -22
    • +26
    ./endtreatment/EndTreatmentRinsebackStack.qml
    • -22
    • +22
    ./posttreatment/PostTreatmentStack.qml
    • -6
    • +6
    ./pretreatment/PreTreatmentConsumablesStack.qml
    • -4
    • +4
    ./pretreatment/PreTreatmentDisposablesStack.qml
    • -31
    • +31
    ./pretreatment/PreTreatmentPrimeStack.qml
    • -5
    • +5
    ./pretreatment/PreTreatmentWaterSampleStack.qml
    • -12
    • +12
    ./pretreatment/connection/PreTreatmentConnectionStack.qml
    • -11
    • +11
    ./pretreatment/create/PreTreatmentCreateStack.qml
  1. … 42 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    ./treatment/TreatmentUltrafiltrationItem.qml
    • -1
    • +1
    ./treatment/adjustments/TreatmentAdjustmentPressuresLimits.qml
  1. … 26 more files in changeset.
Merge branch 'DEN-14147-UI-BN-S82' into staging

  1. … 4 more files in changeset.
Merge branch 'DEN-13962-UI-BN-S82' into staging

  1. … 8 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

removed spaces.

removed spaces.

to align arterial(8 characters) and venous(6 characters) vertically, and to make it easier to compare the variables, to avoid missing a parameter.

to align arterial(8 characters) and venous(6 characters) vertically, and to make it easier to compare the variables, to avoid missing a parameter.

Why is there 2 spaces between . and field name?

Why is there 2 spaces between . and field name?

DEN-14239: Pressure monitor screen not displayed

- During the system tests, it has been observed the main treatment in-line blood pressure is not correctly setting the lower/higher bounds of the monitoring component.

  1. … 1 more file in changeset.
UI-DEN-14147_UI BN S82
UI-DEN-14147_UI BN S82
Merge branch 'DEN-14147-UI-BN-S82' into develop

DEN-14147: Add Required Heparin Volume for Treatment to Syringe Installation Screen

- Fixed isDevice in the export log.