Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-13966: Improvement: Export individual log files

Simplified the log:

- Removed completely the Data type and defined only one type of AppED (AKA APPED, Application, log).

- therefore there is no E, or D, in the log anymore.

- added a log header for the debug type as well.

- added cppcheck to normal build process on each local build for debug and release.

  1. … 22 more files in changeset.
UI-DEN-13965: UI-DEN-13965-3

- Handling the case a new alarm is received, while a confirm is requested, UI should send a cancel to HD and close the dialog and have user to re-issue the confirm if needed.

  1. … 5 more files in changeset.
DEN-13965: UI/HD Generic User Confirmation [Message Mapping]]

- having issue changing the caption by isRejected, disabled for now.

DEN-13965: UI/HD Generic User Confirmation [Message Mapping]]

- Did some fixes for the auto close when rejected or when power-off.

- Some fixes to display and differ from confirm and power-off

  1. … 4 more files in changeset.
DEN-13965: UI/HD Generic User Confirmation [Message Mapping]]

- Fixed the save issue.

  1. … 3 more files in changeset.
DEN-13965: UI/HD Generic User Confirmation [Message Mapping]]

- Fixed the issue with the kyeValue of different categories overwriting by adding the category as the top level.

- I still have issue in saving for the settings, which writes duplicate.

  1. … 9 more files in changeset.
DEN-13965: UI/HD Generic User Confirmation [Message Mapping]]

- Code preparation for the implementation.

  1. … 4 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 25 more files in changeset.
Merge branch 'DEN-13965-UI-BN-S80' into staging

  1. … 11 more files in changeset.
Merge branch 'DEN-13965-UI-BN-S80' into develop

  1. … 8 more files in changeset.
DEN-13939: IMP: Implementation of the the message [0xBB00]

  1. … 5 more files in changeset.
DEN-13939: IMP: Implementation of the the message [0xBA00]

Messaging:

- Modified the message 0xBB00 required length from 3xU32 to 2xU32

- Renamed the VConfrimDialog to VConfirm, since the view class is not the actual dialog implementation.

- Merged the vPowerOff view to the VConfrim, and removed the VPowerOff view classes.

Alarm Integration:

- AlarmItem: add the hasAlarm to theAlarmMinimize as well to prevent the AlarmBar being visible when there is no active alarm.

- VAlarmStatus: fixed the issue with the hasAlarm property which was causing the AlarmDialog being visible while there was not active alarm.

Confirm Dialog:

- Used the PowerItem.qml and the PowerOff Dialog for Generic Confirm, and improved the code to be repurposed.

- Footer: updated the Footer component to be able to re-layout the touchrects without an open/close cycle.

- TouchRect: exposed the the buttons text.

    • -0
    • +107
    ./confirm/VConfirm.cpp
    • -0
    • +69
    ./confirm/VConfirm.h
  1. … 12 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    ./hd/adjustment/common/VCommonAdjustmentVitals.h
  1. … 81 more files in changeset.
Merge branch 'DEN-13198-UI_BN_75' into staging

    • -0
    • +6
    ./hd/adjustment/common/VCommonAdjustmentVitals.h
  1. … 41 more files in changeset.
DEN-13939: IMP: Implementation of the the message [0xBA00]

- The Model/View are implemented and exposed to QML.

    • -0
    • +46
    ./confirm/VConfirmDialog.cpp
    • -0
    • +56
    ./confirm/VConfirmDialog.h
  1. … 13 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    ./hd/adjustment/common/VCommonAdjustmentVitals.h
    • -3
    • +3
    ./settings/VAdjustmentServiceDates.cpp
  1. … 86 more files in changeset.
DEN-13845: CRV: Merge issue of DEN-12716-UI_BN_S70 into staging

- Due to some enum changes, UI couldn't build

- An idea implemented to detect the enum changes by compiler. The implementation may be able to improve.

  1. … 8 more files in changeset.
DEN-13736: Disinfection demo

- Some changes has been made to UI to able to navigate to the home while on disinfection.

- CloudSync disabled by default.

  1. … 5 more files in changeset.
DEN-13645: IMP: DEN9297: Disinfection implementation [ Disinfection Messages ] [0x9A]

- After my initial code review and looking into other messages, UI should never define a bool in any request message, and it has to be quint32 and an enum Options passing to that.

- Therefore the code has been fixed and cleaned up.

  1. … 1 more file in changeset.
DEN-13645: IMP: DEN9297: Disinfection implementation [ Disinfection Messages ] [0x9B]

- Implemented the disinfection mode response

  1. … 10 more files in changeset.
DEN-13645: IMP: DEN9297: Disinfection implementation [ Disinfection Messages ] [0x80]

- Renamed the disinfection start response

  1. … 4 more files in changeset.
DEN-13645: IMP: DEN9297: Disinfection implementation [ Disinfection Messages ] [0x9A]

- Implemented the Disinfection Mode Request message.

  1. … 9 more files in changeset.
DEN-13645: IMP: DEN9297: Disinfection implementation [ Disinfection Messages ] [0x7F,0x80]

- Cleaned up / refactor the messages [ 127 (0x7F), 128 (0x80) ]

  1. … 15 more files in changeset.
DEN-13645: IMP: Updated the Blood Prime message [0x5900]

- It has 3 parameters (UI expected) but recently changed on the FW and sending only 2 which then UI rejects it. now updated to have only 3.

  1. … 4 more files in changeset.
DEN-13645: IMP: Disinfection Remove unused data messages [0x7E00]

- Removed

0x7E00 126 0x040 1 Hz N HD All Standby (disinfect) State "sub-mode (U32-enum) {

0-Flush, (No Flush State required for this state)

1-Heat Disinfect,

2-Chem Disinfect }" (U32) Flush State (U32) Heat Disinfect State (U32) Chem Disinfect State

    • -86
    • +0
    ./dg/data/disinfect/VDisinfectStatesData.h
  1. … 9 more files in changeset.
DEN-13645: IMP: Disinfection Remove unused data messages [0x8100]

- Removed

0x8100 129 0x100 Req Y UI HD Chemical Disinfect User Confirm

  1. … 10 more files in changeset.
DEN-13645: IMP: Disinfection Remove unused data messages [0x8300]

- removed the message:

|0x8300| 131| 0x070| 1 Hz| N| DG| UI| DG Flush Time [each sub state] |(U32) Timeout (secs) (0=no time estimate)| (U32) Timeout countdown (secs)|

    • -62
    • +0
    ./dg/data/disinfect/VDisinfectDGData.cpp
    • -60
    • +0
    ./dg/data/disinfect/VDisinfectDGData.h
  1. … 9 more files in changeset.
DEN-13645: IMP: Unhandled messages duplicate keys fix

- it has been observed that the unhandled messages are not logged correctly and turned out it is because of the Types of each parameter used as keys and keys can't be duplicate by default which caused issue for the unhandled messages, since they may have 6 parameter and all with F32 type which then becomes one parameter of type F32.

- an attribute has been defined for the config file with the format:

#--duplicate_key_on

#--duplicate_key_off

to allow or disallow the duplicate key at any point in the config file.

- Note that the save config parameters are always unique key like AlarmVolume which doesn't make sense to have duplicate entry.

  1. … 9 more files in changeset.
DEN-13645 IMP: DEN-12958: UI shall generate the POST fail alarm if the SD-Card not present and stop logging

__________

- Log Export

- Added the Alarm generation on the GuiController if SD-Card is not ready, or is/becomes read-only.

- AlarmGenerator

- Added the SD-Card failure alarm - ALARM_ID_UI_POST_FAILURE_SDCARD

- Added alarm clear - ALARM_ID_NO_ALARM

- Added a flag to stop logging if the SD-Card is not ready or is readonly.

- Removed pause on log clean up.

- Improved the DeviceController SD-Card, USB status detection.

- Fixed and improved the MVC connection betweein device/Application/Gui controllers.

- A CLI switch ( -S ) added to disable the feature that is disabling the log if the SD-Card doesn't exist. So if the -S switch is used while calling the denali application, the logging will NOT be disabled, if SD-Card fails.

- In the ExportButton and USBButton(eject) removed the enable logic and has to be done outside of the component. It has been done for the Settings/export and Post-Tx/Review.

- Added title and file count for each SD-Card and USB-Drive panels.

__________

- Run.sh

- Added a check for the CloudSync and if the folder doesn't exist it won't do the rest

- Kill the denali application, in case it is still running.

- Added SD-Card type as part of its detection and if it is not ext4 format it fails the test.

- Optimized the mount point detection.

__________

- NoCANBus

- added the NoCANBus to the fault and init modes to not to navigate to those if NoCANBus is true. Otherwise it conflict with navigate to the home.

- Added a log in case the NoCANBus is enabled.

__________

- Settings

- Converted the '\n' in the settings values to actual newline character.

__________

- Thread:

- Moved the QuiController in its own thread, _Gui_Thread.

__________

- Alarms

- Added an emit to update the Alarm Dialog with the latest title/message, received from Alarms.conf In case there was an alarm before even Alarm.conf is read.

  1. … 26 more files in changeset.
DEN-13489 IMP: General Implementation

DEN-13035: Update alarm body messages

- Removed the exclamation mark icon form the Alarm Dialog.

- Removed the exclamation mark icon form the Alarm Bar.

- Made the whole AlarmDialog title bar doubleClick and diagnostics opener if the alarm is not minimizable.

- Moved the Alarm ID from title to the bottom left of the dialog with format: "ID:<id>".

- Clipped the AlarmDialon body message area, crop the text if longer than dialog area.

- Changed the "settings" property name of the VSettings to "instructions".

- Changed the date/time formats keys to simplify the code and conf file.

- Implemented the Alarm Body messages, to load from Alams/Alarms.conf, instead of the FW.

- The FW texts/documents will still being used if the Alarms.conf doesn't have a definition.

- A instruction base capability has also been added to the MVC, but UI still not supporting it.

  1. … 15 more files in changeset.