application

sources

Clone Tools

Stats

Commits this week: 8
Total Committers: 14
Last Commit: 03 Apr
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 04 Mar 2022
12:15 am

Behrouz NematiPour

UI-DEN-12182: UI-DEN-12182-2

- During code review of my code, cleaned up the code.

Options
    • -1
    • +2
    ./canbus/MessageInterpreter.cpp
    • -1
    • +0
    ./cloudsync/CloudSyncController.h
    • -2
    • +0
    ./device/DeviceController.cpp
    • -2
    • +0
    ./device/DeviceModels.cpp
    • -2
    • +2
    ./device/DeviceModels.h
    • -1
    • +1
    ./gui/qml/dialogs/NotificationDialog.qml
    • -4
    • +4
    ./view/hd/adjustment/pretreatment/VPreTreatmentAdjustmentDisposablesConfirm.cpp
Thursday 03 Mar 2022
11:34 pm

Behrouz NematiPour

11:30 pm

Behrouz NematiPour

remove the empty line. lower the column alignment spaces.

remove the empty line.
lower the column alignment spaces.

11:29 pm

Behrouz NematiPour

please align & empty line

please align
& empty line

11:28 pm

Behrouz NematiPour

Please align remove the empty line.

Please align
remove the empty line.

11:27 pm

Behrouz NematiPour

remove empty

remove empty

11:26 pm

Behrouz NematiPour

remove empty line.

remove empty line.

11:25 pm

Behrouz NematiPour

Remove empty line.

Remove empty line.

11:22 pm

Behrouz NematiPour

remove Data, and fix infoText in doc.

remove Data, and fix infoText in doc.

11:20 pm

Behrouz NematiPour

Fix #9 to #10

Fix #9 to #10

11:19 pm

Behrouz NematiPour

remove Data, and fix infoText in doc.

remove Data, and fix infoText in doc.

11:19 pm

Behrouz NematiPour

fix the Src, and CAN ID.

fix the Src, and CAN ID.

11:17 pm

Behrouz NematiPour

Fix the Src, Should be HD. *Fix the CAN ID, should be 0x040
  • Fix the Src, Should be HD.
  • Fix the CAN ID, should be 0x040
11:14 pm

Behrouz NematiPour

the "Data" is redundant. in the log, there is a section for the type if is data will be ",D," Please, update all the other models and the "| infoText|" in the header documents as well.

the "Data" is redundant.
in the log, there is a section for the type if is data will be ",D,"
Please, update all the other models and the "| infoText|" in the header documents as well.

11:10 pm

Behrouz NematiPour

There is a comment in the model. I that changes please don't forget to fix this as well.

There is a comment in the model.
I that changes please don't forget to fix this as well.

11:09 pm

Behrouz NematiPour

This seems a big type for just a boolean value to me. Please check the FW code as well.

This seems a big type for just a boolean value to me.
Please check the FW code as well.

11:02 pm

Behrouz NematiPour

remove the empty line.

remove the empty line.

11:00 pm

Behrouz NematiPour

Don't see why the CRev is necessary? Also, formatting doesn't make sense to me. fpgaID is in between HD and FPGA versions !!! I think it should be like: v<hdMajor(%1)>.<hdMinor(%2)>.<hdMicro(%3)>...

Don't see why the CRev is necessary?

Also, formatting doesn't make sense to me.
fpgaID is in between HD and FPGA versions !!!

I think it should be like:
v<hdMajor(%1)>.<hdMinor(%2)>.<hdMicro(%3)>.<hdBuild(%4)><' '>v<fpgaID(%5)>.<fpgaMajor(%6)>.<fpgaMinor(%7)>.<fpgaLab(%8)><' - '><compRev(%9)>

or move the fpgaID at the end of the FPGA versions.

7:20 pm

Behrouz NematiPour

The message is a U16 and each valve is a bit, and it's not clear to me why the type has been changed from bool to a very big uint32 type? Although it was defined as boolean, qml was showing it as a...

The message is a U16 and each valve is a bit, and it's not clear to me why the type has been changed from bool to a very big uint32 type?
Although it was defined as boolean, qml was showing it as an int value, so what are we going to achieve here?

7:11 pm

Behrouz NematiPour

HD Accelerometer is not being used anymore? If so we should put a TODO comment to remove the model/view later to keep the Application lighter.

HD Accelerometer is not being used anymore?
If so we should put a TODO comment to remove the model/view later to keep the Application lighter.

7:11 pm

Behrouz NematiPour

DG Accelerometer is not being used anymore? If so we should put a TODO comment to remove the model/view later to keep the Application lighter.

DG Accelerometer is not being used anymore?
If so we should put a TODO comment to remove the model/view later to keep the Application lighter.

7:09 pm

Behrouz NematiPour

please remove the empty line.

please remove the empty line.

7:08 pm

Behrouz NematiPour

Please remove the extra empty line.

Please remove the extra empty line.

7:07 pm

Behrouz NematiPour

Same as hd version please consult with the users of this information.

Same as hd version
please consult with the users of this information.

6:23 pm

Behrouz NematiPour

RESOLVED. The Application will not use that new parameter though.

RESOLVED.
The Application will not use that new parameter though.

6:20 pm

Michael Garthwaite

6:20 pm

Behrouz NematiPour

DEN-10153: Treatment Log Comments Investigations

- Fixed the Treatment Review overlapped items.

Options
    • -9
    • +20
    ./gui/qml/pages/posttreatment/PostTreatmentReview.qml
    • -4
    • +4
    ./model/hd/alarm/MAlarmMapping.cpp
  3. … 2 more files in changeset.
5:16 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -3
    • +3
    ./model/hd/alarm/MAlarmMapping.cpp
4:55 pm

Sean Nash

Let's keep it.

Let's keep it.

2:46 pm

Dara Navaei

Bamboo Commit: Updated MAlarmMapping.cpp

Options
    • -1
    • +1
    ./model/hd/alarm/MAlarmMapping.cpp