sources

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-12262: INT: Code reviews wrap up & support

- Addressed all the code review comments in another branch in here to facilitate the code review process and make the code ready while the actual code owner were busy supporting system for demo.

- Added another condition to the Alarm top/right countdown to hide the timer when FW is not even in the Treatment mode by the HDOpMode.

    • -78
    • +88
    ./gui/qml/dialogs/DiagnosticsDialog.qml
    • -0
    • +6
    ./model/dg/data/MDGAccelerometerData.cpp
    • -0
    • +6
    ./model/dg/data/MDGAccelerometerData.h
    • -0
    • +6
    ./model/hd/data/MHDAccelerometerData.cpp
    • -0
    • +6
    ./model/hd/data/MHDAccelerometerData.h
    • -16
    • +16
    ./model/hd/data/MHDBloodLeakData.h
  1. … 18 more files in changeset.
DEN-12262: INT: Code reviews wrap up & support

- Addressed all the code review comments in another branch in here to facilitate the code review process and make the code ready while the actual code owner were busy supporting system for demo.

- Added another condition to the Alarm top/right countdown to hide the timer when FW is not even in the Treatment mode by the HDOpMode.

    • -78
    • +88
    ./gui/qml/dialogs/DiagnosticsDialog.qml
    • -0
    • +6
    ./model/dg/data/MDGAccelerometerData.cpp
    • -0
    • +6
    ./model/dg/data/MDGAccelerometerData.h
    • -0
    • +6
    ./model/hd/data/MHDAccelerometerData.cpp
    • -0
    • +6
    ./model/hd/data/MHDAccelerometerData.h
    • -16
    • +16
    ./model/hd/data/MHDBloodLeakData.h
  1. … 19 more files in changeset.
Bamboo Commit: Updated MAlarmMapping.cpp

Merge branch 'DEN-12258-UI-BN-S66' into develop

- merge conflict resolution.

  1. … 2 more files in changeset.
DEN-12262: INT: Log Dialin Messages

- Log Dialin messages as part of the unhandled messages.

    • -6
    • +6
    ./model/dg/data/MDGAccelerometerData.h
    • -6
    • +6
    ./model/dg/data/post/MDGPostFinalResultData.h
    • -6
    • +6
    ./model/dg/data/post/MDGPostSingleResultData.h
    • -6
    • +6
    ./model/hd/data/MHDAccelerometerData.h
    • -6
    • +6
    ./model/hd/data/post/MHDPostFinalResultData.h
    • -3
    • +3
    ./model/hd/data/post/MHDPostSingleResultData.h
  1. … 2 more files in changeset.
DEN-12262: INT: FW Support (Reset Diagnostic Data)

- Reorganized the Diagnostics screen a little more.

    • -3
    • +6
    ./gui/qml/components/DebugDataColumn.qml
    • -51
    • +57
    ./gui/qml/dialogs/DiagnosticsDialog.qml
  1. … 1 more file in changeset.
DEN-12262: INT: FW Support (Reset Diagnostic Data)

- Fixed HD version title.

    • -19
    • +19
    ./gui/qml/dialogs/DiagnosticsDialog.qml
DEN-12262: INT: FW Support (Reset Diagnostic Data)

- Fixed HD version title.

    • -19
    • +19
    ./gui/qml/dialogs/DiagnosticsDialog.qml
Merge branch 'DEN-12258-UI-BN-S66' into develop

  1. … 2 more files in changeset.
DEN-12262: INT: FW Support (Reset Diagnostic Data)

    • -1
    • +2
    ./gui/qml/components/DebugDataColumn.qml
    • -106
    • +120
    ./gui/qml/dialogs/DiagnosticsDialog.qml
    • -11
    • +11
    ./model/hd/alarm/MAlarmMapping.cpp
    • -0
    • +101
    ./view/VGeneralEvent.cpp
    • -0
    • +84
    ./view/VGeneralEvent.h
  1. … 3 more files in changeset.
Bamboo Commit: Updated MAlarmMapping.cpp

Merge branch 'DEN-12182-ui_dev-sprint-65' into develop

UI-DEN-12182: UI-DEN-12182-2

- During code review of my code, cleaned up the code.

    • -1
    • +1
    ./gui/qml/dialogs/NotificationDialog.qml
remove the empty line. lower the column alignment spaces.

remove the empty line.
lower the column alignment spaces.

please align & empty line

please align
& empty line

Please align remove the empty line.

Please align
remove the empty line.

remove empty

remove empty

remove empty line.

remove empty line.

Remove empty line.

Remove empty line.

remove Data, and fix infoText in doc.

remove Data, and fix infoText in doc.

Fix #9 to #10

Fix #9 to #10

remove Data, and fix infoText in doc.

remove Data, and fix infoText in doc.

fix the Src, and CAN ID.

fix the Src, and CAN ID.

Fix the Src, Should be HD. *Fix the CAN ID, should be 0x040
  • Fix the Src, Should be HD.
  • Fix the CAN ID, should be 0x040
the "Data" is redundant. in the log, there is a section for the type if is data will be ",D," Please, update all the other models and the "| infoText|" in the header documents as well.

the "Data" is redundant.
in the log, there is a section for the type if is data will be ",D,"
Please, update all the other models and the "| infoText|" in the header documents as well.

There is a comment in the model. I that changes please don't forget to fix this as well.

There is a comment in the model.
I that changes please don't forget to fix this as well.

This seems a big type for just a boolean value to me. Please check the FW code as well.

This seems a big type for just a boolean value to me.
Please check the FW code as well.

remove the empty line.

remove the empty line.