application

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit: 20 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 28 Aug 2020
12:09 pm

Peter Lucia <plucia@diality.com>

DEN-3605: Addressed code review comments

Options
    • -2
    • +0
    /sources/applicationcontroller.h
    • -3
    • +0
    /sources/view/VCreateTreatment.cpp
    • -2
    • +0
    /sources/view/VCreateTreatment.h
    • -3
    • +0
    /sources/view/vview.h
    • -2
    • +0
    /unittests/tst_messaging.h
    • -2
    • +0
    /unittests/tst_models.cpp
    • -1
    • +0
    /unittests/tst_views.cpp
11:30 am

Peter Lucia <plucia@diality.com>

DEN-3605: Made requested changes from code review

Options
    • -24
    • +24
    /denali.pro.user
    • -2
    • +2
    /scripts/copy.sh
    • -1
    • +0
    /sources/canbus/messageglobals.h
    • -1
    • +0
    /sources/canbus/messageinterpreter.h
    • -2
    • +0
    /sources/gui/guicontroller.h
    • -2
    • +2
    /sources/gui/qml/components/TopMenuBarCreateTreatment.qml
    • -1
    • +0
    /sources/gui/qml/main.qml
    • -5
    • +5
    /sources/gui/qml/pages/treatment/TreatmentBegin.qml
    • -5
    • +5
    /sources/gui/qml/pages/treatment/TreatmentConfirm.qml
    • -5
    • +5
    /sources/gui/qml/pages/treatment/TreatmentCreate.qml
    • -5
    • +5
    /sources/gui/qml/pages/treatment/TreatmentPrime.qml
    • -8
    • +8
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -2
    • +0
    /sources/model/mtreatmentparameters.h
    • -1
    • +0
    /sources/storage/filehandler.h
    • -1
    • +0
    /sources/storage/filesaver.h
    • -1
    • +0
    /sources/storage/storageglobals.h
    • -65
    • +36
    /sources/view/VCreateTreatment.cpp
Wednesday 26 Aug 2020
10:34 pm

Behrouz NematiPour

DEN-4690: Doxygenization

- Fixed a code typo

Options
    • -1
    • +1
    /sources/canbus/MessageGlobals.h
    • -3
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustBloodDialysateResponse.cpp
    • -2
    • +2
    /sources/model/hd/adjustment/MTreatmentAdjustBloodDialysateResponse.h
    • -4
    • +4
    /sources/view/hd/adjustment/VTreatmentAdjustmentFlows.cpp
    • -5
    • +5
    /unittests/tst_models.cpp
10:25 pm

Behrouz NematiPour

DEN-4690: Doxygenization

- Doxygenization

- File Names Camel Case

- Spell Checks

Options
    • -67
    • +68
    /denali.pro
    • -2
    • +2
    /denali.pro.user
    • -9
    • +9
    /main.cpp
    • -0
    • +426
    /sources/ApplicationController.cpp
    • -0
    • +106
    /sources/ApplicationController.h
    • -0
    • +38
    /sources/ApplicationPost.cpp
    • -0
    • +30
    /sources/ApplicationPost.h
    • -0
    • +125
    /sources/MainTimer.cpp
    • -0
    • +50
    /sources/MainTimer.h
    • -0
    • +97
    /sources/Threads.cpp
    • -0
    • +41
    /sources/Threads.h
    • -96
    • +0
    /sources/abstract/singleton.h
    • -0
    • +96
    /sources/abstract/singleton.h._
    • -426
    • +0
    /sources/applicationcontroller.cpp
    • -106
    • +0
    /sources/applicationcontroller.h
  16. … 197 more files in changeset.
Tuesday 25 Aug 2020
1:51 pm

Behrouz NematiPour

DEN-4445: Code Review 0

Options
    • -1
    • +1
    /sources/canbus/caninterface.cpp
    • -1
    • +0
    /sources/view/VEventSpy.h
1:33 pm

Behrouz NematiPour

DEN-4445: Code Review 0

Options
    • -2
    • +0
    /sources/applicationcontroller.h
    • -1
    • +1
    /sources/canbus/caninterface.cpp
    • -2
    • +0
    /sources/gui/guicontroller.h
    • -2
    • +0
    /sources/gui/guiglobals.h
    • -1
    • +0
    /sources/gui/guiview.h
    • -1
    • +0
    /sources/model/hd/adjustment/MTreatmentAdjustSalineResponse.h
    • -2
    • +0
    /sources/storage/DriveWatcher.h
    • -1
    • +0
    /sources/storage/filehandler.h
12:58 am

Behrouz NematiPour

EMC Support and SD-Card Notification

Options
    • -5
    • +5
    /denali.pro.user
    • -0
    • +1
    /denali.qrc
    • binary
    /resources/images/microsd.png
    • -2
    • +1
    /scripts/run.sh
    • -0
    • +21
    /sources/applicationcontroller.cpp
    • -0
    • +4
    /sources/applicationcontroller.h
    • -2
    • +24
    /sources/gui/guicontroller.cpp
    • -1
    • +5
    /sources/gui/guicontroller.h
    • -2
    • +22
    /sources/gui/guiview.cpp
    • -3
    • +13
    /sources/gui/guiview.h
    • -0
    • +18
    /sources/gui/qml/main.qml
    • -5
    • +5
    /sources/gui/qml/pages/ManagerHome.qml
    • -15
    • +0
    /sources/gui/qml/pages/SettingsHome.qml
    • -14
    • +21
    /sources/storage/DriveWatcher.cpp
    • -4
    • +4
    /sources/storage/DriveWatcher.h
  16. … 3 more files in changeset.
Sunday 23 Aug 2020
11:13 pm

Behrouz NematiPour

DEN-4445: Code Review 0

Options
    • -1
    • +1
    /sources/model/MAbstract.cpp
    • -1
    • +0
    /sources/view/hd/adjustment/VTreatmentAdjustmentSaline.h
    • -1
    • +0
    /sources/view/hd/data/VTreatmentSalineData.h
    • -1
    • +0
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.h
    • -2
    • +0
    /unittests/tst_messaging.cpp
8:27 pm

Behrouz NematiPour

Merge branch 'EMC_Support_CombineDebugScreens' into DEN-4438_SalineBolus

Options
1:37 pm

Behrouz NematiPour

EMC Support - Code Coverage / Integration Testing

Options
    • -9
    • +9
    /denali.pro.user
    • -1
    • +1
    /sources/storage/filehandler.cpp
    • -1
    • +20
    /sources/view/VEventSpy.cpp
    • -1
    • +3
    /sources/view/VEventSpy.h
2:34 am

Behrouz NematiPour

EMC Support

Options
    • -0
    • +2
    /denali.pro
    • -19
    • +1
    /denali.pro.user
    • -0
    • +1
    /denali.qrc
    • -2
    • +5
    /sources/canbus/caninterface.cpp
    • -1
    • +2
    /sources/canbus/frameinterface.cpp
    • -9
    • +15
    /sources/gui/guiglobals.cpp
    • -1
    • +13
    /sources/gui/guiglobals.h
    • -0
    • +55
    /sources/gui/qml/components/DebugDataColumn.qml
    • -271
    • +204
    /sources/gui/qml/pages/ManagerHome.qml
    • -184
    • +0
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +135
    /sources/view/VEventSpy.cpp
    • -0
    • +61
    /sources/view/VEventSpy.h
Thursday 20 Aug 2020
9:38 pm

Behrouz NematiPour

DEN-3884: Code Review 0

Options
    • -2
    • +2
    /sources/canbus/messageglobals.h
6:13 pm

Behrouz NematiPour

Merge branch 'DEN-3875_Logging_2of3' into DEN-4438_SalineBolus

- DEN-3884: Code Review 0 applied to on going Code Review of Saline Bolus as well.

Options
    • -5
    • +5
    /sources/canbus/messagedispatcher.cpp
    • -6
    • +6
    /sources/canbus/messageglobals.h
    • -14
    • +19
    /sources/canbus/messageinterpreter.cpp
    • -1
    • +1
    /sources/gui/guiglobals.cpp
    • -1
    • +1
    /sources/gui/guiglobals.h
    • -2
    • +0
    /sources/gui/qml/main.qml
    • -2
    • +2
    /sources/model/MAbstract.cpp
    • -1
    • +1
    /sources/model/MModel.h
    • -1
    • +1
    /sources/view/vtreatmentadjustmentresponsebase.h
    • -3
    • +3
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.h
    • -3
    • +0
    /unittests/tst_messaging.h
    • -3
    • +0
    /unittests/tst_models.h
6:05 pm

Behrouz NematiPour

DEN-3884: Code Review 0

- fixed typos

Options
    • -1
    • +1
    /sources/applicationcontroller.h
    • -4
    • +4
    /sources/applicationpost.cpp
    • -1
    • +1
    /sources/canbus/caninterface.cpp
    • -133
    • +133
    /sources/canbus/caninterface.h
    • -5
    • +5
    /sources/canbus/frameinterface.cpp
    • -2
    • +2
    /sources/canbus/messageglobals.h
    • -4
    • +4
    /sources/gui/guicontroller.cpp
    • -1
    • +1
    /sources/gui/guiglobals.cpp
    • -4
    • +4
    /sources/gui/guiglobals.h
    • -6
    • +6
    /sources/gui/guiview.cpp
    • -2
    • +2
    /sources/model/MAbstract.cpp
    • -1
    • +1
    /sources/model/MAbstract.h
    • -1
    • +1
    /sources/model/MDGDebugText.cpp
    • -1
    • +1
    /sources/model/MHDDebugText.cpp
    • -1
    • +1
    /sources/model/MModel.h
  16. … 13 more files in changeset.
3:48 pm

Behrouz NematiPour

DEN-3884: Code Review 0

Options
    • -421
    • +421
    /sources/canbus/caninterface.cpp
    • -1
    • +1
    /sources/canbus/frameinterface.cpp
    • -2
    • +2
    /sources/canbus/messagebuilder.cpp
    • -5
    • +3
    /sources/canbus/messagebuilder.h
    • -5
    • +5
    /sources/canbus/messagedispatcher.cpp
    • -16
    • +16
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +2
    /sources/gui/qml/dialogs/NotificationDialog.qml
    • -15
    • +3
    /sources/gui/qml/pages/ManagerHome.qml
    • -4
    • +5
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -4
    • +4
    /sources/gui/qml/pages/treatment/adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml
    • -3
    • +3
    /sources/storage/logger.cpp
    • -4
    • +4
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.h
    • -4
    • +3
    /unittests/tst_acknow.h
    • -5
    • +3
    /unittests/tst_canbus.h
    • -4
    • +3
    /unittests/tst_initializations.h
  16. … 7 more files in changeset.
Tuesday 18 Aug 2020
5:56 pm

Behrouz NematiPour

DEN-4443: Integration Testing

- Demo feedback was ok with disabling the Treatment Time as well so I add that too.

Options
    • -1
    • +4
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -2
    • +2
    /sources/gui/qml/pages/treatment/sections/TreatmentTime.qml
Monday 17 Aug 2020
10:39 am

Peter Lucia <plucia@diality.com>

Fixed treatment parameter signals, improved code documentation, interpretMessage formatting adjustments.

Options
    • -3
    • +3
    /denali.pro.user
    • -62
    • +70
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +2
    /sources/model/MModel.h
    • -2
    • +3
    /sources/storage/filesaver.cpp
    • -1
    • +1
    /sources/view/VCreateTreatment.cpp
    • -3
    • +3
    /sources/view/VCreateTreatment.h
Friday 14 Aug 2020
7:31 pm

Peter Lucia <plucia@diality.com>

Improved unit test coverage, added filepath parameter to saveNewTreatment

Options
    • -1
    • +1
    /sources/storage/filesaver.h
    • -3
    • +3
    /sources/view/VCreateTreatment.cpp
    • -1
    • +1
    /sources/view/VCreateTreatment.h
    • -0
    • +2
    /unittests/tst_messaging.cpp
    • -2
    • +1
    /unittests/tst_messaging.h
    • -5
    • +36
    /unittests/tst_views.cpp
4:48 pm

Peter Lucia <plucia@diality.com>

Updated unit tests, fixed arterial and venous conversions to signed int.

Options
    • -3
    • +3
    /denali.pro.user
    • -4
    • +4
    /sources/model/mtreatmentparameters.cpp
    • -0
    • +1
    /sources/view/VCreateTreatment.cpp
    • -0
    • +6
    /unittests/tst_messaging.cpp
    • -61
    • +189
    /unittests/tst_models.cpp
    • -0
    • +1
    /unittests/tst_models.h
    • -1
    • +155
    /unittests/tst_views.cpp
    • -0
    • +1
    /unittests/tst_views.h
1:24 pm

Peter Lucia <plucia@diality.com>

Added unit test for treatment parameters response data's fromVariantList

Options
    • -0
    • +55
    /unittests/tst_models.cpp
    • -0
    • +1
    /unittests/tst_models.h
11:07 am

Peter Lucia <plucia@diality.com>

Fixed treatment parameter data lengths and error indices

Options
    • -17
    • +38
    /unittests/tst_models.cpp
11:01 am

Peter Lucia <plucia@diality.com>

Updated unit tests. Fixed treatment parameter length check and made arterial and venous ints signed instead of unsigned.

Options
    • -2
    • +3
    /sources/model/mtreatmentparameters.cpp
    • -4
    • +4
    /sources/view/VCreateTreatment.h
    • -2
    • +80
    /unittests/tst_models.cpp
    • -0
    • +4
    /unittests/tst_models.h
    • -0
    • +23
    /unittests/tst_views.cpp
    • -1
    • +0
    /unittests/tst_views.h
Thursday 13 Aug 2020
11:53 pm

Behrouz NematiPour

DEN-4443: Integration Testing

Options
    • -1
    • +1
    /denali.pro.user
    • -2
    • +5
    /sources/gui/qml/pages/treatment/sections/TreatmentUltrafiltration.qml
8:18 pm

Behrouz NematiPour

DEN-4502: Static Code Analysis

Options
    • -5
    • +54
    /cppcheck.err
    • -56
    • +252
    /cppcheck.log
7:38 pm

Behrouz NematiPour

DEN-4441: Implementation

- Implemented the SRSUI 256: Restrictions - Max Delivered

Options
    • -1
    • +1
    /denali.pro.user
    • -2
    • +3
    /sources/gui/guiglobals.h
    • -1
    • +1
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -1
    • +4
    /sources/gui/qml/pages/treatment/sections/TreatmentFluid.qml
    • -7
    • +19
    /sources/gui/qml/pages/treatment/sections/TreatmentSaline.qml
    • -1
    • +2
    /sources/view/hd/adjustment/VTreatmentAdjustmentSaline.cpp
    • -0
    • +1
    /sources/view/hd/adjustment/VTreatmentAdjustmentSaline.h
4:51 pm

Peter Lucia <plucia@diality.com>

Moved == operator to uni ttests & updated views unit test. Added CreateTreatmentReq case to interpretMessage

Options
    • -0
    • +11
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +50
    /sources/model/mtreatmentparameters.cpp
    • -22
    • +5
    /sources/model/mtreatmentparameters.h
    • -1
    • +17
    /unittests/tst_views.cpp
1:59 pm

Peter Lucia <plucia@diality.com>

Updated unit tests: CSV, message interpreter. Added ability to save treatment parameter ranges to CSV

Options
    • -6
    • +8
    /sources/storage/storageglobals.cpp
    • -3
    • +4
    /sources/storage/storageglobals.h
    • -0
    • +57
    /sources/view/VCreateTreatment.cpp
    • -0
    • +2
    /sources/view/VCreateTreatment.h
    • -1
    • +17
    /unittests/tst_messaging.cpp
    • -1
    • +2
    /unittests/tst_messaging.h
    • -0
    • +17
    /unittests/tst_views.cpp
    • -1
    • +3
    /unittests/tst_views.h
12:02 pm

Peter Lucia <plucia@diality.com>

Updated unit tests, improved code testability

Options
    • -0
    • +22
    /sources/model/mtreatmentparameters.h
    • -9
    • +7
    /sources/view/VCreateTreatment.cpp
    • -2
    • +2
    /sources/view/VCreateTreatment.h
    • -32
    • +215
    /unittests/tst_views.cpp
    • -0
    • +3
    /unittests/tst_views.h
1:56 am

Behrouz NematiPour

DEN-4441: Implementation/Ultrafiltration

- Also did the :

- DEN-4442: Unit Testing

- DEN-4443: Integration Testing

- DEN-4444: Code Coverage

Options
    • -42
    • +50
    /denali.pro
    • -3
    • +3
    /denali.pro.user
    • -2
    • +6
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +1
    /sources/gui/guiglobals.cpp
    • -3
    • +15
    /sources/gui/guiglobals.h
    • -1
    • +18
    /sources/gui/qml/components/NotificationBarSmall.qml
    • -2
    • +8
    /sources/gui/qml/pages/treatment/TreatmentStack.qml
    • -13
    • +11
    /sources/gui/qml/pages/treatment/sections/TreatmentFluid.qml
    • -4
    • +4
    /sources/gui/qml/pages/treatment/sections/TreatmentSaline.qml
    • -5
    • +29
    /sources/gui/qml/pages/treatment/sections/TreatmentTime.qml
    • -5
    • +6
    /sources/gui/qml/pages/treatment/sections/TreatmentUltrafiltration.qml
    • -1
    • +3
    /sources/model/hd/adjustment/MTreatmentAdjustUltrafiltrationStateResponse.h
    • -44
    • +0
    /sources/view/VHDOperationModeData.cpp
    • -45
    • +0
    /sources/view/VHDOperationModeData.h
    • -52
    • +0
    /sources/view/VTreatmentAdjustmentSaline.cpp
  16. … 16 more files in changeset.
Wednesday 12 Aug 2020
6:30 pm

Peter Lucia <plucia@diality.com>

Added Create Treatment unit tests

Options
    • -59
    • +925
    /denali.pro.user
    • -1
    • +3
    /sources/gui/qml/pages/treatment/TreatmentConfirm.qml
    • -32
    • +37
    /sources/view/VCreateTreatment.cpp
    • -1
    • +7
    /sources/view/VCreateTreatment.h
    • -0
    • +250
    /unittests/tst_views.cpp
    • -0
    • +9
    /unittests/tst_views.h