common

Clone Tools

Stats

Commits this week: 0
Total Committers: 18
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 24 Feb 2022
6:27 pm

Michael Garthwaite

Merge branch 'staging' into DEN-12121-sw_dev-sprint-65-michael-garthwaite

Options
3:36 pm

Michael Garthwaite

Does this need to be memset when we can initialize it with 0'd values above? (line 92)

Does this need to be memset when we can initialize it with 0'd values above? (line 92)

3:33 pm

Michael Garthwaite

Do we need an if for an always true condition? does this branch statement need to be uncommented?

Do we need an if for an always true condition? does this branch statement need to be uncommented?

3:25 pm

Michael Garthwaite

Shouldn't the override check be its own get function like other overidden properties? Ex: getUVReactorHealth() ?

Shouldn't the override check be its own get function like other overidden properties? Ex: getUVReactorHealth() ?

3:17 pm

Michael Garthwaite

I think this alarm should be not commented out.

I think this alarm should be not commented out.

11:29 am

Dara Navaei

Merge branch 'staging' into develop

Options
11:14 am

Dara Navaei

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

Options
    • -9
    • +9
    /AlarmDefs.h
11:14 am

Dara Navaei

DEN-12225 updated the alarm 184 property to make sure HD is not at fault

Options
    • -1
    • +1
    /AlarmDefs.h
Wednesday 23 Feb 2022
8:20 pm

Dara Navaei

Merge branch 'staging' into develop

Options
4:40 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated alarms properties

Options
    • -6
    • +6
    /AlarmDefs.h
2:52 pm

Hung Nguyen <hnguyen@diality.com>

Merge branch 'staging' of ssh://dvm-linux02:7999/comm/common into staging

Options
    • -5
    • +5
    /AlarmDefs.h
2:51 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Added states and temperature out of range alarm

Options
    • -3
    • +3
    /AlarmDefs.h
    • -6
    • +8
    /DGDefs.h
12:48 pm

Dara Navaei

Merge branch 'staging' into develop

Options
12:46 pm

Dara Navaei

DEN-12225 updated the UV reactors alarm properties

Options
    • -1
    • +1
    /AlarmDefs.h
Tuesday 22 Feb 2022
5:16 pm

Michael Garthwaite

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

Could we move these fields outside of the for loop? They dont need to be initialized NUM_OF_FANS_NAMES times.

5:13 pm

Michael Garthwaite

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

5:07 pm

Michael Garthwaite

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

5:05 pm

Michael Garthwaite

We should probably keep the = 0;

We should probably keep the = 0;

4:16 pm

Dara Navaei

Merge branch 'staging' into develop

Options
4:01 pm

Dara Navaei

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

Most of the files are VectorCAST that has been brought back from Code Clinic. Look at the files but they are auto generated so they are mostly passing through.

3:57 pm

Michael Garthwaite

Notices the 170 files that need to be reviewed https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

Notices the 170 files that need to be reviewed

https://c.tenor.com/RXMxqsRKEn0AAAAC/this-is-fine.gif

3:47 pm

Dara Navaei

DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
DG-DEN-11750_DG Dev Dialysate Temperature Control Tune Up
3:46 pm

Michael Garthwaite

DEN-12121: msg id for DIAL-147

Options
    • -0
    • +1
    /MsgDefs.h
12:57 pm

Dara Navaei

DEN-11750 updated the alarms table

Options
    • -4
    • +4
    /AlarmDefs.h
    • -0
    • +1
    /MsgDefs.h
11:26 am

Michael Garthwaite

Merge branch 'DEN-11980-sw_dev-sprint-64' into staging

Options
11:26 am

Michael Garthwaite

Merge branch 'staging' into DEN-11980-sw_dev-sprint-64

Options
11:21 am

Michael Garthwaite

11:10 am

Sean Nash , hnguyen  (deleted user) and Dara Navaei

Friday 18 Feb 2022
3:21 pm

Dara Navaei

Thursday 17 Feb 2022
10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.