dd-firmware

Clone Tools

Stats

Commits this week: 33
Total Committers: 17
Last Commit: 01 Jun
Commits this week: 33

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Jun
5:35 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /firmware/App/Controllers/BalancingChamber.c
    • -2
    • +2
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/Heaters.h
    • -1
    • +1
    /firmware/App/Controllers/Ultrafiltration.c
    • -2
    • +2
    /firmware/App/DDCommon.h
    • -1
    • +1
    /firmware/App/Drivers/TemperatureSensors.c
    • -2
    • +2
    /firmware/App/Modes/ModeGenDialysate.c
    • -2
    • +2
    /firmware/App/Monitors/Conductivity.c
    • -2
    • +2
    /firmware/App/Monitors/Temperature.c
    • -1
    • +1
    /firmware/App/Monitors/Temperature.h
5:35 pm

Vinayakam Mani

5:27 pm

Vinayakam Mani

LDT-3958 merge into staging

Options
5:18 pm

Sean Nash and Vendor - TEL - Jashwant Gantyada

4:01 pm

Vinayakam Mani

Done.

Done.

4:01 pm

Vinayakam Mani

Done.

Done.

3:58 pm

Vinayakam Mani

LDT-3958 heater control update

Options
    • -3
    • +5
    /firmware/App/Controllers/BalancingChamber.c
1:57 pm

Michael Garthwaite

LDT-4001: code review comments.

Options
    • -3
    • +3
    /firmware/App/Controllers/SubstitutionPump.c
    • -1
    • +1
    /firmware/App/Services/TDInterface.c
1:47 pm

Vinayakam Mani

Update alarms and Input/Output sections.

Update alarms and Input/Output sections.

1:41 pm

Vinayakam Mani

Also, add option individual parameter override for substitutions pump rate as well.

Also, add option individual parameter override for substitutions pump rate as well.

1:39 pm

Vinayakam Mani

Space after parenthesis. Please add the same in else portion as well (when treatment is in progress, update the rate).

Space after parenthesis. Please add the same in else portion as well (when treatment is in progress, update the rate).

1:37 pm

Michael Garthwaite

LDT-4001: removed implicit call for sub pump monitor

Options
    • -0
    • +1
    /firmware/App/Tasks/TaskPriority.c
1:10 pm

Michael Garthwaite

LDT-4001: updated defines based on requirements

Options
    • -2
    • +2
    /firmware/App/Controllers/SubstitutionPump.c
12:43 pm

Michael Garthwaite

fixed.

fixed.

12:43 pm

Michael Garthwaite

fixed

fixed

12:43 pm

Michael Garthwaite

fixed

fixed

12:43 pm

Michael Garthwaite

fixed

fixed

12:43 pm

Michael Garthwaite

added

added

12:43 pm

Michael Garthwaite

LDT-4001: D92 monitoring and alarms with Hall sensor count now in fpga

Options
    • -5
    • +37
    /firmware/App/Controllers/SubstitutionPump.c
    • -1
    • +1
    /firmware/App/Controllers/SubstitutionPump.h
    • -0
    • +2
    /firmware/App/Services/AlarmMgmtSWFaults.h
    • -1
    • +14
    /firmware/App/Services/FpgaDD.c
    • -1
    • +2
    /firmware/App/Services/FpgaDD.h
    • -0
    • +3
    /firmware/App/Tasks/TaskPriority.c
12:05 pm

Vinayakam Mani

All these are more of debug related overrides (acid and bicarb P & I gain). you can keep them in one function, when the implementation is complete, you may remove these. The init function is too bi...

All these are more of debug related overrides (acid and bicarb P & I gain). you can keep them in one function, when the implementation is complete, you may remove these. The init function is too big, group them and split in the functions and call here.

12:03 pm

Vinayakam Mani

Some of these parameters can be changed over td proxy commands, need not to implement additional overrides.

Some of these parameters can be changed over td proxy commands, need not to implement additional overrides.

12:00 pm

Vinayakam Mani

I guess all these MACRO implementations should move to function/s to compute the final acid and bicarb volume, that would help to calculate the volumes when Na and Bicarb params changed during trea...

I guess all these MACRO implementations should move to function/s to compute the final acid and bicarb volume, that would help to calculate the volumes when Na and Bicarb params changed during treatment.

11:52 am

Vinayakam Mani

looks Bicarb and sodium settings interchanged? There are multiple macros on the same values. remove the duplicates.

looks Bicarb and sodium settings interchanged? There are multiple macros on the same values. remove the duplicates.

11:48 am

Vinayakam Mani

33.0?

33.0?

11:47 am

Vinayakam Mani

Add comment for each macro.

Add comment for each macro.

11:41 am

Vinayakam Mani

For all floats add F at the end, across the file.

For all floats add F at the end, across the file.

11:40 am

Vinayakam Mani

Align the comment

Align the comment

9:20 am

Michael Garthwaite

LDT-4001: code review comments.

Options
    • -5
    • +6
    /firmware/App/Controllers/SubstitutionPump.c
Friday 29 May
6:29 pm

Vinayakam Mani

6:29 pm

Vinayakam Mani

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.