dd-firmware

Clone Tools

Stats

Commits this week: 36
Total Committers: 18
Last Commit: 21 Jul
Commits this week: 36

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 21 Jul
11:41 am

Vendor - TEL - Jashwant Gantyada

LDT-4410 commented temperature alarm for develop branch working

Options
    • -1
    • +2
    /firmware/App/Drivers/TemperatureSensors.c
10:28 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Stepper driver firmware implementation

Options
    • -11
    • +68
    /firmware/App/Controllers/ConcentratePumps.c
    • -10
    • +47
    /firmware/App/Controllers/SubstitutionPump.c
    • -19
    • +19
    /firmware/App/Services/FpgaDD.c
Monday 20 Jul
5:06 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
4:54 pm

Vendor - TEL - Jashwant Gantyada

merged LDT-4410 to develop

Options
    • -120
    • +257
    /firmware/App/Controllers/BalancingChamber.c
    • -59
    • +159
    /firmware/App/Controllers/DryBiCart.c
    • -10
    • +8
    /firmware/App/Controllers/MixingControl.c
    • -2
    • +2
    /firmware/App/Monitors/Conductivity.c
4:39 pm

Vinayakam Mani

Delete it.

Delete it.

4:39 pm

Vendor - TEL - Jashwant Gantyada

LDT-4410 code review comments addressed

Options
    • -48
    • +18
    /firmware/App/Controllers/BalancingChamber.c
    • -2
    • +2
    /firmware/App/Controllers/BalancingChamber.h
    • -1
    • +2
    /firmware/App/Controllers/ConcentratePumps.h
    • -36
    • +32
    /firmware/App/Controllers/DryBiCart.c
    • -7
    • +8
    /firmware/App/Controllers/MixingControl.c
    • -2
    • +2
    /firmware/App/Monitors/Conductivity.c
4:32 pm

Vinayakam Mani

Remove blank spaces after =.

Remove blank spaces after =.

4:31 pm

Vinayakam Mani

To be deleted this line?

To be deleted this line?

4:25 pm

Vinayakam Mani

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after (). Apply the same comment in the next Dialysate delivery state as w...

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after (). Apply the same comment in the next Dialysate delivery state as well.

4:19 pm

Vinayakam Mani

I guess we can remove the "balancingChamberFillInProgress" check here.

I guess we can remove the "balancingChamberFillInProgress" check here.

4:00 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Driver update code part 1

Options
    • -0
    • +7
    /firmware/App/Controllers/ConcentratePumps.c
    • -37
    • +306
    /firmware/App/Services/FpgaDD.c
    • -0
    • +21
    /firmware/App/Services/FpgaDD.h
2:31 pm

Vinayakam Mani

Remove the TODO comment.

Remove the TODO comment.

2:13 pm

Vinayakam Mani

align the comment.

align the comment.

2:08 pm

Vinayakam Mani

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

2:03 pm

Vinayakam Mani

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pre...

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pressure etc.,

2:00 pm

Vinayakam Mani

decays to threshold level (4 PSI).

decays to threshold level (4 PSI).

1:58 pm

Vinayakam Mani

remove all commented code.

remove all commented code.

1:55 pm

Vinayakam Mani

Update comment. remove TODO if no more applicable.

Update comment. remove TODO if no more applicable.

1:54 pm

Vinayakam Mani

FillWaterEndState?

FillWaterEndState?

1:52 pm

Vinayakam Mani

Delete it.

Delete it.

1:52 pm

Vinayakam Mani

Supply state (instead of drain). Updates Inputs and outputs across the file.

Supply state (instead of drain). Updates Inputs and outputs across the file.

1:46 pm

Vinayakam Mani

When the BC fill completed and allow opening D65 for Chamber F fill?

When the BC fill completed and allow opening D65 for Chamber F fill?

1:44 pm

Vinayakam Mani

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

1:42 pm

Vinayakam Mani

50ms?

50ms?

1:37 pm

Vinayakam Mani

Add comment to align with the rest of the implementation.

Add comment to align with the rest of the implementation.

12:27 pm

Vinayakam Mani

Add outputs as well.

Add outputs as well.

12:19 pm

Vinayakam Mani

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

10:33 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
9:36 am

Vendor - TEL - Jashwant Gantyada

LDT-4410 made changes to state machine and cpontrol for conductivity spikes

Options
    • -16
    • +67
    /firmware/App/Controllers/BalancingChamber.c
    • -0
    • +2
    /firmware/App/Controllers/BalancingChamber.h
    • -2
    • +3
    /firmware/App/Controllers/ConcentratePumps.h
    • -34
    • +70
    /firmware/App/Controllers/DryBiCart.c
    • -4
    • +4
    /firmware/App/Controllers/MixingControl.c
    • -3
    • +0
    /firmware/App/DDCommon.h
    • -1
    • +1
    /firmware/App/Modes/ModeGenDialysate.h
4:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5186_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 7/1:
LEAHI-DD-FIRMWARE-LDT-5186_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 7/1: