Activity dd-firmware/firmware/App/Controllers

Tree
Accordion

Stats

Commits this week: 40

Total Committers:	16
Last Commit:	17:13
Commits this week:	40

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 30 Jul

7:12 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

More
6d0f8d5
changed 1 file
LDT-4873-request-add-config-to-disable-c-1, develop

merge conflicts

- -0
- +9
./BalancingChamber.h
- History
- Source
- Diff
./BalancingChamber.h

6:52 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

More
56410a2
changed 2 files
LDT-4873-request-add-config-to-disable-c-1, bugfix/LDT-4500-dd-alarm-75-and-pressure-build-, develop LEAHI-DD-FIRMWARE-LDT-4500-1 LEAHI-DD-FIRMWARE-LDT-4873-2

code review commits

- -1
- +1
./SpentChamberFill.c
- History
- Source
- Diff
./SpentChamberFill.c
… 1 more file in changeset.

6:49 pm

Michael Garthwaite

More
11c6fba
changed 1 file
LDT-4873-request-add-config-to-disable-c-1, LDT-5209-demo-build and 2 more LEAHI-DD-FIRMWARE-LDT-5209-1

LDT-5209: fixes for init fill

- -2
- +2
./DryBiCart.c
- History
- Source
- Diff
./DryBiCart.c

6:44 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

More
cb071d7
changed 3 files
LDT-4873-request-add-config-to-disable-c-1, bugfix/LDT-4500-dd-alarm-75-and-pressure-build-, develop LEAHI-DD-FIRMWARE-LDT-4500-1

staging sync

- -124
- +320
./BalancingChamber.c
- History
- Source
- Diff
./BalancingChamber.c
- -1
- +14
./BalancingChamber.h
- History
- Source
- Diff
./BalancingChamber.h
… 1 more file in changeset.

2:52 pm

Michael Garthwaite

More
9ce00d3
changed 1 file
LDT-4873-request-add-config-to-disable-c-1, develop

Merge branch 'LDT-5209-pre-treatment' into develop

- -1
- +1
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

2:48 pm

Michael Garthwaite

More
223f913
changed 1 file
LDT-4873-request-add-config-to-disable-c-1, LDT-5209-demo-build and 2 more LEAHI-DD-FIRMWARE-LDT-5209-1 LEAHI-DD-FIRMWARE-LDT-5209-2 LEAHI-DD-FIRMWARE-LDT-4873-2

LDT-5209: reverted micro step change

- -1
- +1
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

2:47 pm

Michael Garthwaite

More
c897df5
changed 1 file
LDT-4873-request-add-config-to-disable-c-1, LDT-5209-demo-build and 2 more

LDT-5209: micro step change concentrate

- -1
- +1
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

2:01 pm

Michael Garthwaite

More
8476599
changed 6 files
LDT-4873-request-add-config-to-disable-c-1, develop LEAHI-DD-FIRMWARE-LDT-4873-2

Merge branch 'LDT-5209-pre-treatment' into develop

- -1
- +1
./BalancingChamber.h
- History
- Source
- Diff
./BalancingChamber.h
- -6
- +413
./DryBiCart.c
- History
- Source
- Diff
./DryBiCart.c
- -2
- +2
./MixingControl.c
- History
- Source
- Diff
./MixingControl.c
- -2
- +2
./MixingControl.h
- History
- Source
- Diff
./MixingControl.h
… 2 more files in changeset.

1:57 pm

Michael Garthwaite

More
6e6e587
changed 2 files
LDT-4873-request-add-config-to-disable-c-1, LDT-5209-demo-build and 2 more LEAHI-DD-FIRMWARE-LDT-5209-1

LDT-5209: fixes for dd priming.

- -1
- +1
./DryBiCart.c
- History
- Source
- Diff
./DryBiCart.c
… 1 more file in changeset.

12:37 pm

Vendor - TEL - Jashwant Gantyada

More
c479bd8
changed 7 files
LDT-4873-request-add-config-to-disable-c-1, develop

Merged LDT-4410 and also resolved/restored lost code due to merge issues

- -124
- +324
./BalancingChamber.c
- History
- Source
- Diff
./BalancingChamber.c
- -0
- +8
./BalancingChamber.h
- History
- Source
- Diff
./BalancingChamber.h
- -5
- +7
./ConcentratePumps.h
- History
- Source
- Diff
./ConcentratePumps.h
- -72
- +185
./DryBiCart.c
- History
- Source
- Diff
./DryBiCart.c
- -1
- +2
./MixingControl.c
- History
- Source
- Diff
./MixingControl.c
… 2 more files in changeset.

12:33 pm

Michael Garthwaite

More
f723ec2
changed 2 files
LDT-4873-request-add-config-to-disable-c-1, LDT-5209-demo-build and 2 more LEAHI-DD-FIRMWARE-LDT-5209-1

LDT-5209: fixes to priming sequence

- -1
- +1
./DryBiCart.c
- History
- Source
- Diff
./DryBiCart.c
… 1 more file in changeset.

12:31 pm

Michael Garthwaite

More
08ef852
changed 3 files
LDT-4873-request-add-config-to-disable-c-1, LDT-5209-demo-build and 2 more LEAHI-DD-FIRMWARE-LDT-5209-1 LEAHI-DD-FIRMWARE-LDT-4873-2

Merge branch 'staging' into LDT-5209-pre-treatment

- -71
- +184
./DryBiCart.c
- History
- Source
- Diff
./DryBiCart.c
… 2 more files in changeset.

12:08 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Add the header description.

Add the header description.

12:04 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?

11:57 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Remove empty lines.

Remove empty lines.

11:49 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Add comments across the file.

Add comments across the file.

11:42 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Add comment.

Add comment.

11:41 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Add a test support for Pregen fill request.

Add a test support for Pregen fill request.

11:27 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Update header description for all newly added functions.

Update header description for all newly added functions.

11:23 am

Vendor - TEL - Arpita Srivastava

11:04 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

You may need to check other flags such as DryBicartFillRequested( Initial Fill), bicarbChamberFillRequested (Filling Chamber F), instead of 'bicarbChamberPregenFillRequested'. Keep Drain and Depres...

You may need to check other flags such as DryBicartFillRequested( Initial Fill), bicarbChamberFillRequested (Filling Chamber F), instead of 'bicarbChamberPregenFillRequested'. Keep Drain and DepressurizeRequest flag as is. This makes sure at any given point, dryBicartExec calls one of the service only.

11:02 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Same here adding 'bicarbChamberPregenFillRequested' flag.

Same here adding 'bicarbChamberPregenFillRequested' flag.

11:02 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Same here adding 'bicarbChamberPregenFillRequested' flag.

Same here adding 'bicarbChamberPregenFillRequested' flag.

11:01 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Same here adding 'bicarbChamberPregenFillRequested' flag.

Same here adding 'bicarbChamberPregenFillRequested' flag.

10:59 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Retain the previous( dryBicartFillRequested) and add 'bicarbChamberPregenFillRequested' flag here.

Retain the previous( dryBicartFillRequested) and add 'bicarbChamberPregenFillRequested' flag here.

10:53 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

PregenFillExecState? may be creating a new fault ID for pregen fill.

PregenFillExecState? may be creating a new fault ID for pregen fill.

10:51 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Update description as required.

Update description as required.

10:51 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Add comment.

Add comment.

10:50 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Add comment.

Add comment.

10:50 am

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-5209-1
commented on review

Add comment.

Add comment.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-08-03 22:33 -0700