dd-firmware / firmware / App

Drivers

Clone Tools

Stats

Commits this week: 7
Total Committers: 10
Last Commit: 07:39
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Dec
5:41 pm

Varshini Nagabooshanam <ven.vnagabooshanam@diality.com>

Merge LDT-618-dd-add-ability-to-override-fixes

Options
    • -2
    • +2
    ./TemperatureSensors.c
  2. … 9 more files in changeset.
10:17 am

Vendor - TEL - Jashwant Gantyada

I think you are seeing previous commit. It is not there in the present code.

I think you are seeing previous commit. It is not there in the present code.

10:16 am

Vendor - TEL - Jashwant Gantyada

Done. Thank you.

Done. Thank you.

10:15 am

Vendor - TEL - Jashwant Gantyada

Changed. Thank you.

Changed. Thank you.

10:13 am

Vendor - TEL - Jashwant Gantyada

LDT-2030-Changes made according to the comments addressed in the driver file.

Options
    • -347
    • +345
    ./BloodLeakDriver.c
Wednesday 10 Dec
8:03 pm

Vendor - TEL - Sameer Poyil

is it merge issue ?

is it merge issue ?

7:56 pm

Vendor - TEL - Sameer Poyil

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

7:50 pm

Vendor - TEL - Sameer Poyil

Please bring public functions on top. check it for all function in this file , except test functions

Please bring public functions on top. check it for all function in this file , except test functions

4:32 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -3
    • +3
    ./ConductivitySensors.c
    • -3
    • +3
    ./ConductivitySensors.h
    • -5
    • +5
    ./FlowSensor.c
    • -5
    • +5
    ./FlowSensor.h
    • -5
    • +5
    ./FluidPump.c
    • -4
    • +4
    ./FluidPump.h
    • -1
    • +1
    ./GPIO.c
    • -2
    • +2
    ./GPIO.h
    • -4
    • +4
    ./InternalADC.c
    • -4
    • +4
    ./InternalADC.h
    • -3
    • +3
    ./PAL.c
    • -3
    • +3
    ./PAL.h
    • -4
    • +4
    ./PressureSensor.c
    • -4
    • +4
    ./PressureSensor.h
    • -3
    • +3
    ./SafetyShutdown.c
  16. … 107 more files in changeset.
2:26 pm

Vendor - TEL - Jashwant Gantyada

LDT-2030-2 Addressed comments and made changes accordingly.

Options
    • -231
    • +231
    ./BloodLeakDriver.c
    • -0
    • +2
    ./BloodLeakDriver.h
Tuesday 09 Dec
11:25 am

Raghu Kallala

11:21 am

Dara Navaei

Vendor - TEL - Sameer Poyil this structure is not used to message handling.

Vendor - TEL - Sameer Poyil this structure is not used to message handling.

11:15 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./FluidPump.c
  2. … 19 more files in changeset.
11:12 am

Raghu Kallala

Resolved merge conflicts

Options
    • -1
    • +1
    ./FluidPump.c
  2. … 19 more files in changeset.
10:43 am

Sean Nash , Vinayakam Mani and Michael Garthwaite

10:39 am

Sean Nash

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

10:29 am

Raghu Kallala

Resolved

Resolved

10:16 am

Sean Nash

Change comment from 3 to 5 minutes to match code.

Change comment from 3 to 5 minutes to match code.

10:14 am

Sean Nash

I don't see fix

I don't see fix

10:03 am

Raghu Kallala

Fixed the ordering

Fixed the ordering

Friday 05 Dec
3:01 pm

Sean Nash

I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong.

I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong.

1:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -3
    • +3
    ./ConductivitySensors.c
    • -3
    • +3
    ./ConductivitySensors.h
    • -5
    • +5
    ./FlowSensor.c
    • -5
    • +5
    ./FlowSensor.h
    • -5
    • +5
    ./FluidPump.c
    • -4
    • +4
    ./FluidPump.h
    • -1
    • +1
    ./GPIO.c
    • -2
    • +2
    ./GPIO.h
    • -4
    • +4
    ./InternalADC.c
    • -4
    • +4
    ./InternalADC.h
    • -3
    • +3
    ./PAL.c
    • -3
    • +3
    ./PAL.h
    • -4
    • +4
    ./PressureSensor.c
    • -4
    • +4
    ./PressureSensor.h
    • -3
    • +3
    ./SafetyShutdown.c
  16. … 107 more files in changeset.
8:52 am

Vendor - TEL - Sameer Poyil

structure packing missing

structure packing missing

8:48 am

Vendor - TEL - Sameer Poyil

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

Thursday 04 Dec
10:18 am

Raghu Kallala

Handled in FPOperationModes and respective states of PreGen have it.

Handled in FPOperationModes and respective states of PreGen have it.

10:17 am

Raghu Kallala

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

10:15 am

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

10:14 am

Raghu Kallala

Fixed.

Fixed.

10:11 am

Raghu Kallala

Fixed.

Fixed.

10:10 am

Raghu Kallala

Fixed. thanks

Fixed. thanks