dd-firmware / firmware / App

Drivers

Clone Tools

Stats

Commits this week: 4
Total Committers: 10
Last Commit: 03 Feb
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Feb
5:32 pm

Sean Nash

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task...

I think cal data and count should be retrieved by same function and possibly needs some interrupt protection to ensure data and count stick together. If these functions are called from general task, we could have situation where data is retrieved, then priority task updates fpga, and then counter is retrieved with wrong (incremented) counter.
If these two functions are being called from a driver that is executed in priority task, then we don't need to worry about this situation, but still ought to add a constraint/warning comment in function headers noting that these functions should only be called from priority task.

5:16 pm

Sean Nash

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

5:15 pm

Sean Nash

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function...

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function (assuming shared enum to index)?

5:14 pm

Sean Nash

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler wher...

General Dialin question - does it make sense to override temperatures at driver level where they are spread out over several drivers? I would think overriding at monitor level would be simpler where they are all in one place and could be indexed by enum with single command.

5:09 pm

Sean Nash

Do we need to say Value?

Do we need to say Value?

5:08 pm

Sean Nash

Add a blank line after public defs banner. Add a dox comment to the right. I believe they reserve space for 12 bytes, not 10. Not really for calibration - it's for s/n and versions.

Add a blank line after public defs banner.
Add a dox comment to the right.
I believe they reserve space for 12 bytes, not 10.
Not really for calibration - it's for s/n and versions.

5:06 pm

Sean Nash

Are these really going to be different types? I assumed they would all be floats.

Are these really going to be different types? I assumed they would all be floats.

5:05 pm

Sean Nash

Structures need a top level dox comment.

Structures need a top level dox comment.

5:05 pm

Sean Nash

enums need a top level dox comment.

enums need a top level dox comment.

4:56 pm

Sean Nash

I believe conductivity and temperature data will be F32s.

I believe conductivity and temperature data will be F32s.

4:52 pm

Sean Nash

Do we not need this anymore? I still see it in code all over the place and I don't think we're done w/ Teensy until Beta 1.9 units are obsolete.

Do we not need this anymore? I still see it in code all over the place and I don't think we're done w/ Teensy until Beta 1.9 units are obsolete.

2:01 pm

Michael Garthwaite

LDT-2004: comment updates

Options
    • -11
    • +9
    ./ConductivitySensors.c
1:35 pm

Michael Garthwaite

LDT-2004: cal data and read functionality.

Options
    • -35
    • +357
    ./ConductivitySensors.c
    • -1
    • +1
    ./ConductivitySensors.h
  3. … 1 more file in changeset.
8:47 am

Michael Garthwaite

LDT-2004: data structures and public functions

Options
    • -754
    • +266
    ./ConductivitySensors.c
    • -29
    • +79
    ./ConductivitySensors.h
  3. … 6 more files in changeset.
Monday 02 Feb
11:37 am

Michael Garthwaite

11:01 am

Sean Nash

10:37 am

Michael Garthwaite

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:35 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:35 am

Sean Nash

Remove blank line.

Remove blank line.

9:34 am

Sean Nash

Remove blank line.

Remove blank line.

9:33 am

Sean Nash

Remove blank line.

Remove blank line.

9:21 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -3
    • +3
    ./ConductivityTeensy.c
    • -3
    • +3
    ./ConductivityTeensy.h
  3. … 9 more files in changeset.
Tuesday 27 Jan
1:03 pm

Michael Garthwaite

fixed. Removed ifdef as well as it is no longer applies here since we are retrieving the data from the monitor which has the #ifdefs for teensy.

fixed. Removed ifdef as well as it is no longer applies here since we are retrieving the data from the monitor which has the #ifdefs for teensy.

12:34 pm

Sean Nash

I think using filtered values for alarms makes sense.

I think using filtered values for alarms makes sense.

10:33 am

Michael Garthwaite

LDT-2004: code review updates.

Options
    • -3
    • +1
    ./ConductivitySensors.c
10:30 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./PressureSensor.c
    • -1
    • +1
    ./PressureSensor.h
    • -2
    • +2
    ./TemperatureSensors.c
    • -2
    • +2
    ./TemperatureSensors.h
  5. … 15 more files in changeset.
10:28 am

Vendor - TEL - Varshini Nagabooshanam

10:27 am

Vinayakam Mani , Sean Nash and Raghu Kallala

10:25 am

Michael Garthwaite

we need filtered values for various applications in the system. My question is should we be checking dialysate temperature using a filtered value or a sample point? This version showed that we want...

we need filtered values for various applications in the system. My question is should we be checking dialysate temperature using a filtered value or a sample point? This version showed that we want a sample point.

in Denali, looks like the HD got the filtered temperature value from the DG for checking dialysate temp alarms. Are we upholding that same design of using a filtered value for leahi dialysate temp?

10:19 am

Sean Nash

I don't see fix. Did you push fwcommon?

I don't see fix. Did you push fwcommon?