dd-firmware / firmware / App / Modes

FPModes

Clone Tools

Stats

Commits this week: 4
Total Committers: 13
Last Commit: 05 Aug
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
57 mins ago

Vendor - TEL - Suresh Dharnala

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the inte...

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the intended Standby behavior and allow it to work once driver support is added. Could you please let me know if there is any concern with leaving it in place for now?

1 hr ago

Vendor - TEL - Suresh Dharnala

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic plac...

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic placeholder for the sampling mode/state and update the implementation and requirements once the feature is better defined.

Wednesday 05 Aug
6:22 pm

Vinayakam Mani

Add TODO or revert back changes.

Add TODO or revert back changes.

6:20 pm

Vinayakam Mani

Delete empty line

Delete empty line

6:16 pm

Vinayakam Mani

Add the comment.

Add the comment.

6:15 pm

Vinayakam Mani

Align the indent throughout.

Align the indent throughout.

6:15 pm

Vinayakam Mani

Add comment.

Add comment.

6:04 pm

Vinayakam Mani

Space before and after paranthesis.

Space before and after paranthesis.

6:03 pm

Vinayakam Mani

If debug is complete, do you want to revert back to actual values? if you still need it for some more time, please add TODO comment.

If debug is complete, do you want to revert back to actual values? if you still need it for some more time, please add TODO comment.

5:50 pm

Vinayakam Mani

Update the comment.

Update the comment.

5:41 pm

Vinayakam Mani

Aling the indentation of value field.

Aling the indentation of value field.

5:37 pm

Vinayakam Mani

Align the indentation.

Align the indentation.

Tuesday 04 Aug
10:15 am

Michael Garthwaite

LDT-3975: updates to defines to clear alarms caused while running in treatment.

Options
    • -4
    • +4
    ./ModeGenPermeate.c
    • -1
    • +1
    ./ModePreGenPermeateDefeatured.c
  3. … 1 more file in changeset.
Monday 03 Aug
12:31 pm

Vendor - TEL - Jashwant Gantyada

LDT-4873 commented alarms for fp side

Options
    • -10
    • +9
    ./ModeGenPermeate.c
    • -8
    • +8
    ./ModePreGenPermeate.c
    • -1
    • +1
    ./StateFlushConcentrate.c
    • -4
    • +4
    ./StateFlushPermeate.c
  5. … 3 more files in changeset.
11:25 am

Vinayakam Mani

LDT-4873 commented some alarms

Options
    • -1
    • +2
    ./ModeGenPermeate.c
  2. … 1 more file in changeset.
11:05 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
Thursday 30 Jul
9:54 pm

suresh

addressed review comments

Options
    • -10
    • +20
    ./FPModeStandby.c
  2. … 2 more files in changeset.
Wednesday 29 Jul
11:27 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Revert "Merge branch 'develop' into LDT-5102-dd-concentrate-pumps-hardware-d"

This reverts commit f43d59af8e69ef1459bafe91873ce41cf63a4a75, reversing

changes made to 7f56f07660862bc62524c506699193a7e5f48f96.

Options
    • -0
    • +1
    ./ModePreGenPermeate.c
    • -0
    • +1
    ./StateFlushPermeate.c
  3. … 22 more files in changeset.
4:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
Monday 27 Jul
2:22 pm

Vinayakam Mani

you need to bring in the new set of valves here as well.

you need to bring in the new set of valves here as well.

2:21 pm

Vinayakam Mani

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

2:15 pm

Vinayakam Mani

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode b...

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode by TD request already).

1:43 pm

Vinayakam Mani

Align the indent. Replace RO to FP.

Align the indent. Replace RO to FP.

Tuesday 14 Jul
2:58 pm

Michael Garthwaite

LDT-3975: boost pump control changes to reflect new PI controller.

Options
    • -1
    • +1
    ./ModeGenPermeate.c
    • -1
    • +1
    ./ModePreGenPermeate.c
    • -1
    • +1
    ./StateFlushConcentrate.c
    • -3
    • +2
    ./StateFlushPermeate.c
  5. … 2 more files in changeset.
Monday 29 Jun
10:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2:
Wednesday 24 Jun
6:36 am

Raghu Kallala

Thursday 11 Jun
12:49 pm

Michael Garthwaite

LDT-3975: updates to iofp refinements LDT-1197: updates to power budget constriants and calculation. LDT-3102: updates to flush duration

Options
    • -1
    • +1
    ./StateFlushFilterDefeatured.c
  2. … 1 more file in changeset.
Tuesday 09 Jun
10:20 am

Michael Garthwaite

LDT-4001: changes pulled from previous boost pump branch

Options
    • -2
    • +2
    ./ModeGenPermeate.c
    • -1
    • +1
    ./ModePreGenPermeate.c
    • -3
    • +3
    ./StateFlushConcentrate.c
    • -1
    • +1
    ./StateFlushFilter.c
    • -3
    • +3
    ./StateFlushPermeate.c
    • -1
    • +1
    ./StateInletPressureCheck.c
  7. … 1 more file in changeset.
Thursday 28 May
1:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
Friday 22 May
11:08 am

Vendor - TEL - Jashwant Gantyada

resolved merge conflicts and merged LDT-3963

Options
    • -2
    • +2
    ./ModePreGenPermeate.c
  2. … 7 more files in changeset.