dd-firmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 7
Total Committers: 18
Last Commit: 15:37
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 11 Aug
9:10 am

Michael Garthwaite

LDT-3975: code review comments

Options
    • -1
    • +1
    ./FPModes/ModeGenPermeate.c
    • -2
    • +2
    ./FPModes/ModePreGenPermeateDefeatured.c
    • -1
    • +1
    ./FPModes/StateFlushConcentrate.c
  4. … 4 more files in changeset.
Monday 10 Aug
5:52 pm

Vinayakam Mani

Add comment.

Add comment.

5:50 pm

Vinayakam Mani

Initialize these in init function.

Initialize these in init function.

5:49 pm

Vinayakam Mani

update input section (for the prime fluid discard status)

update input section (for the prime fluid discard status)

5:47 pm

Vinayakam Mani

Remove empty line

Remove empty line

5:46 pm

Vinayakam Mani

Remove this commented code.

Remove this commented code.

4:44 pm

Vinayakam Mani

Add comment.

Add comment.

4:08 pm

Vinayakam Mani

Add comments.

Add comments.

1:26 pm

Vendor - TEL - Jashwant Gantyada

updated

updated

1:26 pm

Vendor - TEL - Jashwant Gantyada

updated

updated

1:26 pm

Vendor - TEL - Jashwant Gantyada

updated

updated

12:18 pm

Vinayakam Mani

2.0 PSI?

2.0 PSI?

12:14 pm

Vinayakam Mani

Add comment. Also add parenthesis for multiplication.

Add comment. Also add parenthesis for multiplication.

12:12 pm

Vinayakam Mani

Do we want to increase to higher - 1.0F?

Do we want to increase to higher - 1.0F?

Friday 07 Aug
2:44 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

staging sync and addressing comments

Options
    • -2
    • +2
    ./ModeGenDialysate.c
10:36 am

suresh

Merge branch 'staging' into LDT-4049-standby---fw-implementation---2

Options
    • -6
    • +6
    ./ModeStandby.c
10:33 am

suresh

Stop D108 substitution fluid heater once D108 driver support is implemented.

Options
    • -2
    • +4
    ./ModeFault.c
Thursday 06 Aug
6:37 pm

Vinayakam Mani

6:36 pm

Vinayakam Mani

Update header

Update header

6:28 pm

Vinayakam Mani

Align indent.

Align indent.

6:27 pm

Vinayakam Mani

Add Doxygen comments.

Add Doxygen comments.

6:26 pm

Vinayakam Mani

Align indent

Align indent

6:25 pm

Vinayakam Mani

0.0F

0.0F

6:23 pm

Vinayakam Mani

p40RPMCnts -> typecast to F32.

p40RPMCnts -> typecast to F32.

6:22 pm

Vinayakam Mani

mention as 30.0F, its being used in float calculations.

mention as 30.0F, its being used in float calculations.

6:17 pm

Vinayakam Mani

p40RPMCnts variable defined as U16, but assigning U32 value.

p40RPMCnts variable defined as U16, but assigning U32 value.

9:21 am

Vendor - TEL - Suresh Dharnala

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the inte...

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the intended Standby behavior and allow it to work once driver support is added. Could you please let me know if there is any concern with leaving it in place for now?

9:13 am

Vendor - TEL - Suresh Dharnala

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic plac...

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic placeholder for the sampling mode/state and update the implementation and requirements once the feature is better defined.

Wednesday 05 Aug
6:22 pm

Vinayakam Mani

Add TODO or revert back changes.

Add TODO or revert back changes.

6:20 pm

Vinayakam Mani

Delete empty line

Delete empty line