dd-firmware / firmware / App

Monitors

Clone Tools

Stats

Commits this week: 5
Total Committers: 15
Last Commit: 02 Jul
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 01 Jul
9:04 pm

Vendor - TEL - Sameer Poyil

please align this comments with below structure

please align this comments with below structure

9:03 pm

Vendor - TEL - Sameer Poyil

Please align the comments

Please align the comments

8:59 pm

Vendor - TEL - Sameer Poyil

could you please align it ?

could you please align it ?

6:08 pm

Sean Nash

Add blank line (should be 2 before test support banner).

Add blank line (should be 2 before test support banner).

6:07 pm

Sean Nash

Remove blank line.

Remove blank line.

6:06 pm

Sean Nash

Needs doxygen comments.

Needs doxygen comments.

4:17 pm

Vinayakam Mani and Vendor - TEL - Jashwant Gantyada

1:18 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:18 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:17 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:17 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:17 pm

Michael Garthwaite

Reverted change. Added uncompensated conductivity to the conductivity publishing

Reverted change. Added uncompensated conductivity to the conductivity publishing

1:16 pm

Michael Garthwaite

LDT-4734: code review comments

Options
    • -24
    • +51
    ./Conductivity.c
    • -0
    • +8
    ./Conductivity.h
  3. … 1 more file in changeset.
1:00 pm

Michael Garthwaite

Revert "LDT-4734: updates conductivity resistance messages."

This reverts commit 14277e7c55fbb8407612572aca191ffae0835796.

Options
    • -0
    • +30
    ./Conductivity.c
  2. … 1 more file in changeset.
11:02 am

Vinayakam Mani

space after if.

space after if.

11:02 am

Vinayakam Mani

Space after if.

Space after if.

10:59 am

Vinayakam Mani

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

10:58 am

Vendor - TEL - Jashwant Gantyada

10:57 am

Vendor - TEL - Jashwant Gantyada

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

10:57 am

Vinayakam Mani

Remove empty line.

Remove empty line.

10:54 am

Vinayakam Mani

Align the indentation

Align the indentation

10:54 am

Vinayakam Mani

Align the indentation.

Align the indentation.

10:38 am

Michael Garthwaite

Merge branch 'LDT-4734-temp-comp-conductivity' into develop

Options
    • -50
    • +16
    ./Conductivity.c
  2. … 1 more file in changeset.
10:33 am

Michael Garthwaite

LDT-4734: updates conductivity resistance messages.

Options
    • -30
    • +0
    ./Conductivity.c
  2. … 1 more file in changeset.
10:11 am

Michael Garthwaite

LDT-4734: updates to conductivity message to show resistances reflective to subsystem

Options
    • -41
    • +14
    ./Conductivity.c
    • -25
    • +14
    ./Conductivity.h
Friday 26 Jun
1:41 pm

Vinayakam Mani

Same as above.

Same as above.

1:39 pm

Vinayakam Mani

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

1:37 pm

Vinayakam Mani

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

Thursday 25 Jun
4:14 pm

Vendor - TEL - Sameer Poyil

it shouldn't be the default value

it shouldn't be the default value

2:21 pm

Michael Garthwaite

WIP on LDT-4734-temp-comp-conductivity

LDT-4734: uncompensated integration wip

Options
    • -0
    • +24
    ./Conductivity.c
    • -0
    • +7
    ./Conductivity.h
  3. … 2 more files in changeset.