Fisheye on dd-firmware/firmware/App/Services

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Remove this flag."

Vinayakam Mani — Tue, 05 May 2026 12:35:33 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Remove this flag.

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Remove this code."

Vinayakam Mani — Tue, 05 May 2026 12:31:12 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Remove this code.

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Remove this condition to apply the speed for BC..."

Vinayakam Mani — Tue, 05 May 2026 11:57:09 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Remove this condition to apply the speed for BC switch only as well.

LEAHI-DD-FIRMWARE-LDT-4188-1: reviewers finished

Tue, 05 May 2026 10:55:41 -0700

Michael Garthwaite and Vinayakam Mani finished reviewing LEAHI-DD-FIRMWARE-LDT-4188-1

LEAHI-DD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI

dd-firmware (LDT-4188-sw-fw-integration-to-run-a-trea): LDT-4188 resolved compiler warning

Raghu Kallala — Tue, 05 May 2026 10:53:14 -0700

Raghu Kallala committed 2ae6daa on branch LDT-4188-sw-fw-integration-to-run-a-trea, LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

LDT-4188 resolved compiler warning

· /firmware/App/Services/TDInterface.c

(-10, +11)

| History

| Source

| Diff

LEAHI-DD-FIRMWARE-LDT-4188-1: started by Raghu Kallala

Raghu Kallala — Tue, 05 May 2026 10:38:10 -0700

Raghu Kallala started review LEAHI-DD-FIRMWARE-LDT-4188-1

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Check the else portion and do the required chan..."

Vinayakam Mani — Tue, 05 May 2026 10:20:37 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Check the else portion and do the required changes.

dd-firmware (develop): LDT-4188 resolved merge conflict with develop

Raghu Kallala — Tue, 05 May 2026 07:01:22 -0700

Raghu Kallala committed 4b27043 on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

LDT-4188 resolved merge conflict with develop

· /firmware/App/Services/Messaging.c

(-0, +1)

| History

| Source

| Diff

dd-firmware (staging): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Tue, 05 May 2026 06:58:43 -0700

Dara Navaei committed abe1c4a on branch staging in dd-firmware

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeGenDialysate.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/TDInterface.c	(-2, +2)	\| History	\| Source	\| Diff
· /firmware/App/Services/TDInterface.h	(-2, +2)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-4188-1: closed by Raghu Kallala

Raghu Kallala — Tue, 05 May 2026 06:56:48 -0700

Raghu Kallala Closed LEAHI-DD-FIRMWARE-LDT-4188-1

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "Name something similar to 'BCSwitchingBasedOnCl..."

Vinayakam Mani — Mon, 04 May 2026 16:14:18 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "I guess, all these checks should be moved to Fi..."

Vinayakam Mani — Mon, 04 May 2026 16:02:37 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

I guess, all these checks should be moved to FillEndState.

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vinayakam Mani "after one state of BC switching completed. upda..."

Vinayakam Mani — Mon, 04 May 2026 15:51:27 -0700

Vinayakam Mani commented on LEAHI-DD-FIRMWARE-LDT-3963-1

after one state of BC switching completed. update the next comment as well.

dd-firmware (feature/LDT-3963-dialysate-flow-rate---fw-implem): LDT-3963 dialysate flow rate algorithm changes and testing

Vendor - TEL - Jashwant Gantyada — Mon, 04 May 2026 14:39:09 -0700

Vendor - TEL - Jashwant Gantyada committed 8348015 on branch feature/LDT-3963-dialysate-flow-rate---fw-implem in dd-firmware

LDT-3963 dialysate flow rate algorithm changes and testing

· /firmware/App/Controllers/BalancingChamber.c	(-76, +255)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/BalancingChamber.h	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/ConcentratePumps.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/RinsePump.c	(-2, +3)	\| History	\| Source	\| Diff
· /firmware/App/DDCommon.h	(-0, +3)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-4, +16)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenDialysate.c	(-8, +35)	\| History	\| Source	\| Diff
· /firmware/App/Modes/ModeGenDialysate.h	(-1, +2)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Level.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtDD.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/SystemCommDD.c	(-0, +1)	\| History	\| Source	\| Diff

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Arpita Srivastava "Should we add a TODO to remove this one as well..."

Vendor - TEL - Arpita Srivastava — Mon, 04 May 2026 09:59:06 -0700

Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Should we add a TODO to remove this one as well?

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Arpita Srivastava "If we are removing this call, then where are we..."

Vendor - TEL - Arpita Srivastava — Mon, 04 May 2026 09:57:11 -0700

Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-3963-1

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Vendor - TEL - Arpita Srivastava "Please update the function name : testDDFloater..."

Vendor - TEL - Arpita Srivastava — Mon, 04 May 2026 09:44:11 -0700

Vendor - TEL - Arpita Srivastava commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Please update the function name : testDDFloaterLevelStateOverride

LEAHI-DD-FIRMWARE-LDT-3963-1: reviewers added to LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - F...

Sun, 03 May 2026 23:45:17 -0700

Sean Nash added Michael Garthwaite , Vendor - TEL - Arpita Srivastava and Vinayakam Mani to LEAHI-DD-FIRMWARE-LDT-3963-1

LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Why are we removing this TODO comment? It look..."

Sean Nash — Sun, 03 May 2026 23:08:20 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Why are we removing this TODO comment? It looks like we should keep it.

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Do we need TODO comments to restore these alarm..."

Sean Nash — Sun, 03 May 2026 23:06:56 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Do we need TODO comments to restore these alarms later?

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "What is the point of this message?"

Sean Nash — Sun, 03 May 2026 23:06:01 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

What is the point of this message?

LEAHI-DD-FIRMWARE-LDT-3963-1: comment by Sean Nash "Looks like we need a TODO comment to restore th..."

Sean Nash — Sun, 03 May 2026 23:01:28 -0700

Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3963-1

Looks like we need a TODO comment to restore these checks later.

dd-firmware (LDT-3272-software-update---dd-firmware): LDT-3272 added mode update with the fault alarm and the messages

Dara Navaei — Sun, 03 May 2026 17:35:47 -0700

Dara Navaei committed eb159be on branch LDT-3272-software-update---dd-firmware in dd-firmware

LDT-3272 added mode update with the fault alarm and the messages

· /firmware/App/Modes/ModeUpdate.c	(-0, +128)	\| History	\| Source
· /firmware/App/Modes/ModeUpdate.h	(-0, +25)	\| History	\| Source
· /firmware/App/Modes/OperationModes.c	(-11, +22)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-0, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +40)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.h	(-0, +2)	\| History	\| Source	\| Diff

dd-firmware (LDT-3272-software-update---dd-firmware): LDT-3272 added DD to UI and UI to DD CAN channels

Dara Navaei — Sun, 03 May 2026 15:41:05 -0700

Dara Navaei committed 61ae50e on branch LDT-3272-software-update---dd-firmware in dd-firmware

LDT-3272 added DD to UI and UI to DD CAN channels

· /firmware/App/Services/SystemCommDD.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/DD.dil	(-13, +13)	\| History	\| Source	\| Diff
· /firmware/include/can.h	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/source/can.c	(-1, +39)	\| History	\| Source	\| Diff

dd-firmware (develop): fixed emrge conflicts and merged LDT-3963

Vendor - TEL - Jashwant Gantyada — Fri, 01 May 2026 11:20:44 -0700

Vendor - TEL - Jashwant Gantyada committed 1c478c1 on branch LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

fixed emrge conflicts and merged LDT-3963

· /firmware/App/Controllers/BalancingChamber.c	(-6, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.c	(-1, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +0)	\| History	\| Source	\| Diff

dd-firmware (develop): LDT-3963 Fixes for beta 2.1 testing

Vendor - TEL - Jashwant Gantyada — Fri, 01 May 2026 11:04:41 -0700

Vendor - TEL - Jashwant Gantyada committed 91685a2 on branch LDT-4246-fw-support-for-ui-demo, develop, feature/LDT-3963-dialysate-flow-rate---fw-implem in dd-firmware

LDT-3963 Fixes for beta 2.1 testing

· /firmware/App/Controllers/BalancingChamber.c	(-6, +4)	\| History	\| Source	\| Diff
· /firmware/App/Drivers/ConductivitySensors.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Level.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/AlarmMgmtDD.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-1, +0)	\| History	\| Source	\| Diff

dd-firmware (develop): LDT-4000: fixed fpga init to use beta 2 data structures

Michael Garthwaite — Thu, 30 Apr 2026 21:08:15 -0700

Michael Garthwaite committed 564f298 on branch LDT-4000-hdf-fw-implementation-1, LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

LDT-4000: fixed fpga init to use beta 2 data structures

· /firmware/App/Services/FpgaDD.c

(-2, +2)

| History

| Source

| Diff

dd-firmware (develop): LDT-4000: changed beta 2.0 test config to beta 1.9 test config

Michael Garthwaite — Thu, 30 Apr 2026 20:50:05 -0700

Michael Garthwaite committed f37bfe2 on branch LDT-4000-hdf-fw-implementation-1, LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

LDT-4000: changed beta 2.0 test config to beta 1.9 test config

· /firmware/App/Controllers/Heaters.c	(-7, +7)	\| History	\| Source	\| Diff
· /firmware/App/Controllers/RinsePump.c	(-11, +11)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-4, +4)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Level.c	(-24, +22)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Temperature.c	(-12, +12)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.c	(-52, +32)	\| History	\| Source	\| Diff

dd-firmware (develop): LDT-4000: fixes for merging

Michael Garthwaite — Thu, 30 Apr 2026 20:27:08 -0700

Michael Garthwaite committed c441453 on branch LDT-4000-hdf-fw-implementation-1, LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

LDT-4000: fixes for merging

· /firmware/App/Services/Messaging.c

(-1, +1)

| History

| Source

| Diff

dd-firmware (develop): LDT-4000: substitution pump implementation and fixes.

Michael Garthwaite — Thu, 30 Apr 2026 18:40:02 -0700

Michael Garthwaite committed 11fcfaf on branch LDT-4000-hdf-fw-implementation-1, LDT-4246-fw-support-for-ui-demo, develop in dd-firmware

LDT-4000: substitution pump implementation and fixes.

· /firmware/App/Controllers/SubstitutionPump.c	(-0, +554)	\| History	\| Source
· /firmware/App/Controllers/SubstitutionPump.h	(-0, +73)	\| History	\| Source
· /firmware/App/Drivers/ConductivitySensors.c	(-1, +1)	\| History	\| Source	\| Diff
· /firmware/App/Monitors/Conductivity.c	(-6, +0)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.c	(-1, +91)	\| History	\| Source	\| Diff
· /firmware/App/Services/FpgaDD.h	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/App/Services/Messaging.c	(-0, +2)	\| History	\| Source	\| Diff
· /firmware/App/Tasks/TaskGeneral.c	(-0, +4)	\| History	\| Source	\| Diff
· /firmware/source/sys_main.c	(-0, +2)	\| History	\| Source	\| Diff