dd-firmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 9
Total Committers: 15
Last Commit: 12:10
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 27 May
10:20 am

Dara Navaei

Merge branch 'staging' into LDT-3272-software-update---dd-firmware

Options
    • -2
    • +2
    ./Messaging.c
    • -2
    • +8
    ./SystemCommDD.c
10:19 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4002_HDF - FW Implementation - 3/4:
LEAHI-DD-FIRMWARE-LDT-4002_HDF - FW Implementation - 3/4:
10:16 am

Sean Nash

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

10:02 am

Sean Nash

Same.

Same.

10:02 am

Sean Nash

Same

Same

10:01 am

Sean Nash

We shouldn't delete generated code. Add a #if 0 in this user code section and add a #endif in the user section below the coreEnableFlashEcc() call.

We shouldn't delete generated code. Add a #if 0 in this user code section and add a #endif in the user section below the coreEnableFlashEcc() call.

10:00 am

Steve Jarpe <sjarpe@diality.com>

LDT-4002: more additions to switches implementation

Options
    • -0
    • +1
    ./AlarmMgmtSWFaults.h
    • -0
    • +62
    ./FpgaDD.c
    • -0
    • +5
    ./FpgaDD.h
  4. … 11 more files in changeset.
Friday 22 May
11:17 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./AlarmMgmtDD.c
    • -2
    • +2
    ./FpgaDD.c
    • -2
    • +2
    ./Messaging.c
    • -2
    • +2
    ./SystemCommDD.c
  5. … 15 more files in changeset.
11:11 am

Vendor - TEL - Jashwant Gantyada

10:50 am

Sean Nash and Vinayakam Mani

Thursday 21 May
8:51 pm

Dara Navaei

Merge branch 'staging' into LDT-3272-software-update---dd-firmware

Options
    • -0
    • +16
    ./SystemCommDD.h
3:36 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review comments

Options
    • -1
    • +1
    ./SystemCommDD.c
  2. … 1 more file in changeset.
3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:18 pm

Sean Nash

Should be #ifndef

Should be #ifndef

3:13 pm

Sean Nash

Should be #ifndef I think.

Should be #ifndef I think.

3:06 pm

Sean Nash

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

1:32 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review comments and restored the fault mode transition

Options
    • -1
    • +1
    ./AlarmMgmtDD.c
    • -2
    • +2
    ./SystemCommDD.c
  3. … 8 more files in changeset.
Sunday 17 May
11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

11:26 pm

Sean Nash

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

11:19 pm

Sean Nash

Add a blank line after banner.

Add a blank line after banner.

11:19 pm

Sean Nash

Please restore before you merge to staging.

Please restore before you merge to staging.

11:16 pm

Sean Nash

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

11:14 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

3:09 pm

Dara Navaei

LDT-3272 updated the size of the comm buffers

Options
    • -2
    • +2
    ./SystemCommDD.h
Friday 15 May
11:36 am

Vinayakam Mani

align the indent.

align the indent.

11:33 am

Vinayakam Mani

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

Thursday 14 May
7:21 pm

Vendor - TEL - Sameer Poyil

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for buil...

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for build / functionality should be removed.