dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 47
Total Committers: 15
Last Commit: 10:45
Commits this week: 47

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 07 Mar
3:06 pm

Dara Navaei

LDT-3605 updated the blood leak driver for the hardware config restart

Options
    • -13
    • +1
    ./Monitors/BloodLeak.c
2:40 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Friday 06 Mar
7:00 pm

Vendor - TEL - Sameer Poyil and Sean Nash

2:48 pm

Sean Nash

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

2:46 pm

Sean Nash

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request. We should do whatever is needed (if an...

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request.
We should do whatever is needed (if anything) to start the mode normally in an else.
And we should return TRUE/FALSE in these signal functions so that when it's called from Dialin msg handler, the msg handler can return ACK/NAK to Dialin if sub mode is invalid.

2:42 pm

Sean Nash

We shouldn't request op mode until we're sure we're happy with the whole thing. Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just re...

We shouldn't request op mode until we're sure we're happy with the whole thing.
Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just request new sub mode if not already in it. If not, the currentSubMode checked below is not relevant (applies to current mode, not the requested mode) and we need to request new op mode and signal that new op mode that we will want to start in a specific sub mode.

2:38 pm

Sean Nash

Declarations should be at top of scope (right before memcpy).

Declarations should be at top of scope (right before memcpy).

2:37 pm

Sean Nash

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

2:36 pm

Sean Nash

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

2:34 pm

Sean Nash

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

2:29 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -1
    • +0
    ./Monitors/Conductivity.c
2:25 pm

Michael Garthwaite

fixed

fixed

2:24 pm

Michael Garthwaite

fixed

fixed

2:24 pm

Michael Garthwaite

fixed.

fixed.

2:24 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -2
    • +0
    ./Drivers/ConductivityTeensy.c
2:23 pm

Michael Garthwaite

fixed.

fixed.

2:23 pm

Michael Garthwaite

fixed.

fixed.

2:23 pm

Michael Garthwaite

fixed.

fixed.

2:22 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -1
    • +1
    ./Monitors/Conductivity.c
2:21 pm

Michael Garthwaite

J1 - P9 J2 - P18 J3 - D17 J4 - D27 J5 - D29 J6 - D43 No sensor - D74 (redundant, so we should be able to live without it in short run)

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

2:20 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:20 pm

Michael Garthwaite

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November: J1 - P9 J2 - P18 J3 - D17 J4 - D27 J5 - D29 J6 - D43 No sensor - D74 (redundant,...

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November:

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

2:20 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:18 pm

Michael Garthwaite

LDT-3372: code review comments

Options
    • -1
    • +0
    ./Monitors/Conductivity.h
2:18 pm

Sean Nash

Remove blank line.

Remove blank line.

2:17 pm

Sean Nash

Remove blank line.

Remove blank line.

2:17 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

2:17 pm

Sean Nash

Same question.

Same question.

2:16 pm

Sean Nash

Why is D74 not a Teensy? And I though you were getting ride of this build switch and using test config (run time switch)?

Why is D74 not a Teensy? And I though you were getting ride of this build switch and using test config (run time switch)?

2:14 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.