Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'staging' into LDT-3103-closed-loop-control-pressure-threshold-fix

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Add blank line before return.

Add blank line before return.

Add blank line before return.

Add blank line before return.

Remove blank line.

Remove blank line.

Why are we switching sensors around?

Why are we switching sensors around?

Why D43?

Why D43?

Remove blank line.

Remove blank line.

Should we be filtering a new sample every 700ms or should we do it when a new sample is received? FPGA is giving us a read count right? So we will know when we have a new data set from sensor. It m...

Should we be filtering a new sample every 700ms or should we do it when a new sample is received?
FPGA is giving us a read count right? So we will know when we have a new data set from sensor. It makes more sense to me to take them when they come. Otherwise, we will get out of phase with true sample frequency and occasionally process the previous sample again (if true sample freq is a little slower than 700ms) or miss a sample (if true sample freq is a little faster than 700ms).

Why do we need these static interval variables when we have the constants?

Why do we need these static interval variables when we have the constants?

Remove blank line.

Remove blank line.

Delete the macro if not being used.

Delete the macro if not being used.

LDT-1195: Fixed indentation

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we imple...

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

LDT-2008: version request handler. fixes for D74 between test configs. reworked init state to handle sensors providing bad cal data if test config is enabled.

    • -79
    • +114
    ./Drivers/ConductivitySensors.c
LDT-3103 addressed code review comments

Merge branch 'staging' into LDT-2008-v2-conductivity-sensors-CLEAN

LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation
LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation
LDT-3735: NVM module builds

removed

removed

updated comment.

updated comment.

removed.

removed.

removed and added comments.

removed and added comments.

changed.

changed.

done. moved them to dosing concentrates state.

done. moved them to dosing concentrates state.

LDT-3103 changes made according to code review comments

    • -14
    • +14
    ./Controllers/BalancingChamber.c