dd-firmware

firmware

Clone Tools

Stats

Commits this week: 35
Total Committers: 18
Last Commit: 17 Jul
Commits this week: 35

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 01 Jul
11:52 am

Vendor - TEL - Jashwant Gantyada

LDT-4410 made bal chamber changes and build flag for D65 valve actuation

Options
    • -77
    • +52
    ./App/Controllers/BalancingChamber.c
    • -1
    • +9
    ./App/Controllers/DryBiCart.c
    • -0
    • +3
    ./App/DDCommon.h
11:02 am

Vinayakam Mani

space after if.

space after if.

11:02 am

Vinayakam Mani

Space after if.

Space after if.

10:59 am

Vinayakam Mani

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

10:58 am

Vendor - TEL - Jashwant Gantyada

10:57 am

Vendor - TEL - Jashwant Gantyada

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

10:57 am

Vinayakam Mani

Remove empty line.

Remove empty line.

10:54 am

Vinayakam Mani

Align the indentation

Align the indentation

10:54 am

Vinayakam Mani

Align the indentation.

Align the indentation.

10:40 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h
10:38 am

Michael Garthwaite

Merge branch 'LDT-4734-temp-comp-conductivity' into develop

Options
    • -9
    • +91
    ./App/Drivers/ConductivitySensors.c
    • -50
    • +16
    ./App/Monitors/Conductivity.c
10:37 am

Michael Garthwaite

LDT-4734: updates on spacing

Options
    • -2
    • +0
    ./App/Drivers/ConductivitySensors.c
10:37 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

resolved conflicts and mismatches

Options
    • -25
    • +2
    ./App/Controllers/DryBiCart.c
10:33 am

Michael Garthwaite

LDT-4734: updates conductivity resistance messages.

Options
    • -36
    • +0
    ./App/Drivers/ConductivitySensors.c
    • -30
    • +0
    ./App/Monitors/Conductivity.c
10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

moved.

moved.

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:31 am

Vendor - TEL - Jashwant Gantyada

LDT-4719 code review comments

Options
    • -36
    • +36
    ./App/Controllers/MixingControl.c
    • -2
    • +2
    ./App/Controllers/MixingControl.h
    • -7
    • +6
    ./App/Modes/ModeGenDialysate.c
10:18 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:17 am

Vendor - TEL - Jashwant Gantyada

LDT-4011 code review comments

Options
    • -2
    • +2
    ./App/Controllers/BalancingChamber.c
10:11 am

Michael Garthwaite

LDT-4734: updates to conductivity message to show resistances reflective to subsystem

Options
    • -41
    • +14
    ./App/Monitors/Conductivity.c
    • -25
    • +14
    ./App/Monitors/Conductivity.h
9:42 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Merge conflicts with staging resolved and comments

Options
    • -12
    • +41
    ./App/Controllers/BalancingChamber.c
    • -955
    • +427
    ./App/Controllers/DryBiCart.c
    • -6
    • +4
    ./App/Controllers/Heaters.c
    • -3
    • +4
    ./App/Tasks/TaskPriority.c
9:36 am

Sean Nash

Move below Messaging.h to keep list in alphabetical order.

Move below Messaging.h to keep list in alphabetical order.

9:16 am

Sean Nash

balancingError is an input.

balancingError is an input.

Tuesday 30 Jun
5:09 pm

Vinayakam Mani

Same here. Let's use only D29.

Same here. Let's use only D29.

5:02 pm

Vinayakam Mani

Suppose to use D74, Instead of D17 (for Control only).

Suppose to use D74, Instead of D17 (for Control only).

4:48 pm

Vinayakam Mani

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

4:44 pm

Vinayakam Mani

Missing Comment.

Missing Comment.