dd-firmware

firmware

Clone Tools

Stats

Commits this week: 36
Total Committers: 18
Last Commit: 09:20
Commits this week: 36

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 09 Jul
2:16 pm

Michael Garthwaite

LDT-4733: code review comments

Options
    • -7
    • +7
    ./App/Monitors/Voltages.c
2:13 pm

Sean Nash

11:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

11:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

11:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

11:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

11:22 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

11:21 am

Michael Garthwaite

LDT-4733: code review comments

Options
    • -5
    • +5
    ./App/Monitors/Voltages.c
    • -5
    • +4
    ./App/Services/FpgaDD.c
    • -4
    • +2
    ./App/Services/FpgaDD.h
10:15 am

Michael Garthwaite

this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733 Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.

this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733

Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.

Wednesday 08 Jul
2:55 pm

Sean Nash

TODO?

TODO?

2:21 pm

Vinayakam Mani

Remove empty line

Remove empty line

2:20 pm

Vinayakam Mani

Remove empty line.

Remove empty line.

2:03 pm

Vinayakam Mani

Please add the details what is post and pre in the comments. Also update the return type with additional details, instead of just conducitivity.

Please add the details what is post and pre in the comments. Also update the return type with additional details, instead of just conducitivity.

2:01 pm

Vinayakam Mani

Remove extra line.

Remove extra line.

1:52 pm

Vinayakam Mani

Is this TODO still valid?

Is this TODO still valid?

1:51 pm

Vinayakam Mani

Space inside parenthesis. update across the file.

Space inside parenthesis. update across the file.

1:48 pm

Vinayakam Mani and Vendor - TEL - Jashwant Gantyada

1:45 pm

Vinayakam Mani

Did you get a chance to test this alarm and uncomment the code?

Did you get a chance to test this alarm and uncomment the code?

1:44 pm

Vinayakam Mani

Remove empty space.

Remove empty space.

1:44 pm

Vinayakam Mani

ACToDC?

ACToDC?

1:42 pm

Vinayakam Mani

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

10:41 am

Sean Nash

Align comment. Clarify (at least in comments) that these macros are for FPGA count conversions.

Align comment.
Clarify (at least in comments) that these macros are for FPGA count conversions.

10:38 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

9:54 am

Michael Garthwaite

Merge branch 'staging' into LDT-3975-water-treatment-and-degassing--

Options
    • -3
    • +3
    ./App/Services/AlarmMgmtSWFaults.h
9:39 am

Michael Garthwaite

LDT-4734: code review comments

Options
    • -1
    • +1
    ./App/Drivers/ConductivitySensors.c
    • -24
    • +24
    ./App/Monitors/Conductivity.c
    • -2
    • +2
    ./App/Monitors/Conductivity.h
9:00 am

Michael Garthwaite

Merge branch 'staging' into LDT-4733-request-add-variables

Options
    • -2
    • +5
    ./App/Tasks/TaskGeneral.c
Tuesday 07 Jul
9:55 am

Vendor - TEL - Jashwant Gantyada

LDT-4410 merged lates staging into branch

Options
    • -6
    • +71
    ./App/Controllers/BalancingChamber.c
    • -4
    • +14
    ./App/Controllers/DryBiCart.c
    • -1
    • +1
    ./App/DDCommon.h
9:04 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Monday 06 Jul
12:59 pm

Sean Nash

What is 4 (or 2)? Should be #define or enum or const.

What is 4 (or 2)? Should be #define or enum or const.

11:10 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./App/DDCommon.h