firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
This is a common unit - could be built into DD or TD f/w. Need #ifdef to see if _DD_ or _TD_ build so you know which messaging and records to initialize.

This is a common unit - could be built into DD or TD f/w. Need #ifdef to see if _DD_ or _TD_ build so you know which messaging and records to initialize.

These don't look like UI alarms. Comment suggests we already know what to call these. Why aren't we just using the names we want?

These don't look like UI alarms. Comment suggests we already know what to call these. Why aren't we just using the names we want?

Make sure Dialin gets these too when you merge.

Make sure Dialin gets these too when you merge.

right now pre and post are same. make a TODO to update post later

right now pre and post are same. make a TODO to update post later

its mixing control interval

its mixing control interval

could you document th math behind the calculation also

could you document th math behind the calculation also

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733 Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.

this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733

Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.

TODO?

TODO?

Remove empty line

Remove empty line

Remove empty line.

Remove empty line.

Please add the details what is post and pre in the comments. Also update the return type with additional details, instead of just conducitivity.

Please add the details what is post and pre in the comments. Also update the return type with additional details, instead of just conducitivity.

Remove extra line.

Remove extra line.

Is this TODO still valid?

Is this TODO still valid?

Space inside parenthesis. update across the file.

Space inside parenthesis. update across the file.

Did you get a chance to test this alarm and uncomment the code?

Did you get a chance to test this alarm and uncomment the code?

Remove empty space.

Remove empty space.

ACToDC?

ACToDC?

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

Align comment. Clarify (at least in comments) that these macros are for FPGA count conversions.

Align comment.
Clarify (at least in comments) that these macros are for FPGA count conversions.

Remove extra blank lines.

Remove extra blank lines.