dgfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Mar 2021
4:28 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added handler for alarm clear

Options
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
1:56 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added new CAN channel for UI to DG comm

Options
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -4
    • +5
    /firmware/App/Services/CommBuffers.h
    • -3
    • +4
    /firmware/App/Services/SystemComm.c
    • -18
    • +18
    /firmware/DG.dil
    • -8
    • +27
    /firmware/source/can.c
12:33 pm

pmontazemi  (deleted user)

Addressed for both DG and HD.

Addressed for both DG and HD.

12:26 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Addressed code review comments

Options
    • -0
    • +2
    /firmware/App/Controllers/FluidLeak.h
10:40 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

pmontazemi  (deleted user)

Because the fluid leak detector is packaged as part of a 16-bit (LSB + MSB) representing the GPIOs of the FPGA. This is to save space. I use a bitmask to extract that one bit I need which is repres...

Because the fluid leak detector is packaged as part of a 16-bit (LSB + MSB) representing the GPIOs of the FPGA. This is to save space. I use a bitmask to extract that one bit I need which is representative of the fluid leak detector state (dry/1 vs. wet/0).

10:28 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Addressed code review comments

Options
    • -0
    • +4
    /firmware/App/Controllers/FluidLeak.c
Wednesday 10 Mar 2021
11:48 pm

Dara Navaei

Why is this called fpgaGPIO? Why not leakDetector or something that is more representative of your driver?

Why is this called fpgaGPIO? Why not leakDetector or something that is more representative of your driver?

11:45 pm

Dara Navaei

We started adding the sensors's part number and model. Could you please add it here?

We started adding the sensors's part number and model. Could you please add it here?

2:07 pm

pmontazemi  (deleted user)

2:02 pm

pmontazemi  (deleted user)

Removed.

Removed.

2:02 pm

pmontazemi  (deleted user)

Added.

Added.

2:01 pm

Peman Montazemi <pmontazemi@diality.com>

Addressed code review comments

Options
    • -2
    • +0
    /firmware/App/Controllers/FluidLeak.c
    • -14
    • +18
    /firmware/App/Tasks/TaskPriority.c
Tuesday 09 Mar 2021
4:58 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Removed unnecessary accelerometer calibration parameter message

Options
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
4:58 pm

Sean Nash

If no params, just remove this line from header.

If no params, just remove this line from header.

4:57 pm

Sean Nash

Did you add a call to this function in TaskPriority.c?

Did you add a call to this function in TaskPriority.c?

4:54 pm

Sean Nash

Probably don't need OperationModes.h either.

Probably don't need OperationModes.h either.

3:34 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of DG Fluid Leak Detector driver

Options
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
3:19 pm

pmontazemi  (deleted user)

DG-DEN-6890_Fluid Leak Detector Driver
DG-DEN-6890_Fluid Leak Detector Driver
3:08 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of DG Fluid Leak Detector driver

Options
    • -2
    • +0
    /firmware/App/Controllers/ConductivitySensors.c
    • -0
    • +255
    /firmware/App/Controllers/FluidLeak.c
    • -0
    • +56
    /firmware/App/Controllers/FluidLeak.h
    • -2
    • +2
    /firmware/App/Modes/ModeFill.c
    • -4
    • +20
    /firmware/App/Services/FPGA.c
    • -0
    • +2
    /firmware/App/Services/FPGA.h
    • -4
    • +8
    /firmware/App/Services/SystemComm.c
    • -0
    • +94
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +11
    /firmware/App/Services/SystemCommMessages.h
    • -0
    • +2
    /firmware/source/sys_main.c
2:54 pm

Dara Navaei

DEN-5963 work in progress. tested cancellation path with water

Options
    • -2
    • +2
    /firmware/App/Controllers/DrainPump.c
    • -12
    • +29
    /firmware/App/Controllers/Heaters.c
    • -1
    • +1
    /firmware/App/Controllers/ROPump.c
    • -86
    • +124
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +22
    /firmware/App/Services/Reservoirs.c
    • -0
    • +2
    /firmware/App/Services/Reservoirs.h
    • -18
    • +0
    /firmware/App/Services/WatchdogMgmt.c
Saturday 06 Mar 2021
9:54 am

Dara Navaei

DEN-5963 added other inlet and outlet fans RPM

Options
    • -5
    • +5
    /firmware/App/Controllers/ROPump.h
    • -6
    • +6
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -8
    • +14
    /firmware/App/Services/FPGA.c
Friday 05 Mar 2021
2:02 pm

Dara Navaei

DEN-5963 tested heat disinfect

Options
    • -2
    • +3
    /firmware/App/Controllers/DrainPump.c
    • -2
    • +2
    /firmware/App/Modes/ModeDrain.c
    • -102
    • +229
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -1
    • +1
    /firmware/App/Services/Reservoirs.c
    • -1
    • +1
    /firmware/App/Services/Reservoirs.h
    • -3
    • +21
    /firmware/App/Services/WatchdogMgmt.c
Thursday 04 Mar 2021
1:17 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added acid and bicarb tests

Options
    • -14
    • +14
    /firmware/App/Controllers/ConcentratePumps.c
    • -2
    • +2
    /firmware/App/Controllers/ConcentratePumps.h
    • -35
    • +63
    /firmware/App/Controllers/ConductivitySensors.c
    • -1
    • +4
    /firmware/App/Controllers/ConductivitySensors.h
    • -1
    • +1
    /firmware/App/Controllers/TemperatureSensors.c
    • -0
    • +1
    /firmware/App/DGCommon.h
    • -41
    • +158
    /firmware/App/Modes/ModeFill.c
    • -1
    • +0
    /firmware/App/Modes/ModeFill.h
    • -2
    • +6
    /firmware/App/Modes/ModeRecirculate.c
    • -2
    • +2
    /firmware/App/Modes/ModeStandby.c
Tuesday 02 Mar 2021
9:35 pm

Dara Navaei

DEN-5963 worked on the heat disinfect states

Options
    • -23
    • +23
    /firmware/App/Controllers/DrainPump.c
    • -8
    • +8
    /firmware/App/Controllers/Heaters.c
    • -3
    • +3
    /firmware/App/Controllers/Heaters.h
    • -79
    • +121
    /firmware/App/Modes/ModeHeatDisinfect.c
4:26 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Fixed FPGA revision

Options
    • -5
    • +5
    /firmware/App/Services/FPGA.c
11:57 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Fixed drain pump conversion error when pump is off

Options
    • -2
    • +13
    /firmware/App/Controllers/DrainPump.c
11:23 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Expanded fill command to accept start/stop flag

Options
    • -0
    • +7
    /firmware/App/Services/Reservoirs.h
    • -4
    • +12
    /firmware/App/Services/SystemCommMessages.c