dgfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-7091: Added handler for alarm clear

DEN-7091: Added new CAN channel for UI to DG comm

Addressed for both DG and HD.

Addressed for both DG and HD.

DEN-6890: Addressed code review comments

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Because the fluid leak detector is packaged as part of a 16-bit (LSB + MSB) representing the GPIOs of the FPGA. This is to save space. I use a bitmask to extract that one bit I need which is repres...

Because the fluid leak detector is packaged as part of a 16-bit (LSB + MSB) representing the GPIOs of the FPGA. This is to save space. I use a bitmask to extract that one bit I need which is representative of the fluid leak detector state (dry/1 vs. wet/0).

DEN-6890: Addressed code review comments

Why is this called fpgaGPIO? Why not leakDetector or something that is more representative of your driver?

Why is this called fpgaGPIO? Why not leakDetector or something that is more representative of your driver?

We started adding the sensors's part number and model. Could you please add it here?

We started adding the sensors's part number and model. Could you please add it here?

Removed.

Removed.

Added.

Added.

Addressed code review comments

    • -14
    • +18
    /firmware/App/Tasks/TaskPriority.c
DEN-6890: Removed unnecessary accelerometer calibration parameter message

If no params, just remove this line from header.

If no params, just remove this line from header.

Did you add a call to this function in TaskPriority.c?

Did you add a call to this function in TaskPriority.c?

Probably don't need OperationModes.h either.

Probably don't need OperationModes.h either.

DEN-6890: Implemented first pass of DG Fluid Leak Detector driver

DG-DEN-6890_Fluid Leak Detector Driver
DG-DEN-6890_Fluid Leak Detector Driver
DEN-6890: Implemented first pass of DG Fluid Leak Detector driver

    • -0
    • +255
    /firmware/App/Controllers/FluidLeak.c
    • -0
    • +56
    /firmware/App/Controllers/FluidLeak.h
DEN-5963 work in progress. tested cancellation path with water

    • -12
    • +29
    /firmware/App/Controllers/Heaters.c
    • -86
    • +124
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +22
    /firmware/App/Services/Reservoirs.c
    • -18
    • +0
    /firmware/App/Services/WatchdogMgmt.c
DEN-5963 added other inlet and outlet fans RPM

    • -6
    • +6
    /firmware/App/Modes/ModeHeatDisinfect.c
DEN-5963 tested heat disinfect

    • -102
    • +229
    /firmware/App/Modes/ModeHeatDisinfect.c
    • -1
    • +2
    /firmware/App/Modes/ModeHeatDisinfect.h
    • -3
    • +21
    /firmware/App/Services/WatchdogMgmt.c
DEN-7091: Added acid and bicarb tests

    • -41
    • +158
    /firmware/App/Modes/ModeFill.c
DEN-5963 worked on the heat disinfect states

    • -23
    • +23
    /firmware/App/Controllers/DrainPump.c
    • -79
    • +121
    /firmware/App/Modes/ModeHeatDisinfect.c
DEN-7091: Fixed FPGA revision

DEN-7091: Fixed drain pump conversion error when pump is off

    • -2
    • +13
    /firmware/App/Controllers/DrainPump.c
DEN-7091: Expanded fill command to accept start/stop flag