ConcentratePumps.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Resolved merge conflicts from DENBUG-318

  1. … 5 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
Merged release/p1b/staging

  1. … 5 more files in changeset.
DENBUG-298 updated the code from staging

  1. … 5 more files in changeset.
DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 4 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

DEN-17263 addressed the code review comments

Done

Done

Done

Done

I used fabs so all are positive when monitoring is started.

I used fabs so all are positive when monitoring is started.

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

DENBUG-314 added more comment

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

DEN-17263 fixed the code to check the direction of the concentrate pumps and then decide based on that whether the measured speed values being negative or positive is correct or not

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

DEN-17263 added code to check the concentrate pumps speed direction

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

DENBUG-307 added code to broadcast the concentrate pumps speed the way they are regardless of the direction of the pump