ConcentratePumps.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
DG-DENBUG-298_User Unable TO Deliver Saline P1B Staging
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

I used fabs so all are positive when monitoring is started.

I used fabs so all are positive when monitoring is started.

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging
DG-DENBUG-307_Concentrate Pump Tube Ruptures During Heat Disinfection Staging
DG-DEN-17220_Release 20 P1B Staging
DG-DEN-17220_Release 20 P1B Staging
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Removed the typecast.

Removed the typecast.

Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary? Seems like &concPump->concentratePumps[ i ] is already that type.

Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary? Seems like &concPump->concentratePumps[ i ] is already that type.

DG-DEN-17135_Concentrate Pump Calibration Staging
DG-DEN-17135_Concentrate Pump Calibration Staging