Activity dgfirmware/firmware/App/Controllers/ConcentratePumps.c

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	8
Last Commit:	19 Nov
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 04 Apr

3:46 pm

Dara Navaei

More
8a89e04
changed 5 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 3 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c
… 4 more files in changeset.

3:04 pm

Dara Navaei

More
DG-DENBUG-307-1
Closed

11:00 am

Michael Garthwaite

More
DG-DENBUG-307-1
finished reviewing

Wednesday 02 Apr

11:14 am

Sean Nash

More
DG-DENBUG-307-1
finished reviewing

11:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:13 am

Sean Nash

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

11:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:04 am

Dara Navaei

More
12bc101
changed 1 file
develop

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

- -22
- +7
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

10:45 am

Dara Navaei

More
e764f4a
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 4 more DG-DENBUG-307-1

DEN-17263 addressed the code review comments

- -22
- +7
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

10:28 am

Dara Navaei

More
Re: DG-DENBUG-307-1
replied to Sean Nash

Done

Done

10:27 am

Dara Navaei

More
Re: DG-DENBUG-307-1
replied to Sean Nash

Done

Done

10:26 am

Dara Navaei

More
Re: DG-DENBUG-307-1
replied to Sean Nash

I used fabs so all are positive when monitoring is started.

I used fabs so all are positive when monitoring is started.

Tuesday 01 Apr

9:03 am

Sean Nash

More
Re: DG-DENBUG-307-1
commented on review

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

9:01 am

Sean Nash

More
Re: DG-DENBUG-307-1
commented on review

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

Aren't speeds (commanded and measured) always positive? Do we need the fabs?

8:59 am

Sean Nash

More
Re: DG-DENBUG-307-1
commented on review

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

Friday 28 Mar

3:25 pm

Dara Navaei

More
756177b
changed 1 file
develop

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

- -0
- +1
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

Tuesday 25 Mar

3:25 pm

Dara Navaei

More
b85e597
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 4 more DG-DENBUG-307-1

DENBUG-314 added more comment

- -0
- +1
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

Monday 24 Mar

1:55 pm

Dara Navaei

More
4779ed2
changed 1 file
develop

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

- -3
- +3
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

1:55 pm

Dara Navaei

More
32e90c9
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 4 more DG-DENBUG-307-1

DEN-17263 fixed the code to check the direction of the concentrate pumps and then decide based on that whether the measured speed values being negative or positive is correct or not

- -3
- +3
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

11:16 am

Dara Navaei

More
11d4c39
changed 1 file
develop

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

- -0
- +11
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

11:15 am

Dara Navaei

More
4a55794
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 4 more DG-DENBUG-307-1

DEN-17263 added code to check the concentrate pumps speed direction

- -0
- +11
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

9:53 am

Dara Navaei

More
5648a6d
changed 1 file
develop

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

- -1
- +7
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

9:52 am

Dara Navaei

More
7d4008c
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 4 more DG-DENBUG-307-1

DENBUG-307 added code to broadcast the concentrate pumps speed the way they are regardless of the direction of the pump

- -1
- +7
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

9:42 am

Dara Navaei

More
df89590
changed 1 file
develop

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

- -2
- +4
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

9:41 am

Dara Navaei

More
7d6cf3f
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 4 more DG-DENBUG-307-1

DENBUG-307 made the concentrate pumps speed check all absolute to be able to check both positive and negative targets and measured speeds

- -5
- +6
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

Friday 21 Mar

1:49 pm

Dara Navaei

More
c20dacd
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 4 more DG-DENBUG-307-1

DEN-17263 change the concentrate pumps speed check to not use fabs for the measured values. The target speed is checked in fabs to cover the negative target speeds

- -3
- +4
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

Tuesday 18 Mar

3:46 pm

Dara Navaei

More
cbd3f0e
changed 1 file
develop

Merge branch 'DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging' into develop

- -3
- +8
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

3:40 pm

Dara Navaei

More
df0df23
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 4 more DG-DENBUG-307-1

DENBUG-309 added mode flush to the 5% tolerance of the concentrate pumps speed check

- -3
- +8
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

Friday 07 Mar

3:00 pm

Dara Navaei

More
8a5838d
changed 1 file
develop

Merged DENBUG-307

- -6
- +9
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

2:49 pm

Dara Navaei

More
d5fb5e8
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-307-concentrate-pump-tube-ruptures-during-heat-disinfection-staging and 4 more DG-DENBUG-307-1

DENBUG-309 changed the concnetrate pumps speed monitor to 5% in heat disinfect

- -6
- +9
./ConcentratePumps.c
- History
- Source
- Diff
./ConcentratePumps.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2025-12-15 19:20 -0800