Reservoirs.h

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 100 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 100 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 2 more files in changeset.
DEN-16587 Update to match other branch.

  1. … 2 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 2 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

  1. … 2 more files in changeset.
Question was in relation to DG gen idle sub-state, not HD mode.

Question was in relation to DG gen idle sub-state, not HD mode.

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Tre...

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Treatment only.

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen id...

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen idle states).

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Updated.

Updated.

DG idle reservoir out of range - rewording " DG idle reservoir weight out of range" would be better?

DG idle reservoir out of range - rewording " DG idle reservoir weight out of range" would be better?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Updated.

Updated.

RESOLVED in CODE WLAKTHROUGH

RESOLVED in CODE WLAKTHROUGH

This should be a fault alarm. Like the properties of alarm 189 (drain pump RPM out of range)

This should be a fault alarm. Like the properties of alarm 189 (drain pump RPM out of range)

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

Update properties and other alarm changes to match -1 branch.

Update properties and other alarm changes to match -1 branch.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Dara meant for you to add units to end of name (i.e. MAX_IDLE_RSVR_WEIGHT_GAIN_ML).

Dara meant for you to add units to end of name (i.e. MAX_IDLE_RSVR_WEIGHT_GAIN_ML).

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Use 2 U32 Data macro and log initial weight as well.

Use 2 U32 Data macro and log initial weight as well.