dgfirmware / firmware / App / Services

Reservoirs.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 07 Feb
5:52 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Reservoirs.h
  2. … 100 more files in changeset.
Wednesday 29 Jan
6:46 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Reservoirs.h
  2. … 100 more files in changeset.
Friday 15 Nov 2024
12:53 pm

Dara Navaei

Friday 16 Feb 2024
10:59 am

Dara Navaei

10:59 am

Dara Navaei and Sean Nash

10:58 am

Dara Navaei

10:57 am

Dara Navaei

Thursday 15 Feb 2024
4:11 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Reservoirs.h
  2. … 2 more files in changeset.
4:05 pm

Darren Cox <darren_m@cox.net>

DEN-16587 Update to match other branch.

Options
    • -0
    • +1
    ./Reservoirs.h
  2. … 2 more files in changeset.
3:46 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Reservoirs.h
  2. … 2 more files in changeset.
12:52 pm

Sean Nash

12:52 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:16 pm

Darren Cox <darren_m@cox.net>

DEN-16587 Added reservoir transfer flag, move invalid fill check to task exec function.

Options
    • -0
    • +1
    ./Reservoirs.h
  2. … 2 more files in changeset.
11:01 am

Sean Nash

Question was in relation to DG gen idle sub-state, not HD mode.

Question was in relation to DG gen idle sub-state, not HD mode.

9:53 am

Darren Cox

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Tre...

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Treatment only.

9:28 am

Sean Nash

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen id...

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen idle states).

Wednesday 14 Feb 2024
2:37 pm

Vinayakam Mani

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:15 pm

Darren Cox

Updated.

Updated.

Friday 09 Feb 2024
9:43 am

Vinayakam Mani

DG idle reservoir out of range - rewording " DG idle reservoir weight out of range" would be better?

DG idle reservoir out of range - rewording " DG idle reservoir weight out of range" would be better?

Thursday 08 Feb 2024
1:48 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:08 pm

Darren Cox

Updated.

Updated.

Tuesday 06 Feb 2024
12:36 pm

Dara Navaei

RESOLVED in CODE WLAKTHROUGH

RESOLVED in CODE WLAKTHROUGH

12:36 pm

Dara Navaei

This should be a fault alarm. Like the properties of alarm 189 (drain pump RPM out of range)

This should be a fault alarm. Like the properties of alarm 189 (drain pump RPM out of range)

12:32 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

Monday 05 Feb 2024
1:42 pm

Sean Nash

Update properties and other alarm changes to match -1 branch.

Update properties and other alarm changes to match -1 branch.

1:41 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:40 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:40 pm

Sean Nash

Dara meant for you to add units to end of name (i.e. MAX_IDLE_RSVR_WEIGHT_GAIN_ML).

Dara meant for you to add units to end of name (i.e. MAX_IDLE_RSVR_WEIGHT_GAIN_ML).

1:39 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 02 Feb 2024
10:32 am

Sean Nash

Use 2 U32 Data macro and log initial weight as well.

Use 2 U32 Data macro and log initial weight as well.